From: Paul Cercueil <paul.cercueil@bootlin.com>
To: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH] clkdev: Improve clock discovery with clk_find()
Date: Mon, 16 Nov 2026 14:56:23 +0100 [thread overview]
Message-ID: <2a117360a6842fd3b1929aeade3b05320c9ad4d8.camel@bootlin.com> (raw)
In-Reply-To: <20261103084915.8405-1-paul.cercueil@bootlin.com>
Hi Russell,
FYI I merged this patch into another patchset (of which you're in Cc)
called "ACPI: platform: ACPI 6.5 fixed clock support":
https://lore.kernel.org/linux-acpi/20261116135217.37038-1-paul.cercueil@bootlin.com/T/
So that you also get the context about why it's needed.
Cheers,
-Paul
Le mardi 03 novembre 2026 à 09:49 +0100, Paul Cercueil a écrit :
> With a setup where a clock provider registers a clock with a device name
> "mydev" and a clock name "myclk", calling clk_find("mydev", NULL) would
> not actually return any match.
>
> Update the code so that we can support this while maintaining the
> existing behaviour:
>
> - clk_find("dev", "con") matches in order of priority ("dev", "con"),
> ("dev", *) and (*, "con");
> - clk_find(NULL, "con") matches (*, "con");
> - clk_find("dev", NULL) matches the first case of ("dev", *).
> Note that in that case we don't handle wildcards for the device name
> or it would end up matching everything.
>
> Signed-off-by: Paul Cercueil <paul.cercueil@bootlin.com>
> ---
> drivers/clk/clkdev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index 919fc680ae4d..ee6c0afd6ec0 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -53,7 +53,9 @@ static struct clk_lookup *clk_find(const char *dev_id, const
> char *con_id)
> match += 2;
> }
> if (p->con_id) {
> - if (!con_id || strcmp(p->con_id, con_id))
> + if (!con_id && !p->dev_id)
> + continue;
> + if (con_id && strcmp(p->con_id, con_id))
> continue;
> match += 1;
> }
prev parent reply other threads:[~2026-11-16 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 8:49 Paul Cercueil
2026-11-16 13:56 ` Paul Cercueil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a117360a6842fd3b1929aeade3b05320c9ad4d8.camel@bootlin.com \
--to=paul.cercueil@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®