From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 406CE346E7D for ; Fri, 22 May 2026 09:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779441688; cv=none; b=a6rs34oXAK0iSu7tDx8lOB+j6I6BMizbq9b0XCuswV3tvluFupLNFxPkyKsfggi8hVfIN3ExFZsXce7GdEHsPbz1zWCT1VjmC1cKPtQL4LkEFrzxFEvzAsKeGjKkL2b90JLItXjlj+86GTbLeDI8xpIHvTNdeHWvT89VwFeh4ZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779441688; c=relaxed/simple; bh=wRoazhwqy/LGdWqNsz6ZbYTEW9e0MWez/WLRYs5P6yA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G9GC1t58HnHo7N5xWAvLIlENZF/jNi5SITUQUDO+Kkyb/yROaZ2D2p8DfkuXR1RbQKxnXK0kFWD2qzBVaHD3XLBKTfJLb3Fd/GFhcPaomHvZQ9/GYNcN541wo/oEeTOMqVgL2vabSwLJSLL5gdxgoneogERy0qHzmzw2wu+HOuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=XkHkLDKj; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="XkHkLDKj" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-44ce78ab5feso5933559f8f.0 for ; Fri, 22 May 2026 02:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1779441684; x=1780046484; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=AJOgUrZoGB6SnVjXzRYIRgyj/cL/Yt2spEyFm2v+9LQ=; b=XkHkLDKj9/QW2o3v1fDd2uAQLJvTOkCP/7xgHdPiqAw6p6FDUHgqtUJkOcxn/43BMa ALifpCzQW+vxMwlImO68DDPTz100y36corrixqTcTF0CzsuEtjuTqXZseKDJLuGFwj1a KG+8JLLpudsr0TP7kq+rhPmAmmp4N8rx9M/g50s4zjogVkr3k9Oelv7L+RwGRxRvZ2p4 GgCi0W09fsT+W93XgjvEPkOHNMKa9LYBObgdnVzB5VCI+MVLA42WVDkTZ38cgPQ6K5Kp hWm6rE4/dgKcO1QkUpojmKpxTNDI0o9BBQA0p8gNRM5msugWNPYpbpScD3hJSOEeLmUI Y/nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779441684; x=1780046484; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AJOgUrZoGB6SnVjXzRYIRgyj/cL/Yt2spEyFm2v+9LQ=; b=gVYZdNE5eZky8Y40YT9FyMBr64Xxs1sczdF7UxOntiP8/0TvH3pKpmZwBxjwvOmhwS T1Vwj5NbWPPmCJUweCn3xh+86lAp1StMXqfEwFwoynN4NSCShH93S9kDdFEz+UsxwAAs toBngbe0w/lf9GPdltzDiEFwR+lEjLmczv1ZwJL8SsgZSlxFK9BxcT1CX3rPnAwwjZ3j aYp/DgqAU6ED9rBFXdmN64ozuxKTGSgpYu5yQdgCPVi6I7+JpFF9F+UKfuGs79uk7sgo h4L7MpXh84kVYWcu8O+prH7Om2MgjJ0dUnnb5zYAZQ2Rle+i3II9J/B+lPFARwrQ+7QH T8VQ== X-Forwarded-Encrypted: i=1; AFNElJ//4cpMiPPmPfbJDX/C34ZvLBFdI9UL4JpBgePa2rAmkScHpziA6pYZy7hOWNzqRgZGDlLXUcz502+y/fQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwfwsxHvPfthQhDbaxHo/2i0GuNqVDiMJecunrjyQUVzgauU8RY 5s295KMyQPYFvjT/XlD82fa7IqYUCu2+WBmp6ATO4vcVJ3AREtPmw+HAYUNp7c20w9lcOSzHqgX XF2EVECGiOJecDloOTkj8xZzt71b+H8wOU+qVoOpfvaeLkzKb2h3OunWdi8Q= X-Gm-Gg: Acq92OGMV2RhUV/9chl5JtIdXzOFdf2v7/DjkhJr2WoTkXrG7PhnvJO/g++vMHEjEC6 N3RhCRt13V+iViVVKrg+9WVYcj5WC0k/+tn8S72m2gEOQ65QTTsRTAqE3X+Ap5QjSwPj7gMYM7i T+5iiHMa0rYNToWjl7OfvoD5PWGAfivaFsv3yh/BBoqGREzf5u8CNuN2Y77Fm2P1B62jjyk8IkL 68SGS2f/57KN1c1AVUzMgAsBOqxZqhzw5rniZlK30LcNdLQP9o5G4xkdXkiS9AfJvWJOO7Begj+ IN59kt9jYwVBegyn35I5Vgfdz3WLvdH4DZLh/IUmXu95KhT/9r0SiSa8UJTyLRp1teC9FbIY2Ep 7itMjSA11v8dgX+BPgboLo8IhtNZSrCLi7ZGRrutA9ILrgP938pjf/DxzVrO4rDx+qcX944RSxb Lhwv9YWHC7TrPCWjPz5c8EpcKw38chKGCrt9TQieiQ/ivV5Mn9RW9zIiYL4GsnnwjSpRnL5UylF UGxdunBbsg= X-Received: by 2002:a05:6000:1867:b0:45e:9433:f301 with SMTP id ffacd0b85a97d-45eb38df5f5mr4080423f8f.41.1779441684385; Fri, 22 May 2026 02:21:24 -0700 (PDT) Received: from ?IPV6:2001:67c:2fbc:1:c745:5339:4482:9cce? ([2001:67c:2fbc:1:c745:5339:4482:9cce]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6d70d89sm2816997f8f.37.2026.05.22.02.21.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 02:21:23 -0700 (PDT) Message-ID: <2a191e9f-f86c-4f1c-9f76-e0a7557ce51a@openvpn.net> Date: Fri, 22 May 2026 11:21:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ovpn: fix peer refcount leak in TCP error paths To: Pavitra Jha Cc: sd@queasysnail.net, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260522091718.270956-1-jhapavitra98@gmail.com> Content-Language: en-US From: Antonio Quartulli Autocrypt: addr=antonio@openvpn.net; keydata= xsFNBFN3k+ABEADEvXdJZVUfqxGOKByfkExNpKzFzAwHYjhOb3MTlzSLlVKLRIHxe/Etj13I X6tcViNYiIiJxmeHAH7FUj/yAISW56lynAEt7OdkGpZf3HGXRQz1Xi0PWuUINa4QW+ipaKmv voR4b1wZQ9cZ787KLmu10VF1duHW/IewDx9GUQIzChqQVI3lSHRCo90Z/NQ75ZL/rbR3UHB+ EWLIh8Lz1cdE47VaVyX6f0yr3Itx0ZuyIWPrctlHwV5bUdA4JnyY3QvJh4yJPYh9I69HZWsj qplU2WxEfM6+OlaM9iKOUhVxjpkFXheD57EGdVkuG0YhizVF4p9MKGB42D70pfS3EiYdTaKf WzbiFUunOHLJ4hyAi75d4ugxU02DsUjw/0t0kfHtj2V0x1169Hp/NTW1jkqgPWtIsjn+dkde dG9mXk5QrvbpihgpcmNbtloSdkRZ02lsxkUzpG8U64X8WK6LuRz7BZ7p5t/WzaR/hCdOiQCG RNup2UTNDrZpWxpwadXMnJsyJcVX4BAKaWGsm5IQyXXBUdguHVa7To/JIBlhjlKackKWoBnI Ojl8VQhVLcD551iJ61w4aQH6bHxdTjz65MT2OrW/mFZbtIwWSeif6axrYpVCyERIDEKrX5AV rOmGEaUGsCd16FueoaM2Hf96BH3SI3/q2w+g058RedLOZVZtyQARAQABzSdBbnRvbmlvIFF1 YXJ0dWxsaSA8YW50b25pb0BvcGVudnBuLm5ldD7Cwa0EEwEIAFcCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AYGGhrcHM6Ly9rZXlzLm9wZW5wZ3Aub3JnFiEEyr2hKCAXwmchmIXHSPDM to9Z0UwFAmj3PEoFCShLq0sACgkQSPDMto9Z0Uw7/BAAtMIP/wzpiYn+Di0TWwNAEqDUcGnv JQ0CrFu8WzdtNo1TvEh5oqSLyO0xWaiGeDcC5bQOAAumN+0Aa8NPqhCH5O0eKslzP69cz247 4Yfx/lpNejqDaeu0Gh3kybbT84M+yFJWwbjeT9zPwfSDyoyDfBHbSb46FGoTqXR+YBp9t/CV MuXryL/vn+RmH/R8+s1T/wF2cXpQr3uXuV3e0ccKw33CugxQJsS4pqbaCmYKilLmwNBSHNrD 77BnGkml15Hd6XFFvbmxIAJVnH9ZceLln1DpjVvg5pg4BRPeWiZwf5/7UwOw+tksSIoNllUH 4z/VgsIcRw/5QyjVpUQLPY5kdr57ywieSh0agJ160fP8s/okUqqn6UQV5fE8/HBIloIbf7yW LDE5mYqmcxDzTUqdstKZzIi91QRVLgXgoi7WOeLF2WjITCWd1YcrmX/SEPnOWkK0oNr5ykb0 4XuLLzK9l9MzFkwTOwOWiQNFcxXZ9CdW2sC7G+uxhQ+x8AQW+WoLkKJF2vbREMjLqctPU1A4 557A9xZBI2xg0xWVaaOWr4eyd4vpfKY3VFlxLT7zMy/IKtsm6N01ekXwui1Zb9oWtsP3OaRx gZ5bmW8qwhk5XnNgbSfjehOO7EphsyCBgKkQZtjFyQqQZaDdQ+GTo1t6xnfBB6/TwS7pNpf2 ZvLulFbOOARoRsrsEgorBgEEAZdVAQUBAQdAyD3gsxqcxX256G9lLJ+NFhi7BQpchUat6mSA Pb+1yCQDAQgHwsF8BBgBCAAmFiEEyr2hKCAXwmchmIXHSPDMto9Z0UwFAmhGyuwCGwwFCQHh M4AACgkQSPDMto9Z0UwymQ//Z1tIZaaJM7CH8npDlnbzrI938cE0Ry5acrw2EWd0aGGUaW+L +lu6N1kTOVZiU6rnkjib+9FXwW1LhAUiLYYn2OlVpVT1kBSniR00L3oE62UpFgZbD3hr5S/i o4+ZB8fffAfD6llKxbRWNED9UrfiVh02EgYYS2Jmy+V4BT8+KJGyxNFv0LFSJjwb8zQZ5vVZ 5FPYsSQ5JQdAzYNmA99cbLlNpyHbzbHr2bXr4t8b/ri04Swn+Kzpo+811W/rkq/mI1v+yM/6 o7+0586l1MQ9m0LMj6vLXrBDN0ioGa1/97GhP8LtLE4Hlh+S8jPSDn+8BkSB4+4IpijQKtrA qVTaiP4v3Y6faqJArPch5FHKgu+rn7bMqoipKjVzKGUXroGoUHwjzeaOnnnwYMvkDIwHiAW6 XgzE5ZREn2ffEsSnVPzA4QkjP+QX/5RZoH1983gb7eOXbP/KQhiH6SO1UBAmgPKSKQGRAYYt cJX1bHWYQHTtefBGoKrbkzksL5ZvTdNRcC44/Z5u4yhNmAsq4K6wDQu0JbADv69J56jPaCM+ gg9NWuSR3XNVOui/0JRVx4qd3SnsnwsuF5xy+fD0ocYBLuksVmHa4FsJq9113Or2fM+10t1m yBIZwIDEBLu9zxGUYLenla/gHde+UnSs+mycN0sya9ahOBTG/57k7w/aQLc= Organization: OpenVPN Inc. In-Reply-To: <20260522091718.270956-1-jhapavitra98@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 22/05/2026 11:17, Pavitra Jha wrote: > diff --git a/drivers/net/ovpn/tcp.c b/drivers/net/ovpn/tcp.c > index d651ce85c..2c7d830e7 100644 > --- a/drivers/net/ovpn/tcp.c > +++ b/drivers/net/ovpn/tcp.c > @@ -283,9 +283,9 @@ static void ovpn_tcp_send_sock(struct ovpn_peer *peer, struct sock *sk) > /* in case of TCP error we can't recover the VPN > * stream therefore we abort the connection > */ > - if (ovpn_peer_hold(peer)) > - if (!schedule_work(&peer->tcp.defer_del_work)) > - ovpn_peer_put(peer); > + ovpn_peer_hold(peer); > + if (!schedule_work(&peer->tcp.defer_del_work)) > + ovpn_peer_put(peer); > > /* we bail out immediately and keep tx_in_progress set > * to true. This way we prevent more TX attempts This patch now lacks the RX part. Please wait 24h between submissions (i.e. before sending v3). More comments may come in in the meantime. Regards, -- Antonio Quartulli OpenVPN Inc.