From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D5F1146D55 for ; Tue, 15 Oct 2024 10:46:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728989203; cv=none; b=dblx1WjG4h1taaAbkPkeApzu0BLbYrTeKy0uP1VtWGIPSjwB1wqFTSwmzoE8BxGjm0V3DFe+m23rlitECT4z/sNpsSpZbOUrjkR3I698VFi7111kE7Fzm2G+WC7SCfVGbKkSnYVt0zYsixa1Pb6ykyMorbl0bNygpAs/ERa51OA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728989203; c=relaxed/simple; bh=fW476nZCmDCSRgye7UwJvzeVl9dNa+iwAAalvvIkHZM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ROMA5l2RTiK2NpaP00SY4BdWHD10AtKO0tgtzwVq2AiJ0bt1NwBispqkEJ0FQ+U7GOouL1oMCPYJjVKzoD5dJNMILX1oESTCbRwmiWk/pwLtZEWWxJ4oyvTyBrr0HgEO1E2ciePN8w64qcmjyMWCYqCv77F2QYC1BiHOrUWTCz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=U4F7Y0ga; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U4F7Y0ga" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728989200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IDU1D/r+iHdlN/95BqAJt4M/vmdPwT06riD32mBzX2I=; b=U4F7Y0ga9ueo4j4fdoDJgbi2y6dXhtVj6v9EIPMmgqMtpg1+gjUyNrQNN1ajumbixAAue8 6FlTmwZGr4t9VJBnBYNORj3h+QkW99T9NFMrx3bgmwhj6xD+OElt8UEZGClPoEGg96g2vB UzSDGD0BJsar/5b3wwmOFia9a4IK9jY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-119-nsQ-24BTNBatpgatfrMQEQ-1; Tue, 15 Oct 2024 06:46:39 -0400 X-MC-Unique: nsQ-24BTNBatpgatfrMQEQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-431159f2864so27302175e9.0 for ; Tue, 15 Oct 2024 03:46:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728989198; x=1729593998; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IDU1D/r+iHdlN/95BqAJt4M/vmdPwT06riD32mBzX2I=; b=YWrgoPC9ukbxYDIcaLL3vrvqW167kTB/OWvWrKH4Tnni81oMfcpOoDd1FaBvI/dpdk 4s4dqV7boErwjpabyxaHEpUPurEI/EdRaGfIKs+rXRC5X2aVDrmAi38l/DHZJuqL4XKy y2owTE9IJkXPnCbMQyMtXoAXDehcWsvM/iThanPVSeMAfxPXrEB/nwnlaf1u7dNuNMxl RWr3gucf+XayypsIB+Ui6xoME2uSKtLeE3BO92ept3E5kNwGy5x9UmeWdPKrHggA/Bie P3AzbBztqm+JougF8344wuvLS52PKub3EIRqYSRz22AlUiEDh8WFfiRuEEH/mDKY1N7o Qlyg== X-Forwarded-Encrypted: i=1; AJvYcCWihUjZaoD17553tnvx/zA+UyKYm5OiGCSffYbxNYFmcPFRWAniAL3MQ0JesCEqbmli3F7jTP/N3FKltMM=@vger.kernel.org X-Gm-Message-State: AOJu0YymT3Zk1w6T4DEw9AIz1K/uLCxYjy6Fl3wcaQhcQNfFI2YrYP3u UdVxdrohLomEGuyEryjWg5fEGb9dKNzKsNPVlZ1aa9o3hty6f0VowQ1Wg96Kgnavo6ejlyX5NAR Bp+TaONgXRJ9Dt7uhJ+9cOpBWBfiFg6sH81TlRin4y5rvVB8ES3Bkm+1r5LKljw== X-Received: by 2002:a05:600c:1c03:b0:426:593c:9361 with SMTP id 5b1f17b1804b1-4314a35ee09mr387505e9.26.1728989198391; Tue, 15 Oct 2024 03:46:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5tzDNsvw78nPVMi9k1REjGUg4XGV2iEzziTWMsPaqrmq2TWxV+DN6MD4mOFzehVuI5P/yng== X-Received: by 2002:a05:600c:1c03:b0:426:593c:9361 with SMTP id 5b1f17b1804b1-4314a35ee09mr387165e9.26.1728989197940; Tue, 15 Oct 2024 03:46:37 -0700 (PDT) Received: from [10.202.147.124] (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4313f56ea05sm14089065e9.23.2024.10.15.03.46.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Oct 2024 03:46:37 -0700 (PDT) Message-ID: <2a212bcf-a8ee-4f10-9c5b-948b9f6895f3@redhat.com> Date: Tue, 15 Oct 2024 12:46:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf test: Fix probe testsuite with a new error message To: Arnaldo Carvalho de Melo Cc: Arnaldo Carvalho de Melo , Namhyung Kim , Ian Rogers , Kan Liang , Jiri Olsa , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users , Masami Hiramatsu , Michael Petlan References: <20241010051620.1066407-1-namhyung@kernel.org> Content-Language: en-US From: Veronika Molnarova In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/10/24 16:40, Arnaldo Carvalho de Melo wrote: > On Thu, Oct 10, 2024, 10:31 AM Veronika Molnarova > wrote: > >> >> >> On 10/10/24 14:50, Arnaldo Carvalho de Melo wrote: >>> On Thu, Oct 10, 2024 at 09:48:52AM -0300, Arnaldo Carvalho de Melo wrote: >>>> On Wed, Oct 09, 2024 at 10:16:20PM -0700, Namhyung Kim wrote: >>>>> On my system, it's constantly failing because of new error message from >>>>> perf probe. It should update the regex pattern to match the message - >>>>> "A function DIE doesn't have decl_line. Maybe broken DWARF?". >>>>> >>>>> $ sudo head -n 2 /sys/kernel/debug/kprobes/blacklist | cut -f2 >>>>> warn_thunk_thunk >>>>> asm_exc_divide_error >>>>> >>>>> $ sudo perf probe warn_thunk_thunk >>>>> A function DIE doesn't have decl_line. Maybe broken DWARF? >>>>> A function DIE doesn't have decl_line. Maybe broken DWARF? >>>>> Probe point 'warn_thunk_thunk' not found. >>>>> Error: Failed to add events. >>>>> >>>>> $ sudo perf probe asm_exc_overflow >>>>> Failed to find scope of probe point. >>>>> Error: Failed to add events. >>>> >>>> We discussed this in the past, I came up with a similar patch, Veronika >>>> rightly pointed out that this may point to a real problem, Masami said >>>> that since these are for DWARF from assembly those are known issues, I >>>> suggested Veronika checked if the CU where the function came from was >>>> generated from Assembly (there are DWARF tags that have that info), IIRC >>>> she said she would try to do it. >>>> >>>> I'll try to find out the threads and see what happened. >>> >>> https://lore.kernel.org/all/ZvXhJLkJcR99Y2sF@google.com/T/#u >>> >>> Veronika, was there a v3? >>> >>> Thanks, >> Well the patch was already applied upstream so we are talking about a fix >> not v3, right? > > > > > Can you provide a url for the patch that was applied upstream? > > I just checked at > > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh?h=perf-tools-next > > And I'm not seeing it. Well the patch adding the failing test case that you can see at https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh?h=perf-tools-next There was the whole patchset that contained the failing probe test case. The patchset was applied and merged upstream so there won't be a v3 for the failing test case, instead we will send a fix patch resolving the mentioned issue. Hopefully this explains the confusion that I think happened. We will send the next patchset soon containing also the patch fixing the probe issue with bad dwarf so if there will still be some confusion that should resolve that. - Veronika > > - Arnaldo > > As Arnaldo mentioned, I got together a fix patch that checks > >> the CU for the Assembly for blacklisted probe. Michael also suggested the >> possibility to check multiple blacklisted probes if we are not able to >> check >> for the Assembly, so I also added that. >> >> I will send the fix patch soon as part of the perftool upstreaming patchset >> to prevent conflicts happening. Hopefully, this can be at the start of the >> next week if all of the checks pass. >> >> Thanks, >> Veronika >>> >>> - Arnaldo >>> >> >> >