From: Jijie Shao <shaojijie@huawei.com>
To: Bo Sun <bo@mboxify.com>, <netdev@vger.kernel.org>,
<kuba@kernel.org>, <vadim.fedorenko@linux.dev>
Cc: <shaojijie@huawei.com>, <pabeni@redhat.com>, <jerinj@marvell.com>,
<lcherian@marvell.com>, <sgoutham@marvell.com>,
<gakula@marvell.com>, <sbhatta@marvell.com>, <hkelam@marvell.com>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] octeontx2-af: CGX: replace kfree() with rvu_free_bitmap()
Date: Wed, 25 Feb 2026 17:23:42 +0800 [thread overview]
Message-ID: <2a2813e8-c94a-419f-9c45-eda88f285faf@huawei.com> (raw)
In-Reply-To: <20260225082348.2519131-1-bo@mboxify.com>
on 2026/2/25 16:23, Bo Sun wrote:
> mac_to_index_bmap is allocated with rvu_alloc_bitmap(), so free it
> with rvu_free_bitmap() instead of open-coding kfree(.bmap) to keep
> the alloc/free API pairing consistent.
Reviewed-by: Jijie Shao <shaojijie@huawei.com>
>
> Signed-off-by: Bo Sun <bo@mboxify.com>
> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> ---
> drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> index 6000795823a3..4f33a816bc7a 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> @@ -1822,7 +1822,7 @@ static int cgx_lmac_exit(struct cgx *cgx)
> continue;
> cgx->mac_ops->mac_pause_frm_config(cgx, lmac->lmac_id, false);
> cgx_configure_interrupt(cgx, lmac, lmac->lmac_id, true);
> - kfree(lmac->mac_to_index_bmap.bmap);
> + rvu_free_bitmap(&lmac->mac_to_index_bmap);
> rvu_free_bitmap(&lmac->rx_fc_pfvf_bmap);
> rvu_free_bitmap(&lmac->tx_fc_pfvf_bmap);
> kfree(lmac->name);
>
>
next prev parent reply other threads:[~2026-02-25 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 8:23 Bo Sun
2026-02-25 9:23 ` Jijie Shao [this message]
2026-02-27 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a2813e8-c94a-419f-9c45-eda88f285faf@huawei.com \
--to=shaojijie@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=bo@mboxify.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®