From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from imap4.hz.codethink.co.uk (imap4.hz.codethink.co.uk [188.40.203.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E16838F956 for ; Tue, 13 Jan 2026 09:26:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.40.203.114 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768296418; cv=none; b=VE/HOsdpM67sXL8Q03XtVx2fJLWY5vEZlP6Mvihct/ED4eYm+q3J/9f8P5e/lZ8BnWBp/MLoxz5EsLMf8YD/PXxR624qHf/AkvZgt1fMkPnhiLysYHHDp+rncRfqi4UyTLpOamHuOTOhjJOZAvRiof78PG2gtAskg82suQVzcp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768296418; c=relaxed/simple; bh=TOJFfGxTOS9FFufWNJZSdCmI/wH4h9gopFYrvfP3uvA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sjksO0bPJZUNe0VubEvnFMjdBtM9dj+lQx68W2k7Cz7t1xurng915jGgrB2d/uDmWHJj7mYk18b2URYTf33zO30ia/xWVAsFM9PFgGMgb9DhIcNfP3WaPoVtAl24OfMFUc0OC/88MZHIhQltxA3WIMtCYCoPPufDoPUZ20WMBI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk; spf=pass smtp.mailfrom=codethink.co.uk; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b=vHmCKgwv; arc=none smtp.client-ip=188.40.203.114 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b="vHmCKgwv" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codethink.co.uk; s=imap4-20230908; h=Sender:Content-Transfer-Encoding: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Reply-To; bh=iwhRz1qvbi1/fe/0umje0amzQnKdrgwi6Ba7ekT00jc=; b=vHmCKgwvdh4dx1Iv kGr3yHQ4o2bZUoYuCUk3Gj5PGdY0MqoJnxNIH/rnfkhvofRMZl0P44RYu0zToMxEPRuhARc9YsMkY NfWWYyAVRs7+cC2q03ckTT82jGkUoOdLdW06CUTFgndQ4lAXRdOS1FLkfIM4ikQV8fuzQLs30H+RP 4OT0/KbfcrzJNasHZV13j4fOxva71j6lK59chDTj/uLt5O97yDmHHNopz2XsrbcPkKPWf3LsZafLw U3RzmVSRuHVkvQHmyulcxFr3T6fTgRFy8mZpf/OCL4rrjBG0ffvtx+s4HYND0Drf2qvPRajDIOyM0 0TNCK0AaCsUNcmfyVA==; Received: from [63.135.74.212] (helo=[192.168.1.241]) by imap4.hz.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1vfafh-00GFza-Au; Tue, 13 Jan 2026 09:26:41 +0000 Message-ID: <2a289c18-b5b7-497c-bd6d-a25602706b23@codethink.co.uk> Date: Tue, 13 Jan 2026 09:26:37 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/khugepaged: make khugepaged_collapse_control static To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, david@kernel.org References: <20260112161820.604669-1-ben.dooks@codethink.co.uk> <49229782-acf5-4e33-b317-63399deb6f6d@lucifer.local> Content-Language: en-GB From: Ben Dooks Organization: Codethink Limited. In-Reply-To: <49229782-acf5-4e33-b317-63399deb6f6d@lucifer.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: ben.dooks@codethink.co.uk On 12/01/2026 16:33, Lorenzo Stoakes wrote: > On Mon, Jan 12, 2026 at 04:18:20PM +0000, Ben Dooks wrote: >> Make khugepaged_collapse_control as it is not exported. >> Fixes the following sparse warning: >> >> mm/khugepaged.c:829:25: warning: symbol 'khugepaged_collapse_control' was not declared. Should it be static? > > Thanks for the patch, but sorry to say that this has already been addressed in > [0]. > > [0]: https://lore.kernel.org/all/20251224111351.41042-14-shivankg@amd.com/ > >> >> Fixes: 34d6b470ab9cf ("mm/khugepaged: add struct collapse_control") > > (Small note: for something like this that isn't fixing an actual bug we don't > use a fixes like this). Is this a subsystem preference because I was told I needed it for other patches. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html