mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Jun Yan <jerrysteve1101@gmail.com>
Cc: shawn.lin@rock-chips.com, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	Ulf Hansson <ulfh@kernel.org>
Subject: Re: [PATCH] mmc: sdhci-of-dwcmshc: downgrade HS200/HS400 clock-reduce message to dev_dbg
Date: Tue, 13 Oct 2026 17:05:23 +0800	[thread overview]
Message-ID: <2a29adf5-2a59-4287-8b10-68a62f317421@rock-chips.com> (raw)
In-Reply-To: <20261009084604.385664-1-jerrysteve1101@gmail.com>

Hi Jun

在 2026/10/09 星期五 16:46, Jun Yan 写道:
> dwcmshc_rk3568_set_clock() refuses to lower the bus clock below 52 MHz
> when the eMMC is in HS200/HS400 mode, since those modes require a
> minimum 52 MHz bus clock.  This is expected behaviour, but it is
> currently reported at dev_err level and therefore fires on every boot
> and on every suspend/resume cycle, cluttering the kernel log.
> 
> Demote the message to dev_dbg so it stays out of the default log while
> remaining available via dynamic debug.
> 

ios.clock and ios.timing are independent fields, updated by the MMC core
through separate calls. During card init, the core will hit this that
clock <= 52 MHz  but timing in {HS200, HS400}, so it is a normal,
intermediate state, not an error. So the message on every boot.

Changes it to dev_dbg is fine to me:
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks.

> Signed-off-by: Jun Yan <jerrysteve1101@gmail.com>
> ---
>   drivers/mmc/host/sdhci-of-dwcmshc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index c688f3eaf468..b4fb1c1e6d99 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -790,7 +790,7 @@ static void dwcmshc_rk3568_set_clock(struct sdhci_host *host, unsigned int clock
>   	if (clock <= 52000000) {
>   		if (host->mmc->ios.timing == MMC_TIMING_MMC_HS200 ||
>   		    host->mmc->ios.timing == MMC_TIMING_MMC_HS400) {
> -			dev_err(mmc_dev(host->mmc),
> +			dev_dbg(mmc_dev(host->mmc),
>   				"Can't reduce the clock below 52MHz in HS200/HS400 mode");
>   			goto enable_clk;
>   		}


  reply	other threads:[~2026-10-13  9:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09  8:46 Jun Yan
2026-10-13  9:05 ` Shawn Lin [this message]
2026-10-29 13:30 ` Adrian Hunter
2026-10-30 10:59 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a29adf5-2a59-4287-8b10-68a62f317421@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=adrian.hunter@intel.com \
    --cc=jerrysteve1101@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®