From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Liang Yan <lyan@suse.com>,
xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver
Date: Mon, 21 Aug 2017 15:30:45 -0400 [thread overview]
Message-ID: <2a2accd5-645c-7a68-f452-6ddbcccdb9cf@oracle.com> (raw)
In-Reply-To: <599AFF3A02000047000184DE@prv-mh.provo.novell.com>
Adding maintainer (Dmitry).
-boris
On 08/21/2017 11:41 AM, Liang Yan wrote:
> Long pressed key could not show right in XEN vncviewer after tigervnc
> client changed the way how to send repeat keys, from "Down Up Down Up
> ..." to "Down Down Dow." By enable EV_REP bit here, XEN keyboard
> device will trigger default auto repeat process from input subsystem,
> and make auto repeat keys work correctly.
>
> Signed-off-by: Liang Yan <lyan@suse.com>
> ---
> drivers/input/misc/xen-kbdfront.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/xen-kbdfront.c
> b/drivers/input/misc/xen-kbdfront.c
> index fa130e7b734c..0dce9830e2f4 100644
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
> kbd->id.product = 0xffff;
>
> __set_bit(EV_KEY, kbd->evbit);
> +__set_bit(EV_REP, kbd->evbit);
> for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
> __set_bit(i, kbd->keybit);
> for (i = KEY_OK; i < KEY_MAX; i++)
> --
> 2.14.0
>
next parent reply other threads:[~2017-08-21 19:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <599AFF3A02000047000184DE@prv-mh.provo.novell.com>
2017-08-21 19:30 ` Boris Ostrovsky [this message]
2017-08-21 20:28 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a2accd5-645c-7a68-f452-6ddbcccdb9cf@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyan@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®