From: "Arnd Bergmann" <arnd@arndb.de>
To: "Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
soc@kernel.org, "Olof Johansson" <olof@lixom.net>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/8] ARM: dts: uniphier: Rename usb-phy node to usb-glue
Date: Mon, 12 Sep 2022 10:32:16 +0200 [thread overview]
Message-ID: <2a386281-5a49-4df6-bafe-ef9de0fb0ca5@www.fastmail.com> (raw)
In-Reply-To: <20220912071511.1385-3-hayashi.kunihiko@socionext.com>
On Mon, Sep 12, 2022, at 9:15 AM, Kunihiko Hayashi wrote:
> Actual phy nodes are each child node. The parent node should be usb-glue
> node. This applies to the devicetre for Pro4 SoC.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> arch/arm/boot/dts/uniphier-pro4.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/uniphier-pro4.dtsi
> b/arch/arm/boot/dts/uniphier-pro4.dtsi
> index a53b73ee93e9..cf62821c69ca 100644
> --- a/arch/arm/boot/dts/uniphier-pro4.dtsi
> +++ b/arch/arm/boot/dts/uniphier-pro4.dtsi
> @@ -376,7 +376,7 @@ pinctrl: pinctrl {
> compatible = "socionext,uniphier-pro4-pinctrl";
> };
>
> - usb-phy {
> + usb-glue {
> compatible = "socionext,uniphier-pro4-usb2-phy";
> #address-cells = <1>;
> #size-cells = <0>;
Not sure about this one. What hardware does this node
actaully represent? I don't see any other soc dts files
refer to node names as 'glue', so there is probably a
better name for it. In the binding document, it's called
"usb-controller", but I'm not sure that is the right name
either.
Arnd
next prev parent reply other threads:[~2022-09-12 8:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 7:15 [PATCH v2 0/8] Update UniPhier armv7 devicetree Kunihiko Hayashi
2022-09-12 7:15 ` [PATCH v2 1/8] ARM: dts: uniphier: Rename pvtctl node to thermal-sensor Kunihiko Hayashi
2022-09-12 7:15 ` [PATCH v2 2/8] ARM: dts: uniphier: Rename usb-phy node to usb-glue Kunihiko Hayashi
2022-09-12 8:32 ` Arnd Bergmann [this message]
2022-09-12 12:10 ` Kunihiko Hayashi
2022-09-12 7:15 ` [PATCH v2 3/8] ARM: dts: uniphier: Rename gpio-hog node Kunihiko Hayashi
2022-09-12 7:15 ` [PATCH v2 4/8] ARM: dts: uniphier: Use GIC interrupt definitions Kunihiko Hayashi
2022-09-12 7:15 ` [PATCH v2 5/8] ARM: dts: uniphier: Add ahci controller and glue layer nodes for Pro4 Kunihiko Hayashi
2022-09-12 7:15 ` [PATCH v2 6/8] ARM: dts: uniphier: Add ahci controller and glue layer nodes for PXs2 Kunihiko Hayashi
2022-09-12 8:36 ` Arnd Bergmann
2022-09-12 12:10 ` Kunihiko Hayashi
2022-09-12 7:15 ` [PATCH v2 7/8] ARM: dts: uniphier: Move interrupt-parent property to each child node in uniphier-support-card Kunihiko Hayashi
2022-09-12 7:15 ` [PATCH v2 8/8] ARM: dts: uniphier: Remove compatible "snps,dw-pcie-ep" from pcie-ep node Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a386281-5a49-4df6-bafe-ef9de0fb0ca5@www.fastmail.com \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®