Re: [PATCH v2 3/3] power: supply: bq27xxx: add support for bq27z746

[Andrew Davis <afd@ti.com>]

On 8/18/26 4:48 AM, Henrik Grimler wrote:
> bq27z746 is similar to bq27z561, but has additional battery protection
> logic. The standard register map is a subset of the one found in
> bq27z561. There are some more differences among the ManufacturerAccess
> registers, but the ManufacturerAccess registers are currently not
> handled by the driver in any way. Therefore use the same regs and
> props for bq27z746 and bq27z561.
> 
> Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
> ---

Acked-by: Andrew Davis <afd@ti.com>

>   drivers/power/supply/bq27xxx_battery.c     | 6 ++++++
>   drivers/power/supply/bq27xxx_battery_i2c.c | 2 ++
>   include/linux/power/bq27xxx_battery.h      | 1 +
>   3 files changed, 9 insertions(+)
> 
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 01c9ec1116fa..5aed8b24119b 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -37,6 +37,7 @@
>    * https://www.ti.com/product/bq27441-g1
>    * https://www.ti.com/product/bq27621-g1
>    * https://www.ti.com/product/bq27z561
> + * https://www.ti.com/product/bq27z746
>    * https://www.ti.com/product/bq28z610
>    * https://www.ti.com/product/bq34z100-g1
>    * https://www.ti.com/product/bq78z100
> @@ -501,6 +502,7 @@ static u8
>   		[BQ27XXX_REG_AP] = 0x22,
>   		BQ27XXX_DM_REG_ROWS,
>   	},
> +#define bq27z746_regs bq27z561_regs
>   	bq28z610_regs[BQ27XXX_REG_MAX] = {
>   		[BQ27XXX_REG_CTRL] = 0x00,
>   		[BQ27XXX_REG_TEMP] = 0x06,
> @@ -836,6 +838,8 @@ static enum power_supply_property bq27z561_props[] = {
>   	POWER_SUPPLY_PROP_MANUFACTURER,
>   };
>   
> +#define bq27z746_props bq27z561_props
> +
>   static enum power_supply_property bq28z610_props[] = {
>   	POWER_SUPPLY_PROP_STATUS,
>   	POWER_SUPPLY_PROP_PRESENT,
> @@ -994,6 +998,7 @@ static struct bq27xxx_dm_reg bq27621_dm_regs[] = {
>   #endif
>   
>   #define bq27z561_dm_regs NULL
> +#define bq27z746_dm_regs NULL
>   #define bq28z610_dm_regs NULL
>   #define bq34z100_dm_regs NULL
>   #define bq78z100_dm_regs NULL
> @@ -1052,6 +1057,7 @@ static struct {
>   	[BQ27441]   = BQ27XXX_DATA(bq27441,   0x80008000, BQ27XXX_O_UTOT | BQ27XXX_O_CFGUP | BQ27XXX_O_RAM),
>   	[BQ27621]   = BQ27XXX_DATA(bq27621,   0x80008000, BQ27XXX_O_UTOT | BQ27XXX_O_CFGUP | BQ27XXX_O_RAM),
>   	[BQ27Z561]  = BQ27XXX_DATA(bq27z561,  0         , BQ27Z561_O_BITS),
> +	[BQ27Z746]  = BQ27XXX_DATA(bq27z746,  0         , BQ27Z561_O_BITS),
>   	[BQ28Z610]  = BQ27XXX_DATA(bq28z610,  0         , BQ27Z561_O_BITS),
>   	[BQ34Z100]  = BQ27XXX_DATA(bq34z100,  0         , BQ27XXX_O_OTDC | BQ27XXX_O_SOC_SI | \
>   							  BQ27XXX_O_HAS_CI | BQ27XXX_O_MUL_CHEM),
> diff --git a/drivers/power/supply/bq27xxx_battery_i2c.c b/drivers/power/supply/bq27xxx_battery_i2c.c
> index c4e7a9521d08..2a6b4534cb28 100644
> --- a/drivers/power/supply/bq27xxx_battery_i2c.c
> +++ b/drivers/power/supply/bq27xxx_battery_i2c.c
> @@ -253,6 +253,7 @@ static const struct i2c_device_id bq27xxx_i2c_id_table[] = {
>   	{ .name = "bq27441", .driver_data = BQ27441 },
>   	{ .name = "bq27621", .driver_data = BQ27621 },
>   	{ .name = "bq27z561", .driver_data = BQ27Z561 },
> +	{ .name = "bq27z746", .driver_data = BQ27Z746 },
>   	{ .name = "bq28z610", .driver_data = BQ28Z610 },
>   	{ .name = "bq34z100", .driver_data = BQ34Z100 },
>   	{ .name = "bq78z100", .driver_data = BQ78Z100 },
> @@ -290,6 +291,7 @@ static const struct of_device_id bq27xxx_battery_i2c_of_match_table[] = {
>   	{ .compatible = "ti,bq27441" },
>   	{ .compatible = "ti,bq27621" },
>   	{ .compatible = "ti,bq27z561" },
> +	{ .compatible = "ti,bq27z746" },
>   	{ .compatible = "ti,bq28z610" },
>   	{ .compatible = "ti,bq34z100" },
>   	{ .compatible = "ti,bq78z100" },
> diff --git a/include/linux/power/bq27xxx_battery.h b/include/linux/power/bq27xxx_battery.h
> index d56e1276aafe..0b833c4bb583 100644
> --- a/include/linux/power/bq27xxx_battery.h
> +++ b/include/linux/power/bq27xxx_battery.h
> @@ -33,6 +33,7 @@ enum bq27xxx_chip {
>   	BQ27441,
>   	BQ27621,
>   	BQ27Z561,
> +	BQ27Z746,
>   	BQ28Z610,
>   	BQ34Z100,
>   	BQ78Z100,
>