From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82A5E3A3E73 for ; Sat, 16 May 2026 15:23:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778944998; cv=none; b=Y04ot3ht2bIUm+n6kIwrNvp8jAPvaH+Pbp+CadTmKgLuGgFva6MgB444iU5i2cnVIoVjseBl4K1kftXQ+fCSWcDOdn8lqC7h3g/IwqXX6YFklCkAILAV3coa/Ha3cJ6ol18wqhTlloU/0VPVKkwZU7sls0gf8owTqS32H+eGigs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778944998; c=relaxed/simple; bh=6BFJ7gLNaRS9ktkzCQvQKWgq9XlntK/DE37quGD8Ifk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bdcVMmpKZwkJ4Q7Iq3Po9dwncGOOVZg7EekPCF1j6CRKDXXCeuzkTchyjZdC2DCgBogIWzJC4WDQnkX+oLDvRrqG1vHoSpowBuzKlNik2IE0f/H8i5Uss4rzkgnHrg/z75//f5gqdwZOXfuPRJR/NdBr3OpyTJjerQlH85D6hkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FMf0n3xf; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FMf0n3xf" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2adff872068so3857875ad.1 for ; Sat, 16 May 2026 08:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778944997; x=1779549797; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=45gdeTVXp8vVFaeA4pBMgjJh10jZNhmWEpnGdFpVpHo=; b=FMf0n3xft+PqHqJNDCEmWEQb5o/YjhaFNJWV5/WMUMFuJQX8qB8NSskIs5263Oo7vn aD3mHV8684XbkkX3Cm6IzbbBU/FJOwz2uFgUo2SxikOT0d9ofs2/W/sn6tlBve6n8c/y PsPA05rXzkVb6uCyOuakaljcQR35+EgLZ8pFuMYM6JWyCzzkfZh3qv3TFqa8kCD2/jQS h/5/NfN1b0wDgbUJt7WXUdJWm4NFCi/vvoQeVJitrlDe2o7A94oeDGbg+WFTOKPfv4v3 PbfuuI4S5AsJ3Mg9hr31WcPlMGEMiFpQmkPWy631fF5NtINrZYxrmoW5T4EuAXtBLEd3 5Q3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778944997; x=1779549797; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=45gdeTVXp8vVFaeA4pBMgjJh10jZNhmWEpnGdFpVpHo=; b=RoWsH4LOiMP0zG5+ojfP/o+QYyR3XeXQx9q5QxR2acjyDReJax8qdCjWWIOTOxx1yV cmHWrc9Yua45Kr+Dl5UY+JF+TrTHFU/hrMN9ARHHn2If/v1KnrHxdmPF3EWLJE3ghSuV O04ZmWPDiFl6vlgMbawF7K3ro+UkWvWrixP6Ou2+wg+CuvV6zKSmLM5PLMH/dOwiSZQ9 wDodh2wLJikDOeH/U16haO88US3A4d4A1hEExkZI0XBrUA0yMp0Q/JgFwiPJ9LLu+tkR 4Apf2Snhp/pzyogHbs09hkT41Qj9t5vF2oVijOkfTOaS9QW2agQVk6emP2FvCNUb8hfJ yAwA== X-Forwarded-Encrypted: i=1; AFNElJ+APmQhN/8FUvW2/ovN/Wkk30m0z9Ok2Nam7e0WtpPmMfyhBRpqPipiVqUECwl+0rZUu/K1o9Y7OqxpTek=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1gTRRegPBVl5SoWAcANWBxN+4yK2J9OlnXkHkKKPnHgHv37WL p+uh8Hfvp4YINetyTg1mjNKIb036gVoGk87gd9h8awA+KwsL4e2nwSvr X-Gm-Gg: Acq92OFUxjnU3dmwi/HcEOyHKew7FPi6PmEGCqrjxJEs+OYJdSneBlfO6KmY7Iix4+d Uhr+cZUMUzPTwvWRfojSl3xK4TY/ym62S0Vm/ihXtGQxn/gQnf7wtBEWW7W4EnOGj5VtPnOqgrP Y7X63B37j1xwmL0uTmYFNFiNBW8jI4bO/qZQsL1JJhMXoIPC7M4ZRQXiBqgK/1Ab/zg5TJCFGMm BPukeiVlR1xm4VvMuKURqt1ziopXWSc18FAL6yoAe4GgACKOqlJR5ULqbdjZNGE27jDDd9fudac CI7UA8xbAKPmVAkbJXR2kxwx76rjbSafIxfnLfYL0FYnPmn06Ft/J2ItPhrCvJzfzyzrInPeQx9 f35oTf4vF7puDd9P57PBXnLs8RtP4BZWZexoBnA33oV4xo9u8rMSjJdJ1Qw8sWY/tk+5XHChIwI 2l+1YNocQMaDzlANarLS1Z5JamWuiz5poy1b17BIrwbmQ7t8krpsJxpyVMxPoj4qui1oz9MPmY X-Received: by 2002:a17:902:b405:b0:2b2:4d78:eec2 with SMTP id d9443c01a7336-2bd7e92ca04mr67331295ad.18.1778944996887; Sat, 16 May 2026 08:23:16 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c82bb1231c7sm8737986a12.31.2026.05.16.08.23.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 May 2026 08:23:16 -0700 (PDT) Sender: Guenter Roeck Message-ID: <2a3c5a65-e2b7-4159-9d3c-eb6a8a600b37@roeck-us.net> Date: Sat, 16 May 2026 08:23:15 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] hwmon: (pmbus/adm1266) buffer-bound and timestamp fixes To: Abdurrahman Hussain , Alexandru Tachici Cc: Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260515-adm1266-fixes-v1-0-1c1ea1349cfe@nexthop.ai> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260515-adm1266-fixes-v1-0-1c1ea1349cfe@nexthop.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/15/26 15:11, Abdurrahman Hussain wrote: > This series fixes five pre-existing bugs in adm1266.c that were > surfaced by automated review of an in-flight feature series for the > same driver [1]. None of them are introduced by that feature work -- > they are all reachable on the existing driver as it sits in mainline. > Sending them standalone first, with Fixes: tags and Cc: stable, so > the feature respin (v5) can rebase on top. > > Patch 1 fixes a CLOCK_MONOTONIC vs CLOCK_REALTIME confusion in > adm1266_set_rtc(): the chip's SET_RTC register is documented to hold > wall-clock seconds, but the driver currently seeds it from > ktime_get_seconds(), giving blackbox records timestamps that reset > to small values on every host reboot. > > Patches 2 and 3 fix two ways the blackbox-info path can be driven > out of bounds by a misbehaving slave: a 5-byte stack buffer that > i2c_smbus_read_block_data() will memcpy() up to 32 bytes into, and > a record_count loop bound taken directly from the device with no > upper clamp against the 32-record dev_mem allocation. > > Patches 4 and 5 fix the two ways adm1266_pmbus_block_xfer() can > write past the end of a buffer: an off-by-one on the helper's own > read_buf (sized for the length+payload but missing the PEC byte the > i2c_msg length already accounts for), and a caller-side bug where > adm1266_nvmem_read_blackbox() advances its destination pointer in > 64-byte strides while the helper is willing to write up to 255 > bytes per call. > > [1] https://lore.kernel.org/r/20260512-adm1266-v3-0-a81a479b0bb0@nexthop.ai > > Signed-off-by: Abdurrahman Hussain > --- > Abdurrahman Hussain (5): > hwmon: (pmbus/adm1266) seed timestamp from the real-time clock > hwmon: (pmbus/adm1266) widen blackbox-info buffer to I2C_SMBUS_BLOCK_MAX > hwmon: (pmbus/adm1266) reject implausible blackbox record_count > hwmon: (pmbus/adm1266) include PEC byte in pmbus_block_xfer read buffer > hwmon: (pmbus/adm1266) bounce blackbox records through a protocol-sized buffer > > drivers/hwmon/pmbus/adm1266.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > --- > base-commit: 1f63dd8ca0dc05a8272bb8155f643c691d29bb11 > change-id: 20260514-adm1266-fixes-853003a0fad4 > > Best regards, > -- > Abdurrahman Hussain > Sashiko identified several issues with the driver as part of the review. Most if not all of them seem valid, but were not introduced with this series. I'll apply the series as is. Any fixes can come later. Thanks, Guenter