From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3026E12CDA5 for ; Mon, 17 Aug 2026 03:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786937887; cv=none; b=kjpXH/QlU6YhU7sgiNFVBwb1o+RokhgHMXqiKFCg9MFhTMr60xUJ3Xn5l5OB3f2FTui/Fe2/TZyWOZs7ymdHCUsoa28Xo0y028qTIt4wrPDLCGRtIgtCl/qAS97KmKO7epOKA33ADGHBQEGkHu1bmKhJdGXIuwWNG3otd9UFUXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786937887; c=relaxed/simple; bh=L1QKYawO/bP1FpGfIgXsMN2rGMfKShKr8tpW3QbVGkQ=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=tPRypTBylsBB9jJMax5rXveuh8usAYz/KRbHV1uqJcw/3h2TMjZUQ1Uajv3n6IPaqF7mLZj9r99o25uOMklhoDY6n5q9g2Bb2CAPQh8EdZKQC6ICdptzSmvcCnq+40bshj7I65bvqYH2D01B9+DtEPb3NXpiykw6p5AwSB217Rg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FFWk14+R; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FFWk14+R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 150B41F000E9; Mon, 17 Aug 2026 03:38:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786937885; bh=/HqfCf7CNS8GgNzXYlxF/N9ni38HaPB3vsDehNgqqNY=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=FFWk14+RL389a+vaz+oRB5KbwltPljqN92+Z1xgIncAodVa80VaPmvK9nHKaa9A+U JEEhgueA3I56jw0Dk5ObtASVsGWnv2hXdRhS19sqlrEFxydCRIKuutBtjn5blL615U cCvQh394jy4k7OOMtPp1fGlzF1+QVL5W4bgqqy4qwDjuTuZg9lIkfll8ibBMATC9Ze KOpXry60DfmTdTTw+/BtZWAx11x2cutWHK0ttbOqSO95Z5VpfVdKAkmkww9kb9QeJR pqEISLdgZ4HOu4+8Vt27ENnAxyQVfVofPdE6FiaBzfxNQyxS6CH5nast9U+ElYcj30 fasYpzNMyZ3Vw== Message-ID: <2a3d8702-f7fd-4013-8181-d9fd68b6aa18@kernel.org> Date: Mon, 17 Aug 2026 11:38:01 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, hans.holmberg@wdc.com, yonggil.song@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix O_DIRECT cleanup range for append writes To: Seongjae Jeong , jaegeuk@kernel.org References: <20260814105234.31620-1-jsjlee1020@gmail.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260814105234.31620-1-jsjlee1020@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/14/26 18:52, Seongjae Jeong wrote: > When an O_DIRECT write falls back to buffered I/O, > f2fs_flush_buffered_write() uses orig_pos to flush and invalidate > the page cache. > > For O_APPEND writes, f2fs_write_checks() updates iocb->ki_pos to > the end of the file after orig_pos has been saved. As a result, > the cleanup range can differ from the actual buffered write range. If generic_write_checks() can adjust writing position or amount of bytes to write, shouldn't we access iocb->ki_pos and iov_iter_count(from) after generic_write_checks()? Thanks, > > Save the write position after f2fs_write_checks() and use it for > the forced buffered I/O cleanup. > > Fixes: 92318f20d703 ("f2fs: preserve direct write semantics when buffering is forced") > Signed-off-by: Seongjae Jeong > --- > fs/f2fs/file.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index b99d9cdf9ba7..bf61545603e5 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -5313,6 +5313,7 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) > const loff_t pos = iocb->ki_pos; > const ssize_t count = iov_iter_count(from); > ssize_t ret; > + loff_t bufio_start_pos; > > if (unlikely(f2fs_cp_error(F2FS_I_SB(inode)))) { > ret = -EIO; > @@ -5343,6 +5344,8 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) > if (ret <= 0) > goto out_unlock; > > + bufio_start_pos = iocb->ki_pos; > + > /* Determine whether we will do a direct write or a buffered write. */ > dio = f2fs_should_use_dio(inode, iocb, from); > > @@ -5396,8 +5399,8 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) > */ > if (ret > 0 && !dio && (iocb->ki_flags & IOCB_DIRECT)) > f2fs_flush_buffered_write(iocb->ki_filp->f_mapping, > - orig_pos, > - orig_pos + ret - 1); > + bufio_start_pos, > + bufio_start_pos + ret - 1); > > return ret; > }