From: Cengiz Can <cengiz@kernel.wtf>
To: Biwen Li <biwen.li@nxp.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
peda@axentia.se, leoyang.li@nxp.com,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: pca954x: Add property to skip disabling PCA954x MUX device
Date: Sun, 29 Sep 2019 14:07:19 +0300 [thread overview]
Message-ID: <2a3f9ec1955e8b785888994e2a9b7cc0d5800a71.camel@kernel.wtf> (raw)
In-Reply-To: <20190929103638.46038-1-biwen.li@nxp.com>
Hello Biwen,
> + /* Errata ID E-00013 on board LS2088ARDB and LS2088ARDB:
> + * The point here is that you must not disable a mux if there
> + * are no pullups on the input or you mess up the I2C. This
> + * needs to be put into the DTS really as the kernel cannot
> + * know this otherwise.
> + */
Can you please explain what a "mess up" is?
And also, should we put this new DTS property in related default
bindings?
If not, are you planning a documentation update for the users to notify
them about this?
--
Cengiz Can <cengiz@kernel.wtf>
next prev parent reply other threads:[~2019-09-29 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 10:36 Biwen Li
2019-09-29 11:07 ` Cengiz Can [this message]
2019-09-30 2:48 ` [EXT] " Biwen Li
2019-09-29 21:21 ` Peter Rosin
2019-09-30 2:43 ` [EXT] " Biwen Li
2019-09-30 5:16 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a3f9ec1955e8b785888994e2a9b7cc0d5800a71.camel@kernel.wtf \
--to=cengiz@kernel.wtf \
--cc=biwen.li@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome