mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Rosen Penev <rosenp@gmail.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	linux-kernel@vger.kernel.org, jacob.e.keller@intel.com,
	horms@kernel.org, sd@queasysnail.net, chunkeey@gmail.com
Subject: Re: [PATCHv2 net-next 4/8] net: ibm: emac: remove mii_bus with devm
Date: Thu, 5 Sep 2024 12:12:06 +0200	[thread overview]
Message-ID: <2a44050f-89f8-446f-aa5f-3101ae46f314@redhat.com> (raw)
In-Reply-To: <20240903194312.12718-5-rosenp@gmail.com>

On 9/3/24 21:42, Rosen Penev wrote:
> diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
> index 459f893a0a56..4cf8af9052bf 100644
> --- a/drivers/net/ethernet/ibm/emac/core.c
> +++ b/drivers/net/ethernet/ibm/emac/core.c
> @@ -2580,6 +2580,7 @@ static const struct mii_phy_ops emac_dt_mdio_phy_ops = {
>   
>   static int emac_dt_mdio_probe(struct emac_instance *dev)
>   {
> +	struct mii_bus *bus;
>   	struct device_node *mii_np;
>   	int res;

Minor nit: please respect the reverse xmas tree above.

Thanks,

Paolo


  reply	other threads:[~2024-09-05 10:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 19:42 [PATCHv2 net-next 0/8] Rosen Penev
2024-09-03 19:42 ` [PATCHv2 net-next 1/8] net: ibm: emac: use devm for alloc_etherdev Rosen Penev
2024-09-03 19:42 ` [PATCHv2 net-next 2/8] net: ibm: emac: manage emac_irq with devm Rosen Penev
2024-09-03 19:42 ` [PATCHv2 net-next 3/8] net: ibm: emac: use devm for of_iomap Rosen Penev
2024-09-03 19:42 ` [PATCHv2 net-next 4/8] net: ibm: emac: remove mii_bus with devm Rosen Penev
2024-09-05 10:12   ` Paolo Abeni [this message]
2024-09-03 19:42 ` [PATCHv2 net-next 5/8] net: ibm: emac: use devm for register_netdev Rosen Penev
2024-09-03 19:42 ` [PATCHv2 net-next 6/8] net: ibm: emac: use netdev's phydev directly Rosen Penev
2024-09-05 10:10   ` Paolo Abeni
2024-09-03 19:42 ` [PATCHv2 net-next 7/8] net: ibm: emac: replace of_get_property Rosen Penev
2024-09-03 19:42 ` [PATCHv2 net-next 8/8] net: ibm: emac: remove all waiting code Rosen Penev
2024-09-05 10:27   ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a44050f-89f8-446f-aa5f-3101ae46f314@redhat.com \
    --to=pabeni@redhat.com \
    --cc=chunkeey@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rosenp@gmail.com \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®