From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D51F0C25B41 for ; Mon, 23 Oct 2023 08:17:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229593AbjJWIRM convert rfc822-to-8bit (ORCPT ); Mon, 23 Oct 2023 04:17:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjJWIRI (ORCPT ); Mon, 23 Oct 2023 04:17:08 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CDA78E for ; Mon, 23 Oct 2023 01:17:05 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-309-nQlSvGyiNSGMh4aakGXTrA-1; Mon, 23 Oct 2023 09:17:01 +0100 X-MC-Unique: nQlSvGyiNSGMh4aakGXTrA-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Mon, 23 Oct 2023 09:16:59 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Mon, 23 Oct 2023 09:16:59 +0100 From: David Laight To: 'Al Viro' CC: Eric Dumazet , gus Gusenleitner Klaus , Al Viro , Thomas Gleixner , lkml , Ingo Molnar , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "David S. Miller" , "dsahern@kernel.org" , "kuba@kernel.org" , Paolo Abeni Subject: RE: AW: [PATCH] amd64: Fix csum_partial_copy_generic() Thread-Topic: AW: [PATCH] amd64: Fix csum_partial_copy_generic() Thread-Index: AQHaBG0ELw1zxmi7jUCMTwySbq0j57BVpWHg///yIICAAXFNkA== Date: Mon, 23 Oct 2023 08:16:59 +0000 Message-ID: <2a4555bf640e4bc4b76e1ae14e5cb5e1@AcuMS.aculab.com> References: <20231018154205.GT800259@ZenIV> <20231019050250.GV800259@ZenIV> <20231019061427.GW800259@ZenIV> <20231019063925.GX800259@ZenIV> <20231019080615.GY800259@ZenIV> <20231021071525.GA789610@ZenIV> <20231021222203.GA800259@ZenIV> <5487af5c8c184ac896af2d0b32b3ff42@AcuMS.aculab.com> <20231022111153.GB800259@ZenIV> In-Reply-To: <20231022111153.GB800259@ZenIV> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro > Sent: 22 October 2023 12:12 > > On Sun, Oct 22, 2023 at 11:03:39AM +0000, David Laight wrote: > > > > + return -1; > > > > If you are going to return -1 the return type should be signed. > > It's a perfectly valid C to have return -1 in a function that > returns unsigned long long (or any other unsigned type, really)... It is also valid C to return a pointer :-) I also suspect that sparse will complain massively and require a lot of the horrid (__force) casts. (They should really be a function so that they are completely ignored by the compiler - unless the compiler needs a cast as well.) David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)