From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E05B3976A9 for ; Mon, 18 May 2026 10:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779099844; cv=none; b=S2epgxHIo378jCtDKvKepZmjh22aG+lmFns91yqoQq25pXOoWTVNedsubWE1Gzr9kVxLhhSvfLJhnFdtf+7agPtjQ7Gz2+nXzNLWZDK9Kf1LFVIUvdDo6ND+qhto82Y+av04VwLwzt3lIcIPx2jXSeMR1fUQvBRl9O5UAD0Vkwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779099844; c=relaxed/simple; bh=zej2Cpyl6kSQWSK0UynwC/MbemQJBK/YK0lG75EKZwU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O5A78wxgBD6+GSJsIjNs/L9fuwRNkNCnCYd3x5wLosexRHM+RhdZv7iPVhDOk/DLmfhGIP68xh1TLy0qzo8YKOPP2HQSfJbv5WrxL5KJec2cwPlRpygDlHBuSf4IopNldH+BzMYpUDq/JGSAkQKuYEHXq5hIIhs6xbpRiSdCkzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Dv1s9rIX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H/AaEFTP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Dv1s9rIX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H/AaEFTP" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I5bKA51696718 for ; Mon, 18 May 2026 10:24:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SA8886K6poJcpjofD22W11q9F+U2c/JpSKSwDMQIEm0=; b=Dv1s9rIX3+Tjr+2S TGEZDsVk9nR/3/xNb833XAcEk9IOGs84YjruEuDA8P1QN7uaV4WlzuPmH0kcuD+e 2a9qOu8nAN1PhMLaHKT+4iDIMfuVh6qXa7y90Ukn0kuEEVnpMBs7xnNAan2gjkJQ /3eruFmAFjfdJoNOB2VlmPFmareCwU8+FnC5g/unGsXY+f3eyzx0gu5Hh3uMt+K2 4kb6E4lPMqkiWEt14/OaaKJHYj3HJa77zy6HePr6kk5lvIlRyl3iBHCDVXx01LKl 58BOzRM9DC/bW/dn/iEFiIotOiV56Awg18WDPUPtygNUsUS4+/ZbtqDs4TQUOJNC P8AZcg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e7vsk17ym-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 10:24:02 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b461b36990so20141875ad.3 for ; Mon, 18 May 2026 03:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779099841; x=1779704641; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SA8886K6poJcpjofD22W11q9F+U2c/JpSKSwDMQIEm0=; b=H/AaEFTPmtKqCYxPBwQu1EHCC4Z5VB7qXr1lTkXEoHQNXS6Qo3HknFPwV7EwpBayHx rg4YYxduxI+2J1JSJTP5v8xwpvj97RHsQNOQgeaO4g88uwAODrjypnsBuSXXIq+gx1Ds 6lJ/eeoRvHkDhHwxP7XhLGLgWzxfJkzC2GXrEWy74g6rDbZ0ONvogtlQX3aU0To8gT/Y kmEy6tllNH5fvvJT8VqXpHggkvOSyYr/MZYBucuNWBLmqRYlWr2y6uB7B1FUzdFIc/xL tcBR7jrrCci6SLK9y48SZvlLuTaLAAU/ybUCuzvgUKwSOzfvwjrgbTx02npLfsjgVDh5 O9lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779099841; x=1779704641; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SA8886K6poJcpjofD22W11q9F+U2c/JpSKSwDMQIEm0=; b=H4jcLiGrO79uMA3SCFnAqJUJhjJ9LDj2iAlenVQ1ND0LCBR2uzTfgn4ceH65l7l5Ga zUyLPDY86KYcn3jE8efLHUapb06GGjbQRjj2n5FRptFebWX/bvw3AapMuKwctuWd3n8k 2iwtFwU5iRb2kBCFb4QsiOt0+KfNvklujZ5JZ6+VAwrW+Hin7LvICX1L3a3b7RneRUEc TtUYZW+5DSurb56xtsem7ESdOXm8E3/RlsSd9k7PmYqphs3jxx7NcEsD1G+lpDnAubpm n+7CopH/5Awu7YVk3S0U+fb51aYQlFIY5gPZTLQBmRiCEOKu0qq568jswTlrmrGdJcJ1 wTcw== X-Forwarded-Encrypted: i=1; AFNElJ9IqzaEDSUglYat+y+WRGh0C7zSYtnX1Epifhgqai9m2hUksMaGcZ+fgPQjwXJvKbwCtoYidt1BE9n163k=@vger.kernel.org X-Gm-Message-State: AOJu0YwyeDK05tMDZSZaK5tZdbNy1LxYisSLw4tJc99CW6WbtxTZFH81 AyjaXKTrIgErih+/dWnuh6bqiIA3fFc8w2zjVbpelrudOy5wgLbQnblCmMib4b4KEkJpwgvSFCt If/jr9ViBIX8hkmC89RSsyvR1jOaOty4zRqabUM4Npzi4WLsxrLP0S5k8rhfhYYQQhEk= X-Gm-Gg: Acq92OEm57uSyUtFjrAdy5l1r98iKsNw63o+hesGewYT97hV/wOASdZJ0y7UgzgzJ/L AaEI0svGO3w4bmk+At+ETvxc6NH/fQDmTGQ2BIBsQbAH/ICHtKSEUTWj6std6AnUcVc8OSF0JR9 FkEYOGuht1ynR0tluyMRTQt3ySNwMsfay55q0Gn71Oha8uyeFpsP+fDR+jyknM+Fa3LCskrVl9f fgLay5X5AQPbclDYUInaqiUI/fWUVZGe7xHjuh9a4TyT5r47pawE2HFrec7XUNsj4sxe5PxKeSI xZ0sRbfm0NQrr1SyEGIYVW05NiAkClMbKdmBYhp2lPPytpOwWYIV+hx+DFdsKNXUihbS2YCD+TU JhtZumfmpaQNoXD0VwrSCLNyZi9O65o3IIC/I6QNbZS7LU+PyLREk X-Received: by 2002:a17:903:987:b0:2ba:5a20:1d94 with SMTP id d9443c01a7336-2bd7e8459ddmr171304365ad.13.1779099841097; Mon, 18 May 2026 03:24:01 -0700 (PDT) X-Received: by 2002:a17:903:987:b0:2ba:5a20:1d94 with SMTP id d9443c01a7336-2bd7e8459ddmr171304015ad.13.1779099840607; Mon, 18 May 2026 03:24:00 -0700 (PDT) Received: from [10.218.5.182] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d12e38dsm145269515ad.77.2026.05.18.03.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 03:24:00 -0700 (PDT) Message-ID: <2a496bdf-4728-47b9-84ba-063712a6e5b6@oss.qualcomm.com> Date: Mon, 18 May 2026 15:53:53 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] clk: qcom: camcc-glymur: Add camera clock controller driver To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taniya Das , Konrad Dybcio References: <20260517-glymur_camcc-v4-0-9d00acffdbf7@oss.qualcomm.com> <20260517-glymur_camcc-v4-2-9d00acffdbf7@oss.qualcomm.com> <8bd4365e-0171-425c-9738-0b186047cb15@kernel.org> Content-Language: en-US From: Jagadeesh Kona In-Reply-To: <8bd4365e-0171-425c-9738-0b186047cb15@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDEwMCBTYWx0ZWRfX0xosAT8gmahy sXpAHIgOLeWEmprhv0RKtVnYZVtsaZn7eTStE5d8BvZOc1Y2mtbzD1VPVrNTw2im779cEHEOQwE 01c2cToDwMh9L5U19zpXEFtyQMR3Pc1AbH2xpzTdGEOUNOVYtFChBObcl0I9Ezw65neciMXzvYu AW/NyhHNFROXpcmSVdoN9XUYpj1OBf06UBo2lwDDcTOFR9n19zbEtnvDMAdQb8kSjjIGsm6o7wi kasOJdQs/MUJM21bnuk1hZ15SadpHuGvUocpEWs+mHchG9iF+RSblwdEhAbBC75zFCogRBxCgDH paFmgWpQ51IWpJjUawCF7/66WNj+1W/Ukr4Lt2lSUU6jSb7H9UZrbV8ch+yk9alFsG7Lhv3mp/Q Joitl+YuPytD8bIkh+y+iMNNdyfqOxKNMZCWIOutJykAjb8ChR9EkFB9DM5N2ISQSj0CrDshogx r9T5exer6rnCffdGi1Q== X-Authority-Analysis: v=2.4 cv=Bq+tB4X5 c=1 sm=1 tr=0 ts=6a0ae8c2 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=1leAgmdG7ggDTx2EHhMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: bBwa-YUlOB8NB4_jVpvtsZMgyUGMZMfQ X-Proofpoint-ORIG-GUID: bBwa-YUlOB8NB4_jVpvtsZMgyUGMZMfQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_02,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180100 On 5/18/2026 1:05 PM, Bryan O'Donoghue wrote: > On 17/05/2026 18:33, Jagadeesh Kona wrote: >> +/* 1200.0 MHz Configuration */ >> +static const struct alpha_pll_config cam_cc_pll0_config = { >> +    .l = 0x3e, >> +    .alpha = 0x8000, >> +    .config_ctl_val = 0x25c400e7, >> +    .config_ctl_hi_val = 0x0a8060e0, >> +    .config_ctl_hi1_val = 0xf51dea20, >> +    .user_ctl_val = 0x00008408, >> +    .user_ctl_hi_val = 0x00000002, >> +}; > > I'll again push back on these magic numbers. > > At the very least you should be mentioning in the cover letter log why you _aren't_ making that change. > > Just reposting and hoping it slips by the person making the comment isn't too cool. > > Why can't qcom update the python? script that generates this code to enumerate fields instead of magic numbers here ? > > I get you don't want to do it but, just ignoring the review feedback is no OK. > > What gives ? > Hi Bryan, I haven't ignored your comments & already responded to your earlier comment on why the bit fields are not defined. Most of these values are static settings we get from PLL HW team and we program them only once as is during bootup and are never reused again anywhere from PLL code, so these bits are not defined. Please find the earlier responses for your comments below: https://lore.kernel.org/all/b92a2cbb-fe8d-4378-aa02-d91e2e4dfff4@oss.qualcomm.com/ https://lore.kernel.org/all/009ecdbb-2297-44eb-862d-233e3290691c@oss.qualcomm.com/ Thanks, Jagadeesh