From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 071AE469847 for ; Tue, 4 Aug 2026 13:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785851940; cv=none; b=LF2dGxeZoR8iagSPkqJSIK9BrI7Fq10OMM7R96nMWDxj8bWXk0cf8eSZxKbrK+pDpUT3oikEq3i1472S98URWsgevI+TC2deQQdwjl27Cg5tT+4PiwjvtVkUBNWRqMm6PapP+XurFH4hU00/QxYbCC12gdM7STILSTsevdU3svk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785851940; c=relaxed/simple; bh=1OQBoAhCWQ27z4TbCoxEkZMbX/0Vwt1ZYg8nnzYUxtI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kVHzMYCqbG1IOtXytLb1kFgoW/x1f1ivq3VUeXLifi1p/A1gP62efTQplsKzad4UoAywBpZpg3NyOHOzVMPqxzdBscYQ/u7ohAs73BTGQZZh7rv2K4hTKqX3zdz3teOSZHqV1PnpBi4MC1DzTXklgCqj36Bb8e77SxZHZM+DZAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XF8K7ppF; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XF8K7ppF" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c9e30214d8fso3475150a12.3 for ; Tue, 04 Aug 2026 06:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785851936; x=1786456736; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zkuISwW42BAC8zrLAFu0d6zrzkKDpQ7MpBwlJbTNguI=; b=XF8K7ppFOMZTNDhPNkw6C1vRJgK0CsZR27UlF/zEQ1tLwXyXh05N+vwPdLjBjOHwB7 LgXBrM9wAVrVYlEnHx49Y9uXSBEcOBVW2I9kN707aQomZN4VV6JnUC7/JjIYDpvAYFVB Bt+LgcVQ8evqoIxxNP7F0mr49oHgDW7dv1o2ox20TFdopTJ9zU8fFhI7EAj4z/7Ubnfh WlfzlpzsZ+NnaJ3UAIBymPs3X1nZ2DkRdQKbnARcn5OuVVbQMZADKCqKM6Q1ZyGRtcXQ bne1GtllhyqhXuKbRONCE/TS7KhwJ/lzGTuvTrX8m1L91F30UM+8yxGAKo5dLMEdIgPA 7cRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785851936; x=1786456736; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=zkuISwW42BAC8zrLAFu0d6zrzkKDpQ7MpBwlJbTNguI=; b=G/HHT/BzSb/X/GMpdvV0EO/VYH0siJOHYPXMi70hlpLEIlTIhBWG49lNx8pvFkNnRw gQ0EggQtlGLVqlQHddgCdxbXTSy5Imf6zS8BE78jp36Bf/B2GmElfcmy2LmFmEuQCnnS 9s+KcEI8SgmtuiBfZKmrzFNySb1cIq9U/tOdvifFZ7UcbV/JBCU12zKSWpois42wmuc7 zczkAWbMExTqjkep5gb3x0wiy2NDxfKU+EBnh/TDnmovvJOp5RZC+neSdgwQAwqHNypH 1DnlHFJHv6QpxqoizPaUcozS2Ba/foMUrvSKTF5F/q4Hud4I2V9K4HBAPuo6gCJlNE6c TsIA== X-Forwarded-Encrypted: i=1; AHgh+Rqr+0ZreMYp/aBvu8bCfF+YE17gmdjWNIXG7mU3qV0ytbbFyRGQLQ8ZSrHa7d6NyeIW0jXhKgWZnxQNghU=@vger.kernel.org X-Gm-Message-State: AOJu0YwEC/WK3fZrHz01dW6velph0+Dk9CIqCIIpP31/K1k7RgYH7l2L +HykkeoNX5EpfG3Rz5x0QeckiF6xqyKolX0BFludHXqdrXywdqYs0hZL X-Gm-Gg: AR+sD13snh++JGs7yQk2b5ntNj/8Ea/e1pelfNPCgBL8gbXCYsfWqnOhZXTJRTTts2z E9T9CJeQPNxqPSMjctgSnCbydk3aL8uaY6NQz6hHQ4dB2WuggiO6h7cvg6vPADGSca7CO0eeJSC rRGC1w3LRjxmiKhmDd4aKklYT6hXJdJuUkJ+7L57xlR9KEehdTJfxlbqrxfgsydvnpGp8qyHWIp MnBFxzc7j6A37DcJ/dyPCVctKMVpUJPX11hCimlgjoZLj/vgwySFsxobaG35Rk8qQAtoXnjhGoi zAFBxB7uyK1jCfWH+vgk2HGB+OgpKtbc6b4+KPM8xOwvtlTc+g7TFbI6oYgNq5dqh5ULWx+TBUs YjxZeLkpKN2eImQjm32sHLDLzUBLAL/MugYToPO0qb/fWJPhfmX6hqX78WzaGo+1M2bpbMTB+NI EjwbfDpYTjvIrz+M1vFXce5LdzBcNm8czWDGKC2GQf+5FSTPuduQdXrQibrUbxzdV1rDQz1uuZT 1W+HlTJw7kDzwd12rOYrwGjcDqBGimQiuqynQ== X-Received: by 2002:a17:903:2d1:b0:2cc:6817:d9bc with SMTP id d9443c01a7336-2d0523e6ee5mr149437475ad.38.1785851936086; Tue, 04 Aug 2026 06:58:56 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31586402e53sm8194292eec.11.2026.08.04.06.58.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 06:58:55 -0700 (PDT) Sender: Guenter Roeck Message-ID: <2a49b3d2-a69d-445b-b478-edf0f3b763ea@roeck-us.net> Date: Tue, 4 Aug 2026 06:58:54 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hwmon: (ads7828) Check return value of regmap_read() in probe To: Qingshuang Fu , Akshay Bhat Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Qingshuang Fu References: <20260804091719.651479-1-fffsqian@163.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260804091719.651479-1-fffsqian@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/4/26 02:17, Qingshuang Fu wrote: > From: Qingshuang Fu > > ads7828_probe() issues a dummy regmap_read() to enable the internal > reference voltage when ext_vref is false. The original code ignores the > return value of regmap_read(). > > If the I2C read fails, the internal reference voltage will not be enabled, > and subsequent ADC readings return incorrect values without any error > indication. > This only applies to ADS7830, and the command does not have to succeed for this to work; the chip only needs to see a start/stop sequence. Worst case, the next command would enable it. Given that, I do not think this is a real problem (much less one requiring a stable backport), and I am not going to apply this patch. > Check the return value of regmap_read(), log an error message, and abort > probe on failure. This prevents registering a non-functional hwmon device. > FWIW, that logic would apply to every single driver which doesn't access the chip as part of the probe function. I don't even want to get there. Guenter > Fixes: 7a18afe80977 ("hwmon: (ads7828) Enable internal reference") > Signed-off-by: Qingshuang Fu > --- > drivers/hwmon/ads7828.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/ads7828.c b/drivers/hwmon/ads7828.c > index 149cfcec78dc..91ef0c4a08c4 100644 > --- a/drivers/hwmon/ads7828.c > +++ b/drivers/hwmon/ads7828.c > @@ -112,6 +112,7 @@ static int ads7828_probe(struct i2c_client *client) > unsigned int regval; > enum ads7828_chips chip; > struct regulator *reg; > + int ret; > > data = devm_kzalloc(dev, sizeof(struct ads7828_data), GFP_KERNEL); > if (!data) > @@ -166,8 +167,13 @@ static int ads7828_probe(struct i2c_client *client) > * voltage needs to settle before getting valid ADC data. So perform a > * dummy read to enable the internal reference voltage. > */ > - if (!ext_vref) > - regmap_read(data->regmap, data->cmd_byte, ®val); > + if (!ext_vref) { > + ret = regmap_read(data->regmap, data->cmd_byte, ®val); > + if (ret) { > + dev_err(dev, "dummy read failed to enable internal VREF: %d\n", ret); > + return ret; > + } > + } > > hwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name, > data, > > base-commit: 848acc8ffe1b7cd5f1bf427b93069becfebc2c9d