From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94A421EB5E3 for ; Wed, 1 Apr 2026 13:16:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775049380; cv=none; b=UQEMfSesFWHEHI2fDqfTvGNZJKtzhp7fpEbDDrx+k0Zr5VK6KH8leqjwtdrYy65wwedd++7HTO9t/9sIvWB4uNQebTt10aUsglrEZhzGpcbooKK8RaMy+g7TA9f1AWYAHeLR63/kLwPdeHbW1eeBEfSuGYMoiNf1ybQSLsXbkR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775049380; c=relaxed/simple; bh=9902Z8bwJc3Q39RpgPjOVL5Gtfuiy2WE5S+2aUwtZKY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=byMHLr6GdKwQq0zCFdAt7F+An4Gn5SzDdy5TkSLobGYAMYoq0EetoZ+CyvrpTXA6nHh6aHCmCDWXsMixq/VzUcUCuoEBqTiBY/6v3W7nT/3vPO3Ktqy5c5Exr4qtCcF/EVOGb4F8nXXvONC2As4xQ9fMjHWh6pTnh/NpbiKS3j4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=svdiGzrc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="svdiGzrc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E50A4C4CEF7; Wed, 1 Apr 2026 13:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775049380; bh=9902Z8bwJc3Q39RpgPjOVL5Gtfuiy2WE5S+2aUwtZKY=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=svdiGzrcfk4x1LDuTAegW9XCl4c112iOmtI/WvvUlvo5Jr1+PMI6MaVLPxclke/ZT YO0BjNAn6DrQ9JYzRi2GdX5/5qHC7eZqOBS7DKdwugS+qPF3DMhMGIRWpUuIXcHO/G yDaEjI1HrmmkATkyu7SSMk4jYJ+A9ikhdugkP+5kgkr3mx5oLehE5B8yPl+dJhjfuU yL9WMaUFzIEb1QJC5T073uvsHT5EGVtXIhHqIyOoqrHKHb2wivy3+H/GlwOtBGpiYE qPv1uc5uy0bgsY683nTX643oCpbXfwrVchQUGv1Q05hcD7SWL4pKp6QlTQc+w2wpAB v9J0Wj41vV5Qw== Message-ID: <2a4faf87-8c1c-4ea4-92ea-8619ae51b27d@kernel.org> Date: Wed, 1 Apr 2026 08:16:17 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: "Mario Limonciello (AMD)" Subject: Re: [PATCH v6 3/5] firmware: dmi: Add missing DMI entry types To: Borislav Petkov Cc: Yazen Ghannam , Jean Delvare , linux-kernel@vger.kernel.org, Jean Delvare References: <20260307141024.819807-1-superm1@kernel.org> <20260307141024.819807-4-superm1@kernel.org> <20260401110326.GAacz7fomOcX8eeo1V@fat_crate.local> Content-Language: en-US In-Reply-To: <20260401110326.GAacz7fomOcX8eeo1V@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/1/26 06:03, Borislav Petkov wrote: > On Sat, Mar 07, 2026 at 08:10:22AM -0600, Mario Limonciello (AMD) wrote: >> Type 43 through type 46 entry types are missing from the >> definitions in the dmi_entry_type enum. >> >> Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.1.pdf >> Suggested-by: Yazen Ghannam >> Reviewed-by: Jean Delvare >> Reviewed-by: Yazen Ghannam >> Signed-off-by: Mario Limonciello (AMD) >> --- >> v4: >> * Add tag (Yazen) >> * Correct text (Yazen) >> v3: >> * Add tag (Jean) >> --- >> include/linux/dmi.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/linux/dmi.h b/include/linux/dmi.h >> index 32b2529a73301..2eedf44e68012 100644 >> --- a/include/linux/dmi.h >> +++ b/include/linux/dmi.h >> @@ -70,6 +70,10 @@ enum dmi_entry_type { >> DMI_ENTRY_ADDITIONAL, >> DMI_ENTRY_ONBOARD_DEV_EXT, >> DMI_ENTRY_MGMT_CONTROLLER_HOST, >> + DMI_ENTRY_TPM_DEVICE, >> + DMI_ENTRY_PROCESSOR_ADDITIONAL, >> + DMI_ENTRY_FIRMWARE_INVENTORY, >> + DMI_ENTRY_STRING_PROPERTY, >> DMI_ENTRY_INACTIVE = 126, >> DMI_ENTRY_END_OF_TABLE = 127, >> }; >> -- > > Is there any particular reason this is a separate patch and not part of patch > 1? > They are two separate logical problems (indexing error and missing entries). I was trying to stick to one commit; one issue.