From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C51EC433EF for ; Wed, 1 Jun 2022 13:42:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348838AbiFANmi (ORCPT ); Wed, 1 Jun 2022 09:42:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242256AbiFANmf (ORCPT ); Wed, 1 Jun 2022 09:42:35 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB35A40E4D for ; Wed, 1 Jun 2022 06:42:33 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id d26so2399265wrb.13 for ; Wed, 01 Jun 2022 06:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=0GytTj9uVTzJjxEXvcs09ax+kKcNDhJOHsmTGe+kH8w=; b=vkNdWZInZ7+8GlW7lJ8mbeICVbcaP8DQoN8ZodMXz63//NHmpWtnr9eII0esKGgrJ7 XZYBnkrr/L3WwHZ8NWSVcJnc0y8O0CKd/oiv2XSilDkMaPN5i8KVJRKsC/hPW24GHylB 54AL2z6qZj0V3FbKgFf+vjfTlrH8rXmrt1f7q9DazKENMR+nluo+ffa+1nO4G5bQ7sSc v2M78eXcOhW+t4BcTtF+Bxy/0iWu1NsuO0my9VSoIk+281lWAsZo28aNYazzWoN5si3Z pzuXUwv/h9Iqp9KRhqZRzgiHF9iW4Z9pvq8vLWzBaE61/yL/BNOcVhI8MTRK33xydOlV d1zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0GytTj9uVTzJjxEXvcs09ax+kKcNDhJOHsmTGe+kH8w=; b=TS0D+lPFxZbsFgVrSpFYniRSB7YZzVCNoAUkoArtDlnwGGDexRPwXy2I5qMGPLP7J2 QY6kwpG8nP8rn45j8aY+QgNev3EeGUVJnYTe8McSSlN2AEDFDe9ICr6uMiP3aFsAdZ7t ZqjIesDCzfA8qlpLzmBpo16TRBzkwnHAn6WqVwvPr3VeQ3V3Uz51nen706d1ecxkiD6v BrPu2ylOC889vbnVmQvcpz//SQh9k8JX3tGf59tgcz0Erg5Gcer4rtWRxFp3anJbLzPV L+246Nan2FVyLcvjAbVJDbGM9S5pWeqZcMguzOW653o3shzYXxsLdwh3RtCV0cexPnMc 52lg== X-Gm-Message-State: AOAM531TWlC/LuMPlukL8QQXd7pUZ2IQ0++xh9iFVjYUxoT2Cdh83xQL MPuhj0nsFWJhnVduwAITBflftg== X-Google-Smtp-Source: ABdhPJw0w+np9l1PjYluSYsyZUX4C+fqmoxAweXAcsxF3ASzI26AfWihFIw/6vfhS7xpLk/6VmugwQ== X-Received: by 2002:adf:f789:0:b0:210:3534:636c with SMTP id q9-20020adff789000000b002103534636cmr12231263wrp.273.1654090952330; Wed, 01 Jun 2022 06:42:32 -0700 (PDT) Received: from [192.168.86.34] (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.googlemail.com with ESMTPSA id j26-20020a05600c1c1a00b003973e27b789sm7304163wms.27.2022.06.01.06.42.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 06:42:31 -0700 (PDT) Message-ID: <2a520eaf-c1de-aa91-3029-83f5469cdbb0@linaro.org> Date: Wed, 1 Jun 2022 14:42:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2] ASoC: qcom: soundwire: Add support for controlling audio CGCR from HLOS Content-Language: en-US To: Srinivasa Rao Mandadapu , Matthias Kaehlcke Cc: Stephen Boyd , agross@kernel.org, alsa-devel@alsa-project.org, bgoswami@quicinc.com, bjorn.andersson@linaro.org, broonie@kernel.org, devicetree@vger.kernel.org, judyhsiao@chromium.org, lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, perex@perex.cz, quic_plai@quicinc.com, quic_rohkumar@quicinc.com, robh+dt@kernel.org, tiwai@suse.com, vkoul@kernel.org References: <1652877755-25120-1-git-send-email-quic_srivasam@quicinc.com> <51b8aca1-e038-4907-e973-ebdbebaf9b28@quicinc.com> <7c74868d-624b-c18e-b377-026e70813fcc@quicinc.com> <1ec64a99-cfcf-c903-935b-d1bb0617c284@linaro.org> <61c151e2-c44c-3b84-9fed-a83abef83c17@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <61c151e2-c44c-3b84-9fed-a83abef83c17@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2022 14:15, Srinivasa Rao Mandadapu wrote: >>>>>>> +       ctrl->audio_cgcr = devm_reset_control_get_exclusive(dev, >>>>>>> "swr_audio_cgcr"); >>>>>>> +       if (IS_ERR(ctrl->audio_cgcr)) >>>>>>> +               dev_err(dev, "Failed to get audio_cgcr reset >>>>>>> required for soundwire-v1.6.0\n"); >>>>>> Why is there no return on error here? Is the reset optional? >>>>> Yes it's optional. For older platforms this is not required. >>>> If it's optional then either there should be no error message, or the >>>> error message should only be logged when the version is >= 1.6.0. There >>>> are few things worse than a kernel log riddled with misleading error >>>> messages. >>> >>> In that case, it can be done like below. Kindly let me know your >>> opinion on this. >>> >>> if (ctrl->version >= 0x01060000) { >> >> This is not true 1.7+ variants do not require anything as such. > > I think it applies for all upcoming versions as Qualcomm Hardware team. > Here is the not from HW Team. Am testing sm8450 which has 1.7.0 and it does not require/have such control. I dont understand what is the issue in adding a flag to struct qcom_swrm_data. This should give finer control rather than matching anything > 1.6. --srini >