From: "Paul E. McKenney" <paulmck@kernel.org>
To: Wander Lairson Costa <wander@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Kees Cook <keescook@chromium.org>,
Christian Brauner <brauner@kernel.org>,
Andrei Vagin <avagin@gmail.com>,
Shakeel Butt <shakeelb@google.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:PERFORMANCE EVENTS SUBSYSTEM"
<linux-perf-users@vger.kernel.org>, Hu Chunyu <chuhu@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v6 2/3] sched/task: Add the put_task_struct_atomic_safe() function
Date: Mon, 24 Apr 2023 14:54:00 -0700 [thread overview]
Message-ID: <2a57855e-da25-4c1a-bbca-0c75ddd5f7ba@paulmck-laptop> (raw)
In-Reply-To: <CAAq0SUkJQtBzhrTiHEHH3LnL8nM7j7ebh_OsRhNUr9mNfrbROA@mail.gmail.com>
On Mon, Apr 24, 2023 at 05:34:29PM -0300, Wander Lairson Costa wrote:
> On Mon, Apr 24, 2023 at 3:52 PM Paul E. McKenney <paulmck@kernel.org> wrote:
> > On Mon, Apr 24, 2023 at 03:43:09PM -0300, Wander Lairson Costa wrote:
> > > On Mon, Apr 24, 2023 at 3:09 PM Paul E. McKenney <paulmck@kernel.org> wrote:
> > > > On Fri, Apr 14, 2023 at 09:55:28AM -0300, Wander Lairson Costa wrote:
> > > > > Due to the possibility of indirectly acquiring sleeping locks, it is
> > > > > unsafe to call put_task_struct() in atomic contexts when the kernel is
> > > > > compiled with PREEMPT_RT.
> > > > >
> > > > > To mitigate this issue, this commit introduces
> > > > > put_task_struct_atomic_safe(), which schedules __put_task_struct()
> > > > > through call_rcu() when PREEMPT_RT is enabled. While a workqueue would
> > > > > be a more natural approach, we cannot allocate dynamic memory from
> > > > > atomic context in PREEMPT_RT, making the code more complex.
> > > > >
> > > > > This implementation ensures safe execution in atomic contexts and
> > > > > avoids any potential issues that may arise from using the non-atomic
> > > > > version.
> > > > >
> > > > > Signed-off-by: Wander Lairson Costa <wander@redhat.com>
> > > > > Reported-by: Hu Chunyu <chuhu@redhat.com>
> > > > > Cc: Paul McKenney <paulmck@kernel.org>
> > > > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > > > ---
> > > > > include/linux/sched/task.h | 31 +++++++++++++++++++++++++++++++
> > > > > kernel/fork.c | 8 ++++++++
> > > > > 2 files changed, 39 insertions(+)
> > > > >
> > > > > diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
> > > > > index b597b97b1f8f..5c13b83d7008 100644
> > > > > --- a/include/linux/sched/task.h
> > > > > +++ b/include/linux/sched/task.h
> > > > > @@ -141,6 +141,37 @@ static inline void put_task_struct_many(struct task_struct *t, int nr)
> > > > >
> > > > > void put_task_struct_rcu_user(struct task_struct *task);
> > > > >
> > > > > +extern void __delayed_put_task_struct(struct rcu_head *rhp);
> > > > > +
> > > > > +static inline void put_task_struct_atomic_safe(struct task_struct *task)
> > > > > +{
> > > > > + if (IS_ENABLED(CONFIG_PREEMPT_RT)) {
> > > > > + /*
> > > > > + * Decrement the refcount explicitly to avoid unnecessarily
> > > > > + * calling call_rcu.
> > > > > + */
> > > > > + if (refcount_dec_and_test(&task->usage))
> > > > > + /*
> > > > > + * under PREEMPT_RT, we can't call put_task_struct
> > > > > + * in atomic context because it will indirectly
> > > > > + * acquire sleeping locks.
> > > > > + * call_rcu() will schedule delayed_put_task_struct_rcu()
> > > > > + * to be called in process context.
> > > > > + *
> > > > > + * __put_task_struct() is called called when
> > > > > + * refcount_dec_and_test(&t->usage) succeeds.
> > > > > + *
> > > > > + * This means that it can't "conflict" with
> > > > > + * put_task_struct_rcu_user() which abuses ->rcu the same
> > > > > + * way; rcu_users has a reference so task->usage can't be
> > > > > + * zero after rcu_users 1 -> 0 transition.
> > > > > + */
> > > > > + call_rcu(&task->rcu, __delayed_put_task_struct);
> > > >
> > > > This will invoke __delayed_put_task_struct() with softirqs disabled.
> > > > Or do softirq-disabled contexts count as non-atomic in PREEMPT_RT?
> > >
> > > softirqs execute in thread context in PREEMPT_RT. We are good here.
> >
> > So the sleeping lock is a spinlock rather than (say) a mutex?
>
> Yes, under PREEMPT_RT, spinlocks are implemented in terms of rtmutex.
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Thanx, Paul
> > > > > + } else {
> > > > > + put_task_struct(task);
> > > > > + }
> > > > > +}
> > > > > +
> > > > > /* Free all architecture-specific resources held by a thread. */
> > > > > void release_thread(struct task_struct *dead_task);
> > > > >
> > > > > diff --git a/kernel/fork.c b/kernel/fork.c
> > > > > index 0c92f224c68c..9884794fe4b8 100644
> > > > > --- a/kernel/fork.c
> > > > > +++ b/kernel/fork.c
> > > > > @@ -854,6 +854,14 @@ void __put_task_struct(struct task_struct *tsk)
> > > > > }
> > > > > EXPORT_SYMBOL_GPL(__put_task_struct);
> > > > >
> > > > > +void __delayed_put_task_struct(struct rcu_head *rhp)
> > > > > +{
> > > > > + struct task_struct *task = container_of(rhp, struct task_struct, rcu);
> > > > > +
> > > > > + __put_task_struct(task);
> > > > > +}
> > > > > +EXPORT_SYMBOL_GPL(__delayed_put_task_struct);
> > > > > +
> > > > > void __init __weak arch_task_cache_init(void) { }
> > > > >
> > > > > /*
> > > > > --
> > > > > 2.39.2
> > > > >
> > > >
> > >
> >
>
next prev parent reply other threads:[~2023-04-24 21:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 12:55 [PATCH v6 0/3] Introduce put_task_struct_atomic_sleep() Wander Lairson Costa
2023-04-14 12:55 ` [PATCH v6 1/3] sched/core: warn on call put_task_struct in invalid context Wander Lairson Costa
2023-04-14 12:55 ` [PATCH v6 2/3] sched/task: Add the put_task_struct_atomic_safe() function Wander Lairson Costa
2023-04-17 18:51 ` Waiman Long
2023-04-18 14:18 ` Wander Lairson Costa
2023-04-18 14:26 ` Waiman Long
2023-04-24 18:09 ` Paul E. McKenney
2023-04-24 18:43 ` Wander Lairson Costa
2023-04-24 18:52 ` Paul E. McKenney
2023-04-24 20:34 ` Wander Lairson Costa
2023-04-24 21:54 ` Paul E. McKenney [this message]
2023-04-24 20:34 ` Steven Rostedt
2023-04-14 12:55 ` [PATCH v6 3/3] treewide: replace put_task_struct() witht the atomic safe version Wander Lairson Costa
2023-04-17 18:53 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a57855e-da25-4c1a-bbca-0c75ddd5f7ba@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=avagin@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=brauner@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=chuhu@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=ebiederm@xmission.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shakeelb@google.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wander@redhat.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®