From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16D3C11187 for ; Tue, 30 Apr 2024 04:14:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714450445; cv=none; b=cSUrG0IdSEoO+S/jcLuyY0lBo6grRhMCdkGZgsgh1GEZ9msaj9hSnDy8X+AVgYqYeDPzQxDPfPy90DksaowrDzDV2fyUAMV9K2OZgS9E1VgY/izaozW3rcA3xF+bTRDbujE6QwIHYsDaq/BmiRRZ/EygJjXhjLBgDLQTds0Dqgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714450445; c=relaxed/simple; bh=Q6DdmJVqJCfws1Srj4jcdR3dRP3+ld8JxaBObjp2YSY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YPWzhCjdONFFHfu7K1atLjhKed90XPdx37HS2sKyCCo7hZYRS7TTAZV/EXA9kOYW9rTHU0o2MOAicBiQAxwe8fyIyrslDLR56CMn7OP7W4LfYLuNCijidMimDDbaXH2EnlPxUfz6MmBGYYfhhDClU+rV0APBJWtUpSL5+9Xjdmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=LO6c3VmP; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="LO6c3VmP" Message-ID: <2a595561-0a11-4d5e-ac72-a7c3aab9c8f7@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714450441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JMSdFBlDa/50RQbZivm8NN3gqBiYEydcILXMMCleMt4=; b=LO6c3VmPgnDaz1QPrnQoPOe3Fj5Wv+O3ytNuDttKJzxlasHW+UEmqk2z+BZMW+cOhBbTzw DmihLwz3ZvhjnTWnf8x8uuwTtf4ZsAPa75uyuTE5g3mt+DaQ88nrecS9r8T6LGu0c58lu6 msSvpTtpQ0y4jVL3aO/Cy/Nv5xAVsDg= Date: Tue, 30 Apr 2024 12:13:31 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] bcachefs: Correct the FS_IOC_GETFLAGS to FS_IOC32_GETFLAGS in bch2_compat_fs_ioctl() To: Kent Overstreet Cc: linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, Youling Tang References: <20240430032744.943468-1-youling.tang@linux.dev> Content-Language: en-US, en-AU X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Youling Tang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 30/04/2024 11:29, Kent Overstreet wrote: > On Tue, Apr 30, 2024 at 11:27:44AM +0800, Youling Tang wrote: >> From: Youling Tang >> >> It should be FS_IOC32_GETFLAGS instead of FS_IOC_GETFLAGS in >> compat ioctl. > Do we by chance have a test for this? Just reading the code found this out. > >> Signed-off-by: Youling Tang >> --- >> fs/bcachefs/fs-ioctl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c >> index 3dc8630ff9fe..205a323ffc6d 100644 >> --- a/fs/bcachefs/fs-ioctl.c >> +++ b/fs/bcachefs/fs-ioctl.c >> @@ -548,7 +548,7 @@ long bch2_compat_fs_ioctl(struct file *file, unsigned cmd, unsigned long arg) >> { >> /* These are just misnamed, they actually get/put from/to user an int */ >> switch (cmd) { >> - case FS_IOC_GETFLAGS: >> + case FS_IOC32_GETFLAGS: >> cmd = FS_IOC_GETFLAGS; >> break; >> case FS_IOC32_SETFLAGS: >> -- >> 2.34.1 >>