From: Marc Zyngier <marc.zyngier@arm.com>
To: gengdongjiu <gengdongjiu@huawei.com>,
"christoffer.dall@linaro.org" <christoffer.dall@linaro.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"vladimir.murzin@arm.com" <vladimir.murzin@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: James Morse <James.Morse@arm.com>
Subject: Re: [PATCH] arm64: KVM: VHE: save and restore some PSTATE bits
Date: Wed, 6 Sep 2017 09:17:41 +0100 [thread overview]
Message-ID: <2a5d4299-2523-aef5-7db1-f351ca66b562@arm.com> (raw)
In-Reply-To: <0184EA26B2509940AA629AE1405DD7F2015DF717@DGGEMA503-MBX.china.huawei.com>
On 05/09/17 19:58, gengdongjiu wrote:
> when exit from guest, some host PSTATE bits may be lost, such as
> PSTATE.PAN or PSTATE.UAO. It is because host and hypervisor all run
> in the EL2, host PSTATE value cannot be saved and restored via
> SPSR_EL2. So if guest has changed the PSTATE, host continues with
> a wrong value guest has set.
>
> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
> Signed-off-by: Haibin Zhang <zhanghaibin7@huawei.com>
> ---
> arch/arm64/include/asm/kvm_host.h | 8 +++++++
> arch/arm64/include/asm/kvm_hyp.h | 2 ++
> arch/arm64/include/asm/sysreg.h | 23 +++++++++++++++++++
> arch/arm64/kvm/hyp/entry.S | 2 --
> arch/arm64/kvm/hyp/switch.c | 24 ++++++++++++++++++--
> arch/arm64/kvm/hyp/sysreg-sr.c | 48 ++++++++++++++++++++++++++++++++++++---
> 6 files changed, 100 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index e923b58..cba7d3e 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -193,6 +193,12 @@ struct kvm_cpu_context {
> };
> };
>
> +struct kvm_cpu_host_pstate {
> + u64 daif;
> + u64 uao;
> + u64 pan;
> +};
I love it. This is the most expensive way of saving/restoring a single
32bit value.
More seriously, please see the discussion between James and Christoffer
there[1]. I expect James to address the PAN/UAO states together with the
debug state in the next iteration of his patch.
Thanks,
M.
[1] https://www.spinics.net/lists/arm-kernel/msg599798.html
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2017-09-06 8:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 18:58 gengdongjiu
2017-09-06 5:26 ` gengdongjiu
2017-09-06 8:17 ` Marc Zyngier [this message]
2017-09-06 9:32 ` gengdongjiu
2017-09-06 9:41 ` Vladimir Murzin
2017-09-06 10:35 ` gengdongjiu
2017-09-06 12:00 ` Vladimir Murzin
2017-09-06 12:14 ` gengdongjiu
2017-09-06 12:30 ` Vladimir Murzin
2017-09-06 12:44 ` gengdongjiu
2017-09-06 13:00 ` Vladimir Murzin
2017-09-06 12:32 ` gengdongjiu
2017-09-06 9:49 ` gengdongjiu
2017-09-06 20:49 ` kbuild test robot
2017-09-06 14:10 gengdongjiu
2017-09-06 14:40 ` Vladimir Murzin
[not found] ` <etPan.59b00f79.2fe72a3.4a29@localhost>
2017-09-06 15:19 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a5d4299-2523-aef5-7db1-f351ca66b562@arm.com \
--to=marc.zyngier@arm.com \
--cc=James.Morse@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=gengdongjiu@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®