From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E2CF30E0EE for ; Fri, 28 Nov 2025 13:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764337311; cv=pass; b=Z/RYO3thqBKeqMOil2DJC2TBZqh2M+umYWgjfVEj6oILSp+oI1o0QqgzZg2SI86eZ23QCWzuCvEGjx8F7iCBfg+lU1eEyTSBxA0p1O2Wr2Spbwhe74vpYO882t+glGANb0TFk2/UxzHsA0kOxtrDaNQmhpvo4iuAPZ9WqJrzDic= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764337311; c=relaxed/simple; bh=Bikpb6bipipgwnRno90+ri0PtrliM7CCiEbCWOgJxCk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=pr120G3AtJkA9Nt5otpCwN73+0bLCz/fdIGWXh7FXkGrkiN71Xh0B/RYWi8KKtzZdUOkkH9yLtyuc0iBIulWY16ZRHSc6o8FIQ+DD1hHwyKNA9uA6x++nTKTX+v1dgStIlkfHmWl+pgdFSEVI7oy5ujNKNS3ea6AUbC3y8vLzDw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=gert.wollny@collabora.com header.b=WxSU2IJb; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=gert.wollny@collabora.com header.b="WxSU2IJb" ARC-Seal: i=1; a=rsa-sha256; t=1764337275; cv=none; d=zohomail.com; s=zohoarc; b=Zr1QZ6svF8xCBWptqcB2mRB1y2gUSse+Mt2igqJf9TaxHxNpOqyNToPGaa9rI8sfVqxNcumQ11ojE6CMJl35i33DqZQDAtdhNMUhzEmr7m7du3YRjU4N+Mqeit/nik7pRu07IYFXX7EgX91mNq8CWgO+Ln4MFLIZHWnnsSStBiQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764337275; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Bikpb6bipipgwnRno90+ri0PtrliM7CCiEbCWOgJxCk=; b=O0Fm+JK11bnUPbjLBE9a74Gy4qyZ6sG495Y09pBZ0Wy7DBG0tDiO2EG9Cjt5laJ5XTaTra59iFjyhRjRSjOlMs3RdYQs2wi5m+NcXlBPhkuXIoY9PrE6t/uLjtKP8clXAZy717lBsaD/WsZ/81COPd13+hKW8kDSQBcJAhM40Ok= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=gert.wollny@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1764337275; s=zohomail; d=collabora.com; i=gert.wollny@collabora.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Message-Id:Reply-To; bh=Bikpb6bipipgwnRno90+ri0PtrliM7CCiEbCWOgJxCk=; b=WxSU2IJbk24WU0V3nXUNZw6arnSs6v960sbtAFFjoLkukawQcLzTB/yfeQ7mhdTy cb80UtAcAtZe4VS1AdQ9Z46e8OVilvM90M3/HHYSIezl26dAwvdrMubIZmBNAznNQ0W WVCZlNcerwG/Hy/erKnFTB5N9a2HRVBeynUVEW2o= Received: by mx.zohomail.com with SMTPS id 1764337272921783.0738830021492; Fri, 28 Nov 2025 05:41:12 -0800 (PST) Message-ID: <2a5f5e5c29a8ba03b89e96fb5c2a65a93fb501fa.camel@collabora.com> Subject: Re: [PATCH v5 2/5] drm/etnaviv: move some functions to a header to be able to use them externally From: Gert Wollny To: Christian Gmeiner Cc: Lucas Stach , Russell King , David Airlie , Daniel Vetter , Marek Vasut , etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Fri, 28 Nov 2025 14:39:28 +0100 In-Reply-To: References: <20251110144625.18653-1-gert.wollny@collabora.com> <20251119164624.9297-1-gert.wollny@collabora.com> <20251119164624.9297-3-gert.wollny@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ZohoMailClient: External On Fri, 2025-11-28 at 09:56 +0100, Christian Gmeiner wrote: >=20 > > +#ifndef etnaviv_buffer_h > > +#define etnaviv_buffer_h > > + >=20 > You missed my comment from the previous review. Sorry about that.=20 >=20 >=20 >=20 > In order to save you from doing another round, I will fix the > last nit, if that is okay for you. >=20 Sure, that's fine with me, thanks a lot,=20 Gert=20