From: Hamza Mahfooz <hamza.mahfooz@amd.com>
To: Tom Rix <trix@redhat.com>,
harry.wentland@amd.com, sunpeng.li@amd.com,
Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
daniel@ffwll.ch, Pavle.Kotarac@amd.com, Jun.Lei@amd.com,
nicholas.kazlauskas@amd.com, Charlene.Liu@amd.com,
aurabindo.pillai@amd.com, Dmytro.Laktyushkin@amd.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: set variables dml*_funcs storage-class-specifier to static
Date: Mon, 10 Apr 2023 10:49:12 -0400 [thread overview]
Message-ID: <2a608e8f-823a-7c01-8dc5-ad6c86e5f306@amd.com> (raw)
In-Reply-To: <20230408134348.2703105-1-trix@redhat.com>
On 4/8/23 09:43, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.c:44:24: warning: symbol
> 'dml20_funcs' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.c:51:24: warning: symbol
> 'dml20v2_funcs' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.c:58:24: warning: symbol
> 'dml21_funcs' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.c:65:24: warning: symbol
> 'dml30_funcs' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.c:72:24: warning: symbol
> 'dml31_funcs' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.c:79:24: warning: symbol
> 'dml314_funcs' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.c:86:24: warning: symbol
> 'dml32_funcs' was not declared. Should it be static?
>
> These variables are only used in one file so should be static.
> Cleanup whitespace, use tabs consistently for indents.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied, thanks!
> ---
> .../drm/amd/display/dc/dml/display_mode_lib.c | 24 +++++++++----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_mode_lib.c b/drivers/gpu/drm/amd/display/dc/dml/display_mode_lib.c
> index 4125d3d111d1..bdf3ac6cadd5 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/display_mode_lib.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/display_mode_lib.c
> @@ -41,51 +41,51 @@
> #include "dcn32/display_rq_dlg_calc_32.h"
> #include "dml_logger.h"
>
> -const struct dml_funcs dml20_funcs = {
> +static const struct dml_funcs dml20_funcs = {
> .validate = dml20_ModeSupportAndSystemConfigurationFull,
> .recalculate = dml20_recalculate,
> .rq_dlg_get_dlg_reg = dml20_rq_dlg_get_dlg_reg,
> .rq_dlg_get_rq_reg = dml20_rq_dlg_get_rq_reg
> };
>
> -const struct dml_funcs dml20v2_funcs = {
> +static const struct dml_funcs dml20v2_funcs = {
> .validate = dml20v2_ModeSupportAndSystemConfigurationFull,
> .recalculate = dml20v2_recalculate,
> .rq_dlg_get_dlg_reg = dml20v2_rq_dlg_get_dlg_reg,
> .rq_dlg_get_rq_reg = dml20v2_rq_dlg_get_rq_reg
> };
>
> -const struct dml_funcs dml21_funcs = {
> - .validate = dml21_ModeSupportAndSystemConfigurationFull,
> - .recalculate = dml21_recalculate,
> - .rq_dlg_get_dlg_reg = dml21_rq_dlg_get_dlg_reg,
> - .rq_dlg_get_rq_reg = dml21_rq_dlg_get_rq_reg
> +static const struct dml_funcs dml21_funcs = {
> + .validate = dml21_ModeSupportAndSystemConfigurationFull,
> + .recalculate = dml21_recalculate,
> + .rq_dlg_get_dlg_reg = dml21_rq_dlg_get_dlg_reg,
> + .rq_dlg_get_rq_reg = dml21_rq_dlg_get_rq_reg
> };
>
> -const struct dml_funcs dml30_funcs = {
> +static const struct dml_funcs dml30_funcs = {
> .validate = dml30_ModeSupportAndSystemConfigurationFull,
> .recalculate = dml30_recalculate,
> .rq_dlg_get_dlg_reg = dml30_rq_dlg_get_dlg_reg,
> .rq_dlg_get_rq_reg = dml30_rq_dlg_get_rq_reg
> };
>
> -const struct dml_funcs dml31_funcs = {
> +static const struct dml_funcs dml31_funcs = {
> .validate = dml31_ModeSupportAndSystemConfigurationFull,
> .recalculate = dml31_recalculate,
> .rq_dlg_get_dlg_reg = dml31_rq_dlg_get_dlg_reg,
> .rq_dlg_get_rq_reg = dml31_rq_dlg_get_rq_reg
> };
>
> -const struct dml_funcs dml314_funcs = {
> +static const struct dml_funcs dml314_funcs = {
> .validate = dml314_ModeSupportAndSystemConfigurationFull,
> .recalculate = dml314_recalculate,
> .rq_dlg_get_dlg_reg = dml314_rq_dlg_get_dlg_reg,
> .rq_dlg_get_rq_reg = dml314_rq_dlg_get_rq_reg
> };
>
> -const struct dml_funcs dml32_funcs = {
> +static const struct dml_funcs dml32_funcs = {
> .validate = dml32_ModeSupportAndSystemConfigurationFull,
> - .recalculate = dml32_recalculate,
> + .recalculate = dml32_recalculate,
> .rq_dlg_get_dlg_reg_v2 = dml32_rq_dlg_get_dlg_reg,
> .rq_dlg_get_rq_reg_v2 = dml32_rq_dlg_get_rq_reg
> };
--
Hamza
prev parent reply other threads:[~2023-04-10 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 13:43 Tom Rix
2023-04-10 14:49 ` Hamza Mahfooz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a608e8f-823a-7c01-8dc5-ad6c86e5f306@amd.com \
--to=hamza.mahfooz@amd.com \
--cc=Charlene.Liu@amd.com \
--cc=Dmytro.Laktyushkin@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Pavle.Kotarac@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicholas.kazlauskas@amd.com \
--cc=sunpeng.li@amd.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®