From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501AbeASEWT (ORCPT ); Thu, 18 Jan 2018 23:22:19 -0500 Received: from stargate.chelsio.com ([12.32.117.8]:1303 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753142AbeASEWK (ORCPT ); Thu, 18 Jan 2018 23:22:10 -0500 Subject: Re: linux-next: build warning after merge of the crypto tree To: Stephen Rothwell , Herbert Xu Cc: Linux-Next Mailing List , Linux Kernel Mailing List References: <20180119124926.1c22bb19@canb.auug.org.au> From: Harsh Jain Message-ID: <2a629f26-de6b-803e-a07b-4cfec3b59d13@chelsio.com> Date: Fri, 19 Jan 2018 09:51:43 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180119124926.1c22bb19@canb.auug.org.au> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Herbert, It's an indentation issue. Seems checkpatch and default compile options does not report this warning. How would you like to take the fix. Should I sent whole series again with fix or only indentation patch. On 19-01-2018 07:19, Stephen Rothwell wrote: > Hi Herbert, > > After merging the crypto tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/crypto/chelsio/chcr_algo.c: In function 'create_authenc_wr': > drivers/crypto/chelsio/chcr_algo.c:2113:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] > if (error) > ^~ > drivers/crypto/chelsio/chcr_algo.c:2115:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' > dnents = sg_nents_xlen(req->dst, assoclen, CHCR_DST_SG_SIZE, 0); > ^~~~~~ > > Introduced by commit > > e1a018e607a3 ("crypto: chelsio - Remove dst sg size zero check") >