From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753647AbcKITmq (ORCPT ); Wed, 9 Nov 2016 14:42:46 -0500 Received: from mail-db5eur01on0091.outbound.protection.outlook.com ([104.47.2.91]:15816 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751516AbcKITmo (ORCPT ); Wed, 9 Nov 2016 14:42:44 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH 1/2] stacktrace: fix print_stack_trace printing timestamp twice To: Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , , , , References: <9df5bd889e1b980d84aa41e7010e622005fd0665.1478632698.git.andreyknvl@google.com> CC: From: Andrey Ryabinin Message-ID: <2a6c133d-a42e-34ca-108c-b1399b939d65@virtuozzo.com> Date: Wed, 9 Nov 2016 19:10:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <9df5bd889e1b980d84aa41e7010e622005fd0665.1478632698.git.andreyknvl@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: VI1PR06CA0032.eurprd06.prod.outlook.com (10.162.116.170) To VI1PR0801MB2062.eurprd08.prod.outlook.com (10.173.74.147) X-MS-Office365-Filtering-Correlation-Id: 9cc58cc5-9411-433f-3c46-08d408bae57b X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB2062;2:KCDy+XF9/+feIZWFPB15rtWkjfqPMYdiRoZxnWlEp6sQ9kwsf3T6r+V27X6Hd4db/Z+LyRwXT7ht/31SadIBi/CNA9oQyn+ZsUax8+bcB7k9n45+cGC6CCVDy2Su1n+XAp43WQlA4aY2KO6EuVtjP5Go5QdAK/+JWd+GtnLvJNc22XU2cjPeDBMPLjZmLdKpxElhewNVIOuA/5ZOelbeqA==;3:bayqaICto0zin5P3c0YaXmpOOe0jMBw30k2IxDcHXQv3xomNx0n4wZ9/T6DQrlL5rJuamo5GI5nwP4Xck5rNvNmOcoMLbLBa434aflHYYQ4vccEX9ealQ9FuO/bpFMUfTJH4ZLsQbjUBdSNRMrZl4g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB2062; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB2062;25:u5uREV4l9ZgHWMbWyJZRmYLvUS2x7VKLLVXom/aZgKTnCHVRitaddxvjZk6lQ3I3nay6ksNjdLUc1mhQWeUqkjGQfBmzkZLcrSDf6U8cL3B7p6PlV7KXct/FuUTuL7Mcs2XIlRbQPAdhCKYZiGJWnwJ2gHO4rJyby8FmN+TH/t7+c6srH8VAMXae/pBfxmskP/MPjiSKunHYsuzsVduXY7o9TaTd7lT6xo/ugVAzrEEUDmSPO7uR47LgENSZnnm5M7BI/SqGxWB4Tx1AxRKyDhnZNUbt2MbkPI4cNj1GtoovQpCztrmDqDdZkV5rYrMXSZmFuRwSqWegkqw5wNKnB4xAgNz6T03FpmLA1T7zLPQPm/uGbQQZ/7Ju+eEhBF83BYkdXr+cQT1nQhHbU04otCjakyiIBDqrAF7Wbj0uqmlbsNCmnYT1eYuuuo7NP4jFbQZofSP/YfsLh0sorRwpsSpWu78+BCDkuGwoZ12sb95ekZHY8bhzOnqO40y8pQ+KOPVph0gSmLEhrVa2EopqkvfTJfgLTIz86rq/Jjd9DeZR92XXL2B3SoX1uqvdSylHNyD/4ivo1vjv3/8MdlKQW9AjLXArn0YXSXXTkiLxUmD2Vj0Oj0bUgw8UBXHVoWZWlo09r0mKuPwqO6jkDTL98LxzM9cD4yFeQ3cWERK4rtpHXd0VBisRs89t8ZbkiOzIQGN2saN+p90hQZr/i7mm+0BFi3HPOnrqWOrCHcFI2VU= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB2062;31:taxcNWjkG5x5fqIavJy+zMfEIx3ZUBSwhiGCyiCJc3Qx+G45Zhwm8sz/BMugcDjfHhFOSd0aCRDHxW9YCc21fqdPUOsHqeJBzxUhYT9I3HSlZkkFFfvOQ6i4VjeachGQY3OAndYar9kIt9MrxTnNCnblZM/2ErJbB33StyEqxk/g3Dh6fKk78erssjvbju0d9FSRCDB5tNFDsUAjIJp7UGzbfDkPWw7avMAGkcRswlUZTHiBDjI/QLJjqiVdlO0JDB0eaGHQK2ZqWkJfEjP4/w==;20:y6ljNJdJR/Yc+JyyR06D0TrhFUHh4nxyMTSIdjBYFAX0BdXWTkjcEp1CsxXYw94bNsOYQascs6AQe303nzA+ygmwtZ6raWGD/O9/NPDj5q67HoTEanN4b3ZvmF+Di2NH1pMXZR7WNWom3r/OwUlspUYwkPWTUycjZ/GsjbQfzuM+bbF9mbYvMVEm/Av1V4LhqkHAKwa3riVtaclGjD4trnH125B+jwMr4S5NOllgYHSVCEkfSm0eMJiW7gFSt/1q X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(211936372134217)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6042046)(6043046);SRVR:VI1PR0801MB2062;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB2062; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB2062;4:UgFGGrvvWAOPYlHnSt0VoA6WgaAYk07LhirjCRFpDAUvECOJtWhWaJnCQCg/zwKP6vDJzMfn/0CSN/PPV4Z8rMVH5RxqYj1E4FGHE/FFuQFOAceaXbpaIP3yUFHswMN3hfH1kSMav0qo+mhMCDzK/7rj+AxcsLb/Dyijh1znfkPtTyrHdDcaKEEoMVQL5aq9HaZ65NrY0p3uRioomsP+tzVdsfh0NSC37yWEwNUHUF+HLHBqdkBLmJEDxuSdALu1ApZXXIzXkq9SrfpIKzsNdd4eZJIsTlf4/yG2uYuoHQkRM779x2xfRqWkeYffL+Y9aQqPZ6STRW5dCOajCCVW72+3KjaHIfwTLRTDmpoUh1ABU64eHrO9Ut53SyU2snNMDzXbslsywL+FSu1zjOKjLp/0gPvJHz+5tvGpU8OLm+Z1S3udv1DlmcJZemB0l8/rdckenGOxU51UXkkJ/2rGQ5xLcDRPwTEVGMnOjeh2iGe/zbLjbc1xznu4K6TRJbxg0f5SF2brXY1Hu65nRxEMCL0dE36syabh/to/ADhYS18= X-Forefront-PRVS: 0121F24F22 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(189002)(199003)(24454002)(377454003)(106356001)(81156014)(81166006)(86362001)(50466002)(101416001)(105586002)(31696002)(64126003)(54356999)(8676002)(76176999)(189998001)(42186005)(5001770100001)(3846002)(50986999)(586003)(97736004)(6116002)(31686004)(4001350100001)(68736007)(230700001)(83506001)(77096005)(92566002)(23746002)(36756003)(33646002)(5660300001)(65826007)(2201001)(7736002)(7846002)(47776003)(305945005)(2950100002)(6666003)(4326007)(65806001)(66066001)(2906002)(65956001)(2101003);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0801MB2062;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR0801MB2062;23:Sw8eNkOgEx9fFHADRyw/Hoc8THW7cjW6C7T?= =?Windows-1252?Q?7Ka0SXBCsq0xfCU/YNkqFsV7U0jjLzQiXEMAei9gK5HadXdo5OVNoNgd?= =?Windows-1252?Q?adv3n/RKAyn7IcDZfxpc9AEDq7DsNWP+/w83iEjk4yhGZ+Dpzlsz1AbS?= =?Windows-1252?Q?FQinvUcldR7a5Re7Cy88DMo7oHCYNwKMzDtc/+QsYW7keef/SX3zIWxt?= =?Windows-1252?Q?BbNwXPIEOmqZw6K6JgCDVfF2lhsbqRxnmONoT0U/0KU35Lpe/i9Xt74i?= =?Windows-1252?Q?iQWOT9BP/l4Cow0VpWLU2xdMqDYg4F7HyW4cm7fReIbOiDaXnNfSJBzg?= =?Windows-1252?Q?Wtmg1RwlZnvRA+clkl/91oLIVdU5etxZIYs4/XOlwqBnAkqoV2GNMuQm?= =?Windows-1252?Q?Xv1GIv5ZAbAAk++aaq1pwEKwgZLyxwUXmCeKqOJSlFZiAtdKjvj9kNlp?= =?Windows-1252?Q?RI6A4t0uEsE33hG22kaY99PKsfo6JZNQZnQS2ilv/wM6ZkSGJ5vHHhO9?= =?Windows-1252?Q?qX5A++MpJBPsp0kvflSBnlit+L3IH3mVTVOqRdnZwUiq9Z9aFmLwxeIH?= =?Windows-1252?Q?+PBOO1c/aFddB7kPTQKKMndm2nvWuOLQf0flvA4XIwyiPZGEqJCjGdBW?= =?Windows-1252?Q?diJIX1sC6fuAYDtdVeRiwCRA70NRBiBIoUUepfZTdhBPZCvRzNjaic23?= =?Windows-1252?Q?XgwubVnocIABG8k6TPETJZvd+hwVmYzerJnG1PZBXf5e7s661ij0LPID?= =?Windows-1252?Q?/O5U42ZYq7txXOJrs0rb+keQ1a94Gvsk4QUJLIAL4pOLEOiMWlyVRJjW?= =?Windows-1252?Q?I0BDh2WJ6+Yr1Xadqs/qSl6QMEGBeFx1TnJanIw2gG9Rj37NsZlrRKdy?= =?Windows-1252?Q?IrOPjrAGTpbDfqKtky0/UJUWQ1VPdDqlqAvOD6eA/zTn/a1Tk4Gv+Sgs?= =?Windows-1252?Q?NvFwLW02M82WCIJg1DoqvAhFPNXsvRDq4OKlG1mAuBxWiqafYCQA+Lwh?= =?Windows-1252?Q?VqI4xGYTrdVQafOmHIr1d7TygD7pP95chpQRZ18Gn6rJZmB2yPWKonzu?= =?Windows-1252?Q?9nc+XNGSkCndUF5GtMlhMBdpXcdghZrDWt19zKXJwq3B6zyysGt8pgdl?= =?Windows-1252?Q?YNVQJIQeR+2yj/lp+CntiVnkmztObGFBI+PaZev6zEREGI5FFWgPC+KL?= =?Windows-1252?Q?1WxpiBJ7IfiDJmEYStbSsek2AM5D5TeCo/HdWKxGexU0D0AFDcmufOq+?= =?Windows-1252?Q?NNc8/R+Wl5Of0+cr7k0LGfUrztvNEvXqSLCNexI37K9YjD2XA9UgwH4j?= =?Windows-1252?Q?dswPxP7Ea0YRBL0V03cteEz2g1M5M4wuK89T+lTc6Vn8icnT48WtsoiS?= =?Windows-1252?Q?OMI9Cl/qRCyahEE2z7YRvlt4dNBNXVMweNYoWkpzFXIKm6oBFOwqXNl0?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB2062;6:Con5sQWX+DqehDvUi128rqB+yOVfcBl3pWBdeC6KZb+htU2slSHYicUojR0MbA3G5vdgsGEq/kXFZEzExdEVaCn4fA4zHrYPRfI6FuMKYRzw37iKK8bmq+SQpCsPk1FpumnR92z32MxLr//GM1qSdM/zMA+EW6sUV3b4Ax1JEzvlNGgGF1DeOs5vztfF7fheSPiWK74VNu+b2/svQU47BoEVKoHjDx6dulf75kTA6AkwFs+yrkq6+oaFWN3PAKkAXxy2o/PdFHLqoXoYeEDnvvzEethbiFIEdrhG2gE1H0wgnUA1IJkVLL+p5Pb5HEU3xa6PAj3P+AhirJhZQlekNw==;5:UbMECRtUvYS5+e4eegrnzeVH5NZT6jyAECVr1YpBFdWPqbIkkmCpcp2HpdXDtvzCNrlIudT0D0CJOIbIxq6XNaxwu2ytUo9qDrOyAIr7KUT6SiZ1SFxlxTln9nrLiOPm/07VwqcMjmlxo8bPNLqE/w==;24:ieJy4ZxgANlM62PsqqR4Ut7bQfdgWTLam9pI+AebKCp2uq0XjlnNKXuOIjDajg9GfVmxXKJuCKj52ozWiqD51zrtYUDgJx2KAbbs9o5BOHo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB2062;7:A6AFpeeh0qEPd7j2Rrj4vn1xMlYmk2j1D1XhHvKor8t3MVt8/UGxjDozKiz5QeVUo0KD/Vei1uetxZ4hICcNExKA9NYUjx68dTsm2+tA35Pu6UWZhyAp9COjnI+75PHUoSqBrxpqd6gHxmt2vJgOgtmPenoz1mlytMC44vdnUgyazOxDBHxQ5aYH8nwztDULVlICYAt9d3d50hV5+ctT6qwm1dcKSKRrQqdK470rUE0LSoKxUIBq3A8qHyTRhopnNUjAyFSzaywkN/cJWwr6o4AxP3jq8EmNdrudysiSjU7UlYSCOlK9v6BBdbo40cd2PPc6+5eqB8FORfog9NAl4Tso4WRg1U1K6yJPaAvz5jI=;20:r/IjtLXReh6FT+1hIO7+vGLrsX5TvllhMhdD+gJj5wsAwgI4lGHf25sAdb3InctGUxOrGA9ndPKJvtszAxZJfefrPT2HLpo2doCTjQ6pOt57DUJ4vt9amUgU/6oDggoD7m2jfVG9Uzw1epqkT1RmHXyFGYQJThb4YUGliV+jbqA= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2016 16:10:16.6424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2062 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2016 10:37 PM, Andrey Konovalov wrote: > Right now print_stack_trace prints timestamp twice, the first time > it's done by printk when printing spaces, the second - by print_ip_sym. > As a result, stack traces in KASAN reports have double timestamps: > [ 18.822232] Allocated by task 3838: > [ 18.822232] [ 18.822232] [] save_stack_trace+0x16/0x20 > [ 18.822232] [ 18.822232] [] save_stack+0x46/0xd0 > [ 18.822232] [ 18.822232] [] kasan_kmalloc+0xab/0xe0 > .... > > Fix by calling printk only once. > > Signed-off-by: Andrey Konovalov Right, since commit 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing continuation lines") printk requires KERN_CONT to continue log messages, and print_ip_sym() doesn't have it. After a small nit bellow fixed: Acked-by: Andrey Ryabinin > --- > kernel/stacktrace.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c > index b6e4c16..56f510f 100644 > --- a/kernel/stacktrace.c > +++ b/kernel/stacktrace.c > @@ -14,13 +14,15 @@ > void print_stack_trace(struct stack_trace *trace, int spaces) > { > int i; > + unsigned long ip; This can be inside for loop. > > if (WARN_ON(!trace->entries)) > return; > > for (i = 0; i < trace->nr_entries; i++) { > - printk("%*c", 1 + spaces, ' '); > - print_ip_sym(trace->entries[i]); > + ip = trace->entries[i]; > + printk("%*c[<%p>] %pS\n", 1 + spaces, ' ', > + (void *) ip, (void *) ip); > } > } > EXPORT_SYMBOL_GPL(print_stack_trace); >