From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754431AbaIZIqh (ORCPT ); Fri, 26 Sep 2014 04:46:37 -0400 Received: from mail-bl2on0113.outbound.protection.outlook.com ([65.55.169.113]:15488 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754403AbaIZIqe convert rfc822-to-8bit (ORCPT ); Fri, 26 Sep 2014 04:46:34 -0400 From: "Li.Xiubo@freescale.com" To: Russell King - ARM Linux CC: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs Thread-Topic: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs Thread-Index: AQHP2WYMe4nImp000kGQC07wdbzP8ZwTGc+g Date: Fri, 26 Sep 2014 08:46:31 +0000 Message-ID: <2a7514812fe243649466a41ccf13d424@BY2PR0301MB0613.namprd03.prod.outlook.com> References: <1409546541-4129-1-git-send-email-Li.Xiubo@freescale.com> <9dc024498c904d48b3a25430f8d31f29@BY2PR0301MB0613.namprd03.prod.outlook.com> <20140926082054.GI5182@n2100.arm.linux.org.uk> <20140926084403.GK5182@n2100.arm.linux.org.uk> In-Reply-To: <20140926084403.GK5182@n2100.arm.linux.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [123.151.195.49] x-microsoft-antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0614; x-forefront-prvs: 03468CBA43 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(6029001)(6009001)(24454002)(164054003)(54534003)(51704005)(199003)(189002)(93886004)(85306004)(101416001)(81542003)(76176999)(33646002)(80022003)(81342003)(74662003)(79102003)(77982003)(74502003)(46102003)(66066001)(54356999)(76482002)(110136001)(19580395003)(50986999)(107046002)(19580405001)(85852003)(83072002)(64706001)(108616004)(83322001)(87936001)(2656002)(20776003)(77096002)(120916001)(21056001)(10300001)(106356001)(74316001)(106116001)(31966008)(99396003)(105586002)(97736003)(4396001)(90102001)(92566001)(95666004)(76576001)(86362001)(99286002)(24736002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR0301MB0614;H:BY2PR0301MB0613.namprd03.prod.outlook.com;FPR:;MLV:ovrnspm;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs > > On Fri, Sep 26, 2014 at 08:39:04AM +0000, Li.Xiubo@freescale.com wrote: > > [...] > > > On Fri, Sep 26, 2014 at 05:30:40AM +0000, Li.Xiubo@freescale.com wrote: > > > > Hi Russell, > > > > > > > > I'd like to know the status of this patch. > > > > > > > > Our Platforms depend on it. > > > > > > I'm not applying it. This option should not be exposed for general > > > use. The usage pattern is clear from the existing users - propose > > > an alternative default value for your platform rather than making it > > > a user visible tweakable option. > > > > > > > Okay. > > > > Something like : > > ++++++++++ > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > index 1ad6fb6..5729a2c 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -1802,7 +1802,7 @@ source "mm/Kconfig" > > config FORCE_MAX_ZONEORDER > > int "Maximum zone order" if ARCH_SHMOBILE > > range 11 64 if ARCH_SHMOBILE > > - default "12" if SOC_AM33XX > > + default "12" if SOC_AM33XX || SOC_LS1021A > > default "9" if SA1111 > > default "11" > > help > > ---------- > > > > Is okay ? > > It's much better than exposing the option, but I'd like this patch to > appear as a properly submitted change (including a change log which > provides the reason why this is necessary.) > Okay, I will. Thanks, BRs Xiubo > Thanks. > > -- > FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up > according to speedtest.net.