From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751586AbeBZVQV (ORCPT ); Mon, 26 Feb 2018 16:16:21 -0500 Received: from mga11.intel.com ([192.55.52.93]:39291 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbeBZVQT (ORCPT ); Mon, 26 Feb 2018 16:16:19 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,398,1515484800"; d="scan'208";a="20475463" Subject: Re: [PATCH v12 3/3] mm, x86, powerpc: display pkey in smaps only if arch supports pkeys To: Ram Pai , mpe@ellerman.id.au, mingo@redhat.com, akpm@linux-foundation.org References: <1519257138-23797-1-git-send-email-linuxram@us.ibm.com> <1519257138-23797-4-git-send-email-linuxram@us.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com, corbet@lwn.net, arnd@arndb.de, fweimer@redhat.com, msuchanek@suse.com From: Dave Hansen Message-ID: <2a7737cf-a5ba-c814-fdc7-45b5cdd47376@intel.com> Date: Mon, 26 Feb 2018 13:16:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519257138-23797-4-git-send-email-linuxram@us.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/2018 03:52 PM, Ram Pai wrote: > Currently the architecture specific code is expected to > display the protection keys in smap for a given vma. > This can lead to redundant code and possibly to divergent > formats in which the key gets displayed. > > This patch changes the implementation. It displays the > pkey only if the architecture support pkeys, i.e > arch_pkeys_enabled() returns true. This patch > provides x86 implementation for arch_pkeys_enabled(). > > x86 arch_show_smap() function is not needed anymore. > Deleting it. This looks fine to me. Thanks for doing these, Ram. Reviewed-by: Dave Hansen