From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-clk@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 2/8] clk: si5351: Delete an error message for a failed memory allocation in si5351_i2c_probe()
Date: Thu, 20 Apr 2017 10:23:48 +0200 [thread overview]
Message-ID: <2a7dd521-86bb-09b8-d49d-7518b51094ea@users.sourceforge.net> (raw)
In-Reply-To: <94b24eaa-c5fb-80ea-441a-883989d14ef5@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 20 Apr 2017 07:34:54 +0200
The script "checkpatch.pl" pointed information out like the following.
* CHECK: Comparison to NULL could be written "!drvdata"
Thus adjust this expression.
* WARNING: Possible unnecessary 'out of memory' message
Thus remove such a statement here.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/clk/clk-si5351.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
index a4c009e1e70d..2492442eea77 100644
--- a/drivers/clk/clk-si5351.c
+++ b/drivers/clk/clk-si5351.c
@@ -1354,10 +1354,8 @@ static int si5351_i2c_probe(struct i2c_client *client,
return -EINVAL;
drvdata = devm_kzalloc(&client->dev, sizeof(*drvdata), GFP_KERNEL);
- if (drvdata == NULL) {
- dev_err(&client->dev, "unable to allocate driver data\n");
+ if (!drvdata)
return -ENOMEM;
- }
i2c_set_clientdata(client, drvdata);
drvdata->client = client;
--
2.12.2
next prev parent reply other threads:[~2017-04-20 8:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 8:20 [PATCH 0/8] clk: Fine-tuning for ten function implementations SF Markus Elfring
2017-04-20 8:22 ` [PATCH 1/8] clk: si5351: Use devm_kcalloc() in si5351_i2c_probe() SF Markus Elfring
2017-04-22 2:44 ` Stephen Boyd
2017-04-20 8:23 ` SF Markus Elfring [this message]
2017-04-22 2:45 ` [PATCH 2/8] clk: si5351: Delete an error message for a failed memory allocation " Stephen Boyd
2017-04-20 8:26 ` [PATCH 3/8] clk: si5351: Adjust a null pointer check in si5351_dt_parse() SF Markus Elfring
2017-04-20 8:27 ` [PATCH 4/8] clk: Replace four seq_printf() calls by seq_putc() SF Markus Elfring
2017-04-22 2:46 ` Stephen Boyd
2017-04-20 8:28 ` [PATCH 5/8] clk: Combine two seq_puts() calls into one call in clk_summary_show() SF Markus Elfring
2017-04-20 8:29 ` [PATCH 6/8] clk: Improve a size determination in two functions SF Markus Elfring
2017-04-22 2:47 ` Stephen Boyd
2017-04-20 8:30 ` [PATCH 7/8] clk: nomadik: Use seq_puts() in nomadik_src_clk_show() SF Markus Elfring
2017-04-22 2:48 ` Stephen Boyd
2017-04-20 8:32 ` [PATCH 8/8] clk: nomadik: Delete error messages for a failed memory allocation in two functions SF Markus Elfring
2017-04-22 2:48 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a7dd521-86bb-09b8-d49d-7518b51094ea@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome