From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494AbdHLHkA (ORCPT ); Sat, 12 Aug 2017 03:40:00 -0400 Received: from mail.bugwerft.de ([46.23.86.59]:41822 "EHLO mail.bugwerft.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbdHLHj5 (ORCPT ); Sat, 12 Aug 2017 03:39:57 -0400 X-Greylist: delayed 565 seconds by postgrey-1.27 at vger.kernel.org; Sat, 12 Aug 2017 03:39:57 EDT Subject: Re: [PATCH] ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation in alloc_urbs() To: SF Markus Elfring , alsa-devel@alsa-project.org, Daniel Mack , Jaroslav Kysela , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: <8cb2a553-e247-f432-48ef-1a7438416366@users.sourceforge.net> From: Daniel Mack Message-ID: <2a7e484c-260f-b3d5-ea24-7fa22004e705@zonque.org> Date: Sat, 12 Aug 2017 09:30:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <8cb2a553-e247-f432-48ef-1a7438416366@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/2017 08:00 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 11 Aug 2017 19:39:06 +0200 > > Omit extra messages for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Daniel Mack > --- > sound/usb/caiaq/audio.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c > index 8f66ba730d69..1f306155e76a 100644 > --- a/sound/usb/caiaq/audio.c > +++ b/sound/usb/caiaq/audio.c > @@ -731,7 +731,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret) > > urbs = kmalloc(N_URBS * sizeof(*urbs), GFP_KERNEL); > if (!urbs) { > - dev_err(dev, "unable to kmalloc() urbs, OOM!?\n"); > *ret = -ENOMEM; > return NULL; > } > @@ -746,7 +745,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret) > urbs[i]->transfer_buffer = > kmalloc(FRAMES_PER_URB * BYTES_PER_FRAME, GFP_KERNEL); > if (!urbs[i]->transfer_buffer) { > - dev_err(dev, "unable to kmalloc() transfer buffer, OOM!?\n"); > *ret = -ENOMEM; > return urbs; > } >