From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD29F155757 for ; Mon, 22 Dec 2025 04:10:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766376643; cv=none; b=SCGSBOAfsq/H3gzwGpGs1XSkuN3djZriyQt4DBQKsx8gTE021MOhvWPAFovBz93fpf3ylPQBRySEiezENX7yf6Vk67SROMsMWGFOWMbx9MrkRFFCqm/V61mmbFUybowUyrPGlDiOIxfUYTiZKRn6NS6ALNf9S+blpmXZ72Wb89I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766376643; c=relaxed/simple; bh=W1YngHDZW6ZsrPDb1xICeavqh4kQtMhzCXHEcTXEBFk=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=fVQLaZPCwvOcE3NLBpM1E27/A0sbJNdBZnHE//0VsOsrqxuAvSQYc7BIv8krbqBRNBAGedAm7S9xPeED9I9gTqYhjbWMB94Ehue55Vtn7dhJ5tMBm8qHobHd9POBX/8XcmzfEAN59QmDJhI6q1iRU8LmbUn+TK2fbSUa5J4Llq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZYr0o+Kg; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KQjAxiJd; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZYr0o+Kg"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KQjAxiJd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766376640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xMvOngQqHzrYql0DGxebGC7k/0y7G5dyTDe26P3fh3I=; b=ZYr0o+KgOvbRMMEr7VQvRc3TswZ982IGFe2zJkNeGh5QygJhEizQnCI/+y558rZzhnMQ8s DvGY8HmBeqkPZOy9XjSsk9ZhqtsXnUwlcC5leFqQDnqYjMQInBY3ENvpnpK79XwF2PRKCX mUu/qHQ5SqHgYzH/pw2BtM3wb7dphIM= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-WYlOEM1EN8KbKAlU06Mdrg-1; Sun, 21 Dec 2025 23:10:39 -0500 X-MC-Unique: WYlOEM1EN8KbKAlU06Mdrg-1 X-Mimecast-MFC-AGG-ID: WYlOEM1EN8KbKAlU06Mdrg_1766376639 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b2217a9c60so1408398785a.3 for ; Sun, 21 Dec 2025 20:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766376639; x=1766981439; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=xMvOngQqHzrYql0DGxebGC7k/0y7G5dyTDe26P3fh3I=; b=KQjAxiJdp2dsjfEDlOnkxUfIzl/EAikpmSlfW+E0oktK1uvZk7IJwZopOHncoETzER uNi3HmHLiDcnwLip83eG0+ELu+iAilMtDNWgsJaB13JM/e+zdap88iHLV1Xc8YA+J8/F eOIpR+lJNsLH4q3EjqN94qMu6eKZMU+10nRO5KrrAaaWtXtGMirb6DczjzqvF9TNumSW f6D6+FgbTk7JCbWdOeqVG7j0ElzeD1zOksuzVImH6RiPN1+D09fOGyY8K3IkFwEjTFbg 3QKIVg6WL2KMJQz0ZDCsO/NsdBTHmrgr4p80OqGaQkSq9MauGI0sdLXnTVon8TADi4cN esWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766376639; x=1766981439; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xMvOngQqHzrYql0DGxebGC7k/0y7G5dyTDe26P3fh3I=; b=cm/vxZEk91toRWiXj24XqfMTR/7eNy3zEOUB6ufGDlm+pgWJLMMRkwVwhxaEPfXi/R BZaRohHucdu9jphw9l863a8MRrJ3Y2EjD1vTw4SbRtJtG7aCQ9tqxKgU7aIarbbfdzEt sdsHUL5ZGdKf8+GKfa//HOtAWrPu8/pwI+syZLzt4R42YSu95DO7GpPteCq0vsMghsTb zIm7VIAAJwMNMJLEXuSyiWYD9Y96uLRECRESZotrjP3tMAAHNDnM5mVMc5DE8DrxVWfV RnNKNqqeBTPInTTcVgd7FXIfA6/rW66EefXRtRgZ7iAktupsDSbAwxa3lzRfZw3I0ZWj nTtg== X-Forwarded-Encrypted: i=1; AJvYcCUzS0IZdb4zIWdRRNMzYdnZa1a4LKTzX7DhwuSZ+QWYq1HJcm5jYHvo8/W0srzLTqXQeTB7+iGga//1W1I=@vger.kernel.org X-Gm-Message-State: AOJu0YzY4W+KQnsEQpE52+jV1RqaHAXsoE65JhQLV38waIq73cS8wQul IDkMIYv72hBzNpogfz1ZIC2L58IuTe0ICpRpedNfwUI6bJRmOBWZDI1IHldA5+hdzUWjFxMFxjY ERFN9ULaJm4a+OjCwH9RQdZZZ4Bn9P/fjnHngOhuaq0nTYo3f9KuKBB3co6NlTzsFoQ== X-Gm-Gg: AY/fxX6q9+/MuTxobxqlDyBqkjGfVnRHZuT8+XljzaJnP2YdpOGk9dLIIqO5iHZ793Z DLZBv0LY95PdQKVPUbvs69bZbtGtDYT14HQg7Idu2mLPyvlvhwLxirvgVQEvPwskYoMMe+nj9tT G4p8ZKt8+5si9ZPMerE/0n5fEVxphjI6FR2LIJEZCgELGDEANEcdkRnQRgTlvh4GHHvmJprJ7MP xoX1pZjMt0qZx98vvGWEJjm0hmXwcc7xZ5Pn3BzDk3mL46OENm8Wpm2t+vx1xEh1OzditFyhVuQ JTICpUAOCgQhg1H++0aaz5KQp+6q/PsXLSRw0oWsvjTCPuqi3bwbY27SIuJfZ6k2rpIqw28y4XC HIaoh6w1LcZ2dLqHe7Mmc9y8XPvh4EsBf2rQLXVkRGTrlmkncBPS7re7e X-Received: by 2002:a05:620a:40cb:b0:893:2ba8:eec8 with SMTP id af79cd13be357-8c08fd18594mr1455033485a.79.1766376638802; Sun, 21 Dec 2025 20:10:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IGg/CJEkPRRiX/W3BHMoXPl6BjC3jHwswQHYqzmLL+jCYavItFC9JE51/njF1CIPKDUgxa9CQ== X-Received: by 2002:a05:620a:40cb:b0:893:2ba8:eec8 with SMTP id af79cd13be357-8c08fd18594mr1455032485a.79.1766376638461; Sun, 21 Dec 2025 20:10:38 -0800 (PST) Received: from ?IPV6:2601:600:947f:f020:85dc:d2b2:c5ee:e3c4? ([2601:600:947f:f020:85dc:d2b2:c5ee:e3c4]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c0968913ccsm760352185a.16.2025.12.21.20.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Dec 2025 20:10:38 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <2a829c98-9e6e-4c99-85c1-110a776db43e@redhat.com> Date: Sun, 21 Dec 2025 23:10:36 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [patch -next] cpuset: remove dead code in cpuset-v1.c To: Chen Ridong , tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, chenridong@huawei.com Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, lujialin4@huawei.com, dan.carpenter@linaro.org References: <20251220101557.2719064-1-chenridong@huaweicloud.com> Content-Language: en-US In-Reply-To: <20251220101557.2719064-1-chenridong@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/20/25 5:15 AM, Chen Ridong wrote: > From: Chen Ridong > > The commit 6e1d31ce495c ("cpuset: separate generate_sched_domains for v1 > and v2") introduced dead code that was originally added for cpuset-v2 > partition domain generation. Remove the redundant root_load_balance check. > > Fixes: 6e1d31ce495c ("cpuset: separate generate_sched_domains for v1 and v2") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/cgroups/9a442808-ed53-4657-988b-882cc0014c0d@huaweicloud.com/T/ > Signed-off-by: Chen Ridong > --- > kernel/cgroup/cpuset-v1.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c > index 7303315fdba7..ecfea7800f0d 100644 > --- a/kernel/cgroup/cpuset-v1.c > +++ b/kernel/cgroup/cpuset-v1.c > @@ -605,7 +605,6 @@ int cpuset1_generate_sched_domains(cpumask_var_t **domains, > int ndoms = 0; /* number of sched domains in result */ > int nslot; /* next empty doms[] struct cpumask slot */ > struct cgroup_subsys_state *pos_css; > - bool root_load_balance = is_sched_load_balance(&top_cpuset); > int nslot_update; > > lockdep_assert_cpuset_lock_held(); > @@ -615,7 +614,7 @@ int cpuset1_generate_sched_domains(cpumask_var_t **domains, > csa = NULL; > > /* Special case for the 99% of systems with one, full, sched domain */ > - if (root_load_balance) { > + if (is_sched_load_balance(&top_cpuset)) { > ndoms = 1; > doms = alloc_sched_domains(ndoms); > if (!doms) > @@ -638,8 +637,6 @@ int cpuset1_generate_sched_domains(cpumask_var_t **domains, > csn = 0; > > rcu_read_lock(); > - if (root_load_balance) > - csa[csn++] = &top_cpuset; > cpuset_for_each_descendant_pre(cp, pos_css, &top_cpuset) { > if (cp == &top_cpuset) > continue; Reviewed-by: Waiman Long