From: "H. Peter Anvin" <hpa@zytor.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, Vineet.Gupta1@synopsys.com,
linux-kernel@vger.kernel.org,
James Hogan <james.hogan@imgtec.com>
Subject: Re: new architectures, time_t __kernel_long_t
Date: Thu, 20 Dec 2012 21:47:45 -0800 [thread overview]
Message-ID: <2a8cf990-8197-4a8f-854f-14b8fb65e9c2@email.android.com> (raw)
In-Reply-To: <20121221051921.GQ4939@ZenIV.linux.org.uk>
Fair enough.
Al Viro <viro@ZenIV.linux.org.uk> wrote:
>On Thu, Dec 20, 2012 at 09:05:30PM -0800, H. Peter Anvin wrote:
>> >... as long as we do not have typedef __kernel_foo_t foo_t in
>linux/types.h.
>> >
>>
>> In the case of things like nlink_t and dev_t I would suggest we
>> explicitly call out the types as kernel and user. I would suggest
>> knlink_t and unlink_t but the latter made me want to stab my eyes
>> out due to its confusion potential, so I wonder if we should
>> establish a new convention with _kt (kernel type) and _ut (user
>> type) suffixes, so nlink_kt and nlink_ut, alternatively one could
>> consider k_nlink_t and u_nlink_t.
>
>What the hell for? _Which_ userland nlink_t, anyway? We have quite a
>few
>struct stat variants in there. Sorry, but I really don't see any point
>in that, and a lot of potential for confusion. Marshalling is about
>the
>only thing we need the userland ones for and the code doing it is just
>fine
>with the only object of that type in sight being the field of e.g.
>struct stat
>with given name...
--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
prev parent reply other threads:[~2012-12-21 5:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 12:18 Arnd Bergmann
2012-11-14 12:48 ` Geert Uytterhoeven
2012-11-14 16:26 ` H. Peter Anvin
2012-11-15 9:14 ` Arnd Bergmann
2012-11-15 13:59 ` H.J. Lu
2012-11-15 14:36 ` Arnd Bergmann
2012-11-15 14:42 ` H.J. Lu
2012-11-15 15:10 ` H. Peter Anvin
2012-12-21 4:57 ` Al Viro
2012-12-21 5:00 ` H. Peter Anvin
2012-12-21 5:02 ` Al Viro
2012-12-21 5:05 ` H. Peter Anvin
2012-12-21 5:19 ` Al Viro
2012-12-21 5:47 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a8cf990-8197-4a8f-854f-14b8fb65e9c2@email.android.com \
--to=hpa@zytor.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=arnd@arndb.de \
--cc=james.hogan@imgtec.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®