Re: [PATCH v4 0/2] Add the NXP S32 Watchdog

[Guenter Roeck <linux@roeck-us.net>]

On 5/14/25 08:30, Daniel Lezcano wrote:
> On 4/10/25 10:26, Daniel Lezcano wrote:
>> The NXP S32 watchdog, referenced in the documentation as the Software
>> Watchdog Timer is actually a hardware watchdog. The system has one
>> watchdog per core but an assertation does not directly reset the
>> system as this behavior relies on a particular setup and another
>> component which is not part of these changes. However the first
>> watchdog on the system, tied with the Cortex-M4 #0 is a particular
>> case where it will reset the system directly. This is enough for the
>> watchdog purpose on Linux.
>>
>> The watchdog relies on the default timeout described in the device
>> tree but if another timeout is needed at boot time, it can be changed
>> with the module parameter.
>>
>> If the kernel has to service the watchdog in place of the userspace,
>> it can specify the 'early-enable' option at boot time.
>>
>> And finally, if starting the watchdog has no wayback then the option
>> 'nowayout' can be also specified in the boot option.
>>
>> Changelog:
>>
>>   - v4:
>>      - Update the watchdog timeout when the callback is called (Alexandru-Catalin Ionita)
>>      - Fix the clocks bindings to have all the clocks described (Krzysztof Kozlowski)
>>
>>   - v3:
>>      - Add the clocks for the module and the register (Ghennadi Procopciuc)
>>      - Use the clock name from the driver
>>      - Removed Review-by tag from Krzysztof Kozlowski as the bindings changed
>>
>>   - v2:
>>      - Removed debugfs code as considered pointless for a such simple
>>        driver (Arnd Bergmann)
>>      - Replaced __raw_readl / __raw_writel by readl and writel (Arnd Bergmann)
>>      - Reordered alphabetically the headers (Guenter Roeck)
>>      - Enclosed macro parameter into parenthesis (Guenter Roeck)
>>      - Fixed checkpatch reported errors (Guenter Roeck)
>>      - Clarified a ping on a stopped timer does not affect it (Guenter Roeck)
>>      - Used wdt_is_running() to save an extra IO (Guenter Roeck)
>>      - Fixed a misleading comment about starting the watchdog at boot time (Guenter Roeck)
>>      - Replaced allocation size sizeof(struct ...) by sizeof(*var) (Krzysztof Kozlowski)
>>      - Drop old way of describing the module and use table module device (Krzysztof Kozlowski)
>>      - Replaced additionalProperties by unevaluatedProperties (Rob Herring)
>>      - Removed the DT bindings description as it is obvious (Ghennadi Procopciuc)
>>      - Fixed DT bindings compatible string (Krzysztof Kozlowski)
>>
>>   - v1: initial posting
>>
>> Daniel Lezcano (2):
>>    dt-bindings: watchdog: Add NXP Software Watchdog Timer
>>    watchdog: Add the Watchdog Timer for the NXP S32 platform
>>
>>   .../bindings/watchdog/nxp,s32g2-swt.yaml      |  54 +++
>>   drivers/watchdog/Kconfig                      |   9 +
>>   drivers/watchdog/Makefile                     |   1 +
>>   drivers/watchdog/s32g_wdt.c                   | 315 ++++++++++++++++++
>>   4 files changed, 379 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/watchdog/nxp,s32g2-swt.yaml
>>   create mode 100644 drivers/watchdog/s32g_wdt.c
> 
> Hi,
> 
> Gentle ping, we are close to the merge window.
> 

AFAICS the patches do have Reviewed-by: tags, so this is just waiting for Wim
to pick it up.

Guenter