From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BACE7849A for ; Mon, 2 Oct 2023 10:06:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236335AbjJBKGL (ORCPT ); Mon, 2 Oct 2023 06:06:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231153AbjJBKGI (ORCPT ); Mon, 2 Oct 2023 06:06:08 -0400 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [IPv6:2001:67c:2050:0:465::101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25E729F for ; Mon, 2 Oct 2023 03:06:05 -0700 (PDT) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Rzc6K39JBz9sjZ; Mon, 2 Oct 2023 12:06:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1696241161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ox+gKi4bLoFPXXWfih5IxNiXLO7vrIVUXFkXDUiuxVY=; b=fi/SNZ9m3ulp2WS5NGQcISs+kt16+SCQ41dzctwiKAN0rwzeBYUdvE6oG3krUmOQGl2cEA aIBopFdrHvt0EcdxSUPh8eYtC1In2mIv1gt4Wv+PxE5f551K3HyGGUWeILNSPN5IxxboWe 6AetKPbjFjAxOt0eUoQlOUyInYlfHFcajDZBY/U/cXgkIGeYGnPDb2fu+IVLPpRWPgepwX YjZc2wb79odiNPw/P7FGqZRPZPgVyzJ984IFY04V0reH38gSPuI5tFBXV5XyRta4nl4qzU 7b9MCufos20Gawf4URqKIGMSCCbeGq8IC2NOQN6Aiwcm8cQMkYV40lHzPUZHjg== Message-ID: <2a8ebf1a-0d74-e068-6d68-de0ecae9bdf1@mailbox.org> Date: Mon, 2 Oct 2023 12:05:56 +0200 MIME-Version: 1.0 Subject: Re: [PATCH] Revert "drm/amd/display: Check all enabled planes in dm_check_crtc_cursor" Content-Language: en-CA To: Hamza Mahfooz Cc: Stylon Wang , Ivan Lipski , Leo Li , David Airlie , Qingqing Zhuo , "Pan, Xinhui" , Rodrigo Siqueira , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Hung , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Aurabindo Pillai , Hersen Wu , Daniel Vetter , Wayne Lin , Alex Deucher , Srinivasan Shanmugam , Harry Wentland , =?UTF-8?Q?Christian_K=c3=b6nig?= , amd-gfx@lists.freedesktop.org References: <20230929204120.120795-1-hamza.mahfooz@amd.com> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= In-Reply-To: <20230929204120.120795-1-hamza.mahfooz@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-MBO-RS-ID: bb25a72978e7ad443ec X-MBO-RS-META: jxzcx4axa4semwfmgchknxjnby4h5b5c Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/29/23 22:41, Hamza Mahfooz wrote: > From: Ivan Lipski > > This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be. > > Since, it causes the following IGT tests to fail: > kms_cursor_legacy@cursor-vs-flip.* > kms_cursor_legacy@flip-vs-cursor.* Any information about how those tests fail? Maybe they accidentally rely on the broken behaviour? FWIW, something like the reverted commit is definitely needed, see https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3177#note_1829068 . That MR is blocked by the reverted fix. -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and Xwayland developer