From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794997595; b=uLeV1kQfJTpmsSlTusf4wszyaTmemDemrTrwIyyxLXzS1oj/itNuPBcrQUBwGoHBWMU7 MZWZB9ZmzYUqc+c9/PXNIsaR4DTCzGnErMFC4CvN3BShzsyhZqpB22fbJ9fiIPluybitx 1b7mdDlHTcCaA9nRtBhDahC2wpTm1rDLrhJ3ZE0cO/OoB+7YpI5uj7UTm5pvyPZSqckkB IKFGW+3d/kNrKaSTCq+WPAQCSAAR08dG45c4SCidV+qyx25WE/WhbhKmvahaYdRH4Llvg FSDqwM+Q1ByjwgwHilM1AyhuHMMwwbxF4d2kvej85UyMR1KwCCJjaGOCWY2rQhflY8A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794997595; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=Jv+UoiRybidtTIhCZ8L+Fb7Gei05WnQLxDeqowwvbS8=; b=EKsV/d57/CyG1KCn6LgYbyaI5SBbL1DvDnAj04XCbk0EO2gcQ0/NfYdUnxWzAiABH72+ OZB7LUVm28kdnMFpmkNQdYG/Ghjs+cYiyJG6xlzaHzuuvpG8DaRanY7LwI+zIV/6vuCZf zuoNTwCKH+NG1zKfCRrPawNYk/JjjOWhFla7MUZ4kJReDKLp02M8+/Ulxbc4gPxhOo6/s c1nFmB/YGCnjqSO2L+179YREPPI0GOxmtjbea0YJ3RUCpNEqmfrN8ST2XBewcTRhhe+FX NKQHM7mlL+ZzYo4c5Vtmfw7ct/DfodwnHwqlqM7B73vj5YcVeMwSO8raALvTWy0Eiug== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="Mn/Zrkoe"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8ABF606A320; Wed, 18 Nov 2026 10:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Mn/Zrkoe Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34F081F000C4; Wed, 18 Nov 2026 10:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794997595; bh=Jv+UoiRybidtTIhCZ8L+Fb7Gei05WnQLxDeqowwvbS8=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Mn/ZrkoeJpF3VOgN9NmX674NzjrCwfHej4ZSjjnQKiZpmPIyPbfSs88/SnoppoYLs GmBtZCwkgjsEz8qMGAychmwikeKOSi5c9EFG6T1ccT2Dr2A00Ta9JpqnxIjqHxBI1z 7bvNlTP1WYOgLtdPhTzbxe/vIqZV9mfZMlFo225JmdJgZjAGFNiWLwprcz2YNfgIFE fQfnSetp8p5Z7O7tQdBWqzTq55DQjx4bYv/DFPdpF5WlY4EVNUKJKco6myEgaQnQQE At6dCGjKUCtNg6Nq5joEknVeMwYJimRcd67A+ILvQgl0BGF8TXPWazanqdm3B9nPJa QrDnzXrHJrubg== Message-ID: <2a93c7e3-be5f-4315-80fc-fa05bd260d6c@kernel.org> Date: Wed, 18 Nov 2026 11:26:30 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: shmem: limit forced anonymous shmem huge orders to MAX_PAGECACHE_ORDER To: Jingyi Sun <1045704958@qq.com>, Hugh Dickins , Andrew Morton Cc: Baolin Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Luiz Capitulino References: From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/18/26 11:22, Jingyi Sun wrote: > When the top-level shmem_enabled knob is set to "force", > shmem_allowable_huge_orders() returns huge_shmem_orders_inherit for > anonymous shmem without masking it with THP_ORDERS_ALL_FILE_DEFAULT, > unlike the other return path at the end of the same function. > > huge_shmem_orders_inherit defaults to BIT(HPAGE_PMD_ORDER). On arm64 > with 64K base pages HPAGE_PMD_ORDER is 13, while MAX_PAGECACHE_ORDER > is 11 because of the xarray split limit. With shmem_enabled=force, an > anonymous MAP_SHARED mapping can therefore get a 512M (order-13) folio > in the page cache. Splitting it later, e.g. on swap-out from > shmem_writeout(), triggers > > WARNING: lib/xarray.c:1051 at xas_split_alloc > > and the split fails, so the folio can never be swapped out. > > This is the same problem that commit 9fd154ba926b ("mm/shmem: disable > PMD-sized page cache if needed") and commit b66b1b71d7ff ("mm: shmem: > avoid allocating huge pages larger than MAX_PAGECACHE_ORDER for shmem") > fixed for the other paths; the force branch was left out. Mask it with > THP_ORDERS_ALL_FILE_DEFAULT as well. > > Reproduced on v7.3-rc2 in QEMU (arm64, 64K pages, -cpu cortex-a72, > 4G RAM, zram swap): with shmem_enabled=force, a PMD-aligned > MAP_SHARED|MAP_ANONYMOUS mapping of one PMD size got a single > PMD-mapped folio (ShmemPmdMapped: 524288 kB) and MADV_PAGEOUT > triggered the warning above in 3/3 runs. With this change: 0/3. > shmem_enabled=always and 4K pages did not show the warning. The code is > unchanged in v7.4-rc3 and in mm-unstable, but the test has not been > re-run on those trees. > > The issue was found with a research static analyzer for > cross-architecture dependency bugs and confirmed with the QEMU > reproducer described above. > > Fixes: e7a2ab7b3bb5 ("mm: shmem: add mTHP support for anonymous shmem") > Cc: stable@vger.kernel.org > Cc: Luiz Capitulino > Reviewed-by: Baolin Wang > Signed-off-by: Jingyi Sun <1045704958@qq.com> > --- Reviewed-by: David Hildenbrand (Arm) I'll queue this later. -- Cheers, David