From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42085CDB482 for ; Tue, 17 Oct 2023 15:47:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235059AbjJQPrB (ORCPT ); Tue, 17 Oct 2023 11:47:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235133AbjJQPqu (ORCPT ); Tue, 17 Oct 2023 11:46:50 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E592F13E for ; Tue, 17 Oct 2023 08:46:48 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7a66555061eso4346939f.0 for ; Tue, 17 Oct 2023 08:46:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1697557608; x=1698162408; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qifLUWrkmypuE1HSNNdyFzpD4fELvix1NB9KRDxZL6k=; b=K2yfEisqlKZqRVCJlCswRZR7ZE34IYOmxwd2QVY71uccQEJomx59oVxDDvMC57KEQb aN2noaz0bVQEOiLrXr2PAbCwSlqoPOpu7jxnXmuNEQfbSZ1lJf+sh1A7B7vMrM6TT0iN voMHn4nQw5YpOrun58BVrnQ24SmYg3aymmboE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697557608; x=1698162408; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qifLUWrkmypuE1HSNNdyFzpD4fELvix1NB9KRDxZL6k=; b=K95ccu5g/PcURwWCa9g763prdN7MhbgGJ01ls2zwL/Ps41ga6tfLta7tncdokadH0f aAbB5h36ReeT9CubngScGA3xntot8Mrc7uDHMB6CBARUK4C7+lUFTChduNKgERbvv+2f ldVNmvp3N7XhysuRqsWWFG8liHWTNE8HzmrkKAP5dTNWfxhTtuZybJ8s2OS/NnW0ayDM 61JDPqSz7HhE+p3FQT4y7FZmmRszAV9slrsaeE/WMJu/JYBr0EjhdMZtVLKaZCS2eCT4 nw/HQP7V2xPi9SS3LH+7Lk+HNH2+HKi+vS2MiaT/isJJ37PQE6CQHiz33G1fGpaW4B6N ypJg== X-Gm-Message-State: AOJu0YxaJF+78EDT+9z82ifGIZeo0KtmdetQ1+hNkNqefXYihTNOiHVL hTP3wBrCaKAUsKKra9tkMPoUlQ== X-Google-Smtp-Source: AGHT+IHgKOfjvzKSAB0scid4I1mm3aq4oFWhBwPqa9mWSsIQTAzX4p9v9j6dSadUHlBM2ou8xWXtnw== X-Received: by 2002:a05:6602:1513:b0:79f:a8c2:290d with SMTP id g19-20020a056602151300b0079fa8c2290dmr3348129iow.0.1697557608211; Tue, 17 Oct 2023 08:46:48 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id x22-20020a056638249600b0042acf389acesm556725jat.71.2023.10.17.08.46.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 08:46:47 -0700 (PDT) Message-ID: <2a96e3a8-48a5-46ae-9a0c-b5f2def0a257@linuxfoundation.org> Date: Tue, 17 Oct 2023 09:46:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/efivarfs: create-read: fix a resource leak Content-Language: en-US To: zhujun2 , shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20231017023335.7874-1-zhujun2@cmss.chinamobile.com> From: Shuah Khan In-Reply-To: <20231017023335.7874-1-zhujun2@cmss.chinamobile.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/23 20:33, zhujun2 wrote: > The opened file should be closed in main(), otherwise resource > leak will occur > Did you find this by code reading or by any other means. Please add how you found the problem to the change log. > Signed-off-by: zhujun2 > --- > tools/testing/selftests/efivarfs/create-read.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c > index 9674a1939..6812104a5 100644 > --- a/tools/testing/selftests/efivarfs/create-read.c > +++ b/tools/testing/selftests/efivarfs/create-read.c > @@ -32,8 +32,11 @@ int main(int argc, char **argv) > rc = read(fd, buf, sizeof(buf)); > if (rc != 0) { > fprintf(stderr, "Reading a new var should return EOF\n"); > + close(fd); > return EXIT_FAILURE; > } > > + close(fd); > + No need for this extra line here. > return EXIT_SUCCESS; > } thanks, -- Shuah