From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792745490; b=xVhKXGSa7ZR/6C8PIhkOug5J9kjzrmEE3cARKjJNcrIMXl/Y9gJ6Rn4dg1e8UEF5Oxgo CebrPOj92BeqxaQ+jYDIPtmDEUiBH0RVGr/ugvXB3kZ1doApawjmhwsoA9SjfQgm0xfU9 0Zl7uEfRQuL+yb5bru309Rs999KHFkAdfsyi5INv36vxgymGCxUiTrp2cH6dWBke1e01+ q0WrRdt0fy+i5CvhP47JWMW0k/maLUYWQfwRc+rs3XDbwDyUWWfll2/lbk4Q37u+Ovg3q IFiLYiC5BxnDAR1XUsy32yTSlP9Ws+iKEuQvAH0/khy4rxQRmHa8fciV3YFr3mnQixA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792745490; h=DMARC-Filter:Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:Autocrypt: In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Spam-Flag: X-Spam-Level:X-Spamd-Result:X-Spam-Score; bh=O8hx2K3MguPb+IPLbG/1EkjyoxvdTxrh8Upow7TUDnI=; b=tXFB4qEbqSXZt77eO+IewpDciUZP5qZ686cJq6M8g9TiDLWfAxsRsiMmfgOoobcFBeBd mPsl7TpTJT4yDWXvrWjMbaNVvF1b+86+Ptwtp7phxvuN5YVidBWzs54U4OX/TwK6ABDsu mAd92cN+B5MQzT8WAnGd53j/nf3RX2XMwPJe5K6jQDdpg0W+uaKTrHzaR0naW0WlwojhP yMInpcjE+RogBXq5IuTKzAmFgt4MKmivvtINfMME5wnGTcSBbBH5uJ9XQ+diHwZ4S1TtR /qQflPhNVDLZQGc2X1qg0XFXMUoYolM9TeS9GOQoRS7mQPijb8ILxqfD4fo0XRwaadA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Ncb6doRW; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wlrmthuq; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Ncb6doRW; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wlrmthuq; arc=none smtp.remote-ip=195.135.223.130 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A99A606A31A; Fri, 23 Oct 2026 08:51:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4A99A606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Ncb6doRW; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wlrmthuq; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Ncb6doRW; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wlrmthuq Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 694D321C53; Fri, 23 Oct 2026 08:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792745488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O8hx2K3MguPb+IPLbG/1EkjyoxvdTxrh8Upow7TUDnI=; b=Ncb6doRWi7VgBR6oi6ujgD7vx6n6h0AX6SD7uchzq0vurbRtwgFu7RPoNr6pTXBn5ViUme uARXHu05lkukBJBwIG3fcG2uv2DVJvZY9nPYHVyN+YNsMauUzpGdHDvfxdJ+zKYt8rsl0Y t5/6lZ8ElqWW5cAhEtZ40EvcYGKQZ7U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792745488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O8hx2K3MguPb+IPLbG/1EkjyoxvdTxrh8Upow7TUDnI=; b=wlrmthuqSM1J6WSEGckl8A6kE3ho3whlf/xeixnubJ7V3ISJTmhd+NljKcbnw9fq6GGbtZ MPUHgVULBbiB0GDA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792745488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O8hx2K3MguPb+IPLbG/1EkjyoxvdTxrh8Upow7TUDnI=; b=Ncb6doRWi7VgBR6oi6ujgD7vx6n6h0AX6SD7uchzq0vurbRtwgFu7RPoNr6pTXBn5ViUme uARXHu05lkukBJBwIG3fcG2uv2DVJvZY9nPYHVyN+YNsMauUzpGdHDvfxdJ+zKYt8rsl0Y t5/6lZ8ElqWW5cAhEtZ40EvcYGKQZ7U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792745488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O8hx2K3MguPb+IPLbG/1EkjyoxvdTxrh8Upow7TUDnI=; b=wlrmthuqSM1J6WSEGckl8A6kE3ho3whlf/xeixnubJ7V3ISJTmhd+NljKcbnw9fq6GGbtZ MPUHgVULBbiB0GDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E77F1133F6; Fri, 23 Oct 2026 08:51:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ezGjJw8g22pkHwAAD6G6ig (envelope-from ); Fri, 23 Oct 2026 08:51:27 +0000 Message-ID: <2a9b1325-386b-4460-8651-13fc43dca6c6@suse.de> Date: Fri, 23 Oct 2026 10:51:27 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/fbdev: Replace __MODULE_STRING() with __stringify() To: Sasha Levin , Maarten Lankhorst , Maxime Ripard Cc: David Airlie , Simona Vetter , Petr Pavlu , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261022175543.1831620-1-sashal@kernel.org> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20261022175543.1831620-1-sashal@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spam-Level: X-Spamd-Result: default: False [-13.29 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWELVE(0.00)[13]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,ffwll.ch,suse.com,kernel.org,google.com,atomlin.com,lists.freedesktop.org,vger.kernel.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,imap1.dmz-prg2.suse.org:helo,suse.de:email] X-Spam-Score: -13.29 Hi Am 22.10.26 um 19:55 schrieb Sasha Levin: > Commit 08abfa5a161e ("drivers: Replace __MODULE_STRING() with > __stringify()") converted the drm_fbdev_overalloc parameter description > in drm_fb_helper.c ahead of the removal of __MODULE_STRING(). > > Commit 6b5a66fd9f21 ("drm/fbdev: Move fbdev module parameters next to > module init") moved that parameter into drm_kms_helper_common.c while it > still used __MODULE_STRING(), so the conversion never reached the moved > code. drm_kms_helper_common.c is now the last user of the macro, and > removing the macro breaks the build with CONFIG_DRM_FBDEV_EMULATION=y: > > drivers/gpu/drm/drm_kms_helper_common.c:46:18: error: expected ')' before '__MODULE_STRING' > > Use __stringify() instead. The parameter description is unchanged. > > Signed-off-by: Sasha Levin Reviewed-by: Thomas Zimmermann > --- > This depends on 6b5a66fd9f21 in drm-next and 08abfa5a161e in > modules-next, both queued for 7.4. Petr plans to remove > __MODULE_STRING() once his conversions are in mainline, so this needs to > land first, either through drm-misc after 7.4-rc1 or together with the > removal patch. Dave, could we put this patch directly into drm-next? It seems like this fixes a broken merge commit. Best regards Thomas > > Build-tested on next-20261022 (x86_64, gcc) with __MODULE_STRING() > removed from module.h. The parameter description in modinfo is > unchanged. > > drivers/gpu/drm/drm_kms_helper_common.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_kms_helper_common.c b/drivers/gpu/drm/drm_kms_helper_common.c > index 1e55ecac46989..346f6c4c0b234 100644 > --- a/drivers/gpu/drm/drm_kms_helper_common.c > +++ b/drivers/gpu/drm/drm_kms_helper_common.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include > > #include "drm_crtc_helper_internal.h" > #include "drm_panic_internal.h" > @@ -43,7 +44,7 @@ EXPORT_SYMBOL(drm_fbdev_overalloc); > module_param(drm_fbdev_overalloc, int, 0444); > MODULE_PARM_DESC(drm_fbdev_overalloc, > "Overallocation of the fbdev buffer (%) [default=" > - __MODULE_STRING(CONFIG_DRM_FBDEV_OVERALLOC) "]"); > + __stringify(CONFIG_DRM_FBDEV_OVERALLOC) "]"); > > /* > * In order to keep user-space compatibility, we want in certain use-cases -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)