From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CDFB30F7F3 for ; Tue, 6 Jan 2026 08:21:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767687675; cv=none; b=Fql9aMlR7/AjfzR3CBQEo+YjxWujBEfEblPxAlxYg+JeipbwEN+oS+o3XTRYQv2qzq8Bb4xmoiZAHg5qsAw9XnpzjKFbPPiukdW7l5t/cj1OqYzKlL0j9SQ/O+Lyc76r2rjs4KQX1JS+chX/1PXQ0csVm7uNFYmISaOH7kvxxqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767687675; c=relaxed/simple; bh=RC1x/YJFQhrisUJN5tlogNCZHfDpd8n4ujviZbk2MI0=; h=Message-ID:Date:MIME-Version:From:Subject:To:References: In-Reply-To:Content-Type; b=kIh8bT+ZhyHhtlquDJ7uXIg/iyoSo725ALy6Besx1hr71Kf3kCLBulLXcXVH83pyp08giTNY8PGGJrznO+QqgxISrPOmatucYLMUb2CcYIe+Yw80YgmX9fPs2PaGUBi2oKaw6AiWJ/gVH860Ha0EiNukVgWsNxGidW0imGPn/rI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=htP5CINd; arc=none smtp.client-ip=209.85.221.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="htP5CINd" Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-432755545fcso365993f8f.1 for ; Tue, 06 Jan 2026 00:21:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767687670; x=1768292470; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=mo2aCmsWo4elpcgvHCHejvpSSvbkXFYtvQl6RpGpMmE=; b=htP5CINdAevHO94X6ZHIFp6NGxhd1e43J4yWce7J9r5laUj0q1KtY/JGvKwM5IJGuI 2baQ/f4xo/I4VKaNR4jkkrI0/ebWTiLbiVw+wVIXZkt1LylFwxyU2PgmfrEudnLiO9A3 5ZUzILkIKzQQmbLJ69hlNYTzrjw04juqyQWa1L9yjwBm3WwuRM782kbFVmCE1CoZnJz8 +L1AWJRBAdx9clMnliCPNYqG4EUM389HvxC63Svx4PwYOyr/DXkj+qCjl3ExnYjRq6yi PUFrZgJW164refWc7SA6Y9HedLVZ3tmVD5EDNGWCH9P2TVyTFszREmRDAberwWCLj2tM MhgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767687670; x=1768292470; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mo2aCmsWo4elpcgvHCHejvpSSvbkXFYtvQl6RpGpMmE=; b=qQpVDiAa39y0zq6l8axyC/WnyyJY+GFeNzcXWSsk30n8t76lm9N0Ifzhfo5K5vsbmI vcvY4Ffm/iI6KgIM7Tw6SANN90qgEnT9LakhfYvhYfZFNCFGfu0o1r09gSHBauXj9YDX J0K3fQKwCRxaIEp6oUWgie4c2lk8//vu3uRo41hS92E68yAWC8OY2skUcg1XTdri3C/y PGj84za/tINdCNwMpZ8isb2yPxl2CbZqR3N/Eb+ShsX2Bbuw40tdYTz4IurLNCTZDPeg VU9LOJW4yiDi/nITAW2kDrcWoQ+42DhPtlDkxt732IGpF6OiHr7VzmL/4MYKr/B7AdPx F4kg== X-Forwarded-Encrypted: i=1; AJvYcCXanwZh5UYsfgn4aaiplS/JqT4rJACKYHAzTuN1/fL2xhq/bRfax4fjPUnpcB2VHVEvcsrGVbtr+rj3EjU=@vger.kernel.org X-Gm-Message-State: AOJu0YxnQFsUI/wj3eEIMyrEKrgwpxVvbLDfGKnZVf2rEdhXbsXPTW3S bRw+rgamTi7nOPBufbUOaE/44k2aWTRQui1eZ1XWwNb+qMUfNKn1qhR9GlenbdIy35w= X-Gm-Gg: AY/fxX6iIgAkVwus87fEJ9wNtKboRnC4qzhWXfB5GiOwkTLEnVGRrOcW1AaZ0jkg5kr NdISpdkhWwQnMyqbAI2oQWIg1A97IiFepLV9q+h7+y+yDqYW1SsalzQfmDdtmwmWtFsYiUGNa+L ScQwVy7N7KPlpQvowYC0K29Jn0tYS60pw2sA3h7Z2QLF/3ZfxNQTGvWlZyYmQCpM8N6UDxuQSsk L+S7jKcixqA7JmHHHoXEIFAk7YPNZL6UnOGBRrzQwNNVnQJqDWdn+JbrQuqR7+y9T0Bhs0CUhUJ wf/FSKLe1RMeWZRrBImy+BxFm3gPbQXK7UrkyBwbg5tTLhMsz1+0+2+klBlXKB8CeZp2S8YiNh/ ixcKiV8r9zclmnd/HDWrKCEddUo01XqhoHRjWKuWEV1DtsIaJkfoOes6C/fxp/DRlt176/ML/DJ jiWHelkTI6iuU1pcaa7Z64p4Buv4qaPvLYVPUV9tVglMxoQG2sTKAqF8YwC4orsiw= X-Google-Smtp-Source: AGHT+IFvOchFqZii463WUdKG9AZkhDIWes46hV+OjUY+EFnasHCg5d0F6M6XA80K7aHHMSWsjTfICg== X-Received: by 2002:a05:6000:4287:b0:432:a9db:f99b with SMTP id ffacd0b85a97d-432bc9ccd56mr2667816f8f.0.1767687670291; Tue, 06 Jan 2026 00:21:10 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:d283:7a7e:4c57:678d? ([2a01:e0a:3d9:2080:d283:7a7e:4c57:678d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e6784sm2953813f8f.19.2026.01.06.00.21.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 00:21:09 -0800 (PST) Message-ID: <2a9f7c54-3669-4f8b-b46b-b7e01712a1b8@linaro.org> Date: Tue, 6 Jan 2026 09:21:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH] drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi wrapped functions To: Avinal Kumar , jessica.zhang@oss.qualcomm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251127161337.396531-1-avinal.xlvii@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20251127161337.396531-1-avinal.xlvii@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 11/27/25 17:08, Avinal Kumar wrote: > Changes the panasonic-vvx10f034n00 panel to multi > style functions for improved error handling. > > Signed-off-by: Avinal Kumar > --- > Here is the todo list for reference: https://www.kernel.org/doc/html/latest/gpu/todo.html#transition-away-from-using-deprecated-mipi-dsi-functions > > This is my first patch in Linux Kernel :) > > drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c > index 3c3308fc55df..03c87c02fb57 100644 > --- a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c > +++ b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c > @@ -44,7 +44,12 @@ static inline struct wuxga_nt_panel *to_wuxga_nt_panel(struct drm_panel *panel) > > static int wuxga_nt_panel_on(struct wuxga_nt_panel *wuxga_nt) > { > - return mipi_dsi_turn_on_peripheral(wuxga_nt->dsi); > + struct mipi_dsi_multi_context dsi_ctx = { > + .dsi = wuxga_nt->dsi > + }; > + > + mipi_dsi_turn_on_peripheral_multi(&dsi_ctx); > + return dsi_ctx.accum_err; > } > > static int wuxga_nt_panel_disable(struct drm_panel *panel) Why didn't you also update wuxga_nt_panel_disable() ? Thanks, Neil