mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: 李扬韬 <frank@allwinnertech.com>
To: "Maxime Ripard" <maxime@cerno.tech>
Cc: wens <wens@csie.org>, robh+dt <robh+dt@kernel.org>,
	"tiny.windzz" <tiny.windzz@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	黄烁生 <huangshuosheng@allwinnertech.com>,
	李勇 <liyong@allwinnertech.com>
Subject: Re: [PATCH v3 16/16] arm64: allwinner: A100: add support for Allwinner Perf1 board
Date: Mon, 13 Jul 2020 10:30:27 +0800	[thread overview]
Message-ID: <2aa29f79-c105-4dc7-ac71-91a8e1225833.frank@allwinnertech.com> (raw)
In-Reply-To: <20200710123617.ebd2ljn7okdrx4ph@gilmour.lan>

>> +&pio {
>> + vcc-pb-supply = <&reg_dcdc1>;
>> + vcc-pc-supply = <&reg_eldo1>;
>> + vcc-pd-supply = <&reg_dcdc1>;
>> + vcc-pe-supply = <&reg_dldo2>;
>> + vcc-pf-supply = <&reg_dcdc1>;
>> + vcc-pg-supply = <&reg_dldo1>;
>> + vcc-ph-supply = <&reg_dcdc1>;
>> +};

>There's something off here. The PC supply is set to eldo1, but

>> +&reg_dcdc1 {
>> + regulator-always-on;
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-name = "vcc-pc-io-usb-pd-emmc-nand-card";
>> +};

>But here you say in the name that dldo1 is a PC supply too?

There is some misleading on the schematic, in fact there is no
connection between dcdc1 and pc, I will fix this.

Thx,
Yangtao

      reply	other threads:[~2020-07-13  2:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08  8:28 Frank Lee
2020-07-10 12:36 ` Maxime Ripard
2020-07-13  2:30   ` 李扬韬 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2aa29f79-c105-4dc7-ac71-91a8e1225833.frank@allwinnertech.com \
    --to=frank@allwinnertech.com \
    --cc=devicetree@vger.kernel.org \
    --cc=huangshuosheng@allwinnertech.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liyong@allwinnertech.com \
    --cc=maxime@cerno.tech \
    --cc=robh+dt@kernel.org \
    --cc=tiny.windzz@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®