Re: [PATCH v2] gpio: davinci: Add support for system suspend/resume PM

[Aswath Govindraju <a-govindraju@ti.com>]

Hi Andy,

On 10/06/22 17:50, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 8:08 AM Aswath Govindraju <a-govindraju@ti.com> wrote:
>>
>> From: Devarsh Thakkar <devarsht@ti.com>
>>
>> Add support for system suspend/resume PM hooks, save the
>> register context of all the required gpio registers on suspend
>> and restore the context on resume.
> 
> the resume
> 

Fixed this in respin
> ...
> 
>> +       writel_relaxed(0xFFFFFFFF, &g->intstat);
> 
> GENMASK(31, 0) ?

Used this instead of the direct value in the respin

> 
> ...
> 
>> +static int __maybe_unused davinci_gpio_suspend(struct device *dev)
> 
>> +static int __maybe_unused davinci_gpio_resume(struct device *dev)
> 
>> +static const struct dev_pm_ops davinci_gpio_dev_pm_ops = {
>> +       SET_SYSTEM_SLEEP_PM_OPS(davinci_gpio_suspend, davinci_gpio_resume)
>> +};
> 
>> +               .pm = &davinci_gpio_dev_pm_ops,
> 
> Can you utilize pm_sleep_ptr() and corresponding macros instead of
> __maybe_unused?

Used pm_sleep_ptr instead of the __maybe_unused in the respin.

Thank you for the review. I have posted a respin(v3) for this patch,

https://patchwork.ozlabs.org/project/linux-gpio/patch/20220613054310.21186-1-a-govindraju@ti.com/

-- 
Thanks,
Aswath