Re: [PATCH] usb: dwc2: Fix unused label warning

[Yuehaibing <yuehaibing@huawei.com>]

On 2020/11/2 15:04, Minas Harutyunyan wrote:
> On 10/31/2020 10:03 AM, YueHaibing wrote:
>> drivers/usb/dwc2/platform.c: In function ‘dwc2_driver_probe’:
>> drivers/usb/dwc2/platform.c:611:1: warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
>>   error_debugfs:
>>   ^~~~~~~~~~~~~
>>
>> Move label 'error_debugfs' to ifdef block.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>   drivers/usb/dwc2/platform.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
>> index e2820676beb1..5f18acac7406 100644
>> --- a/drivers/usb/dwc2/platform.c
>> +++ b/drivers/usb/dwc2/platform.c
>> @@ -608,10 +608,13 @@ static int dwc2_driver_probe(struct platform_device *dev)
>>   #endif /* CONFIG_USB_DWC2_PERIPHERAL || CONFIG_USB_DWC2_DUAL_ROLE */
>>   	return 0;
>>   
>> +#if IS_ENABLED(CONFIG_USB_DWC2_PERIPHERAL) || \
>> +	IS_ENABLED(CONFIG_USB_DWC2_DUAL_ROLE)
>>   error_debugfs:
>>   	dwc2_debugfs_exit(hsotg);
>>   	if (hsotg->hcd_enabled)
>>   		dwc2_hcd_remove(hsotg);
>> +#endif
>>   error_drd:
>>   	dwc2_drd_exit(hsotg);
>>   
>>
> Thank you for patch. Identical patch submitted by on 10/17/2020 by 
> Martin Blumenstingl: [PATCH] usb: dwc2: Avoid leaving the error_debugfs 
> label unused. I'm already ACKed it.

Thanks for this info.
> Thanks,
> Minas
>