From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB56F208A4 for ; Tue, 27 Feb 2024 16:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709052088; cv=none; b=YfIkJOJm38ZRQ95KOPH+NMzGtztMygb0P/7fMBUJnEzqKwioCVt49uHQXJiaVotbVzT7rvZr5QVOpnXi7QrJ5AYSidX9bIILfb3sTWnqoukOk042CevrBCwttjS2KS9bGQSZIn4f3b1oyWsl/3asTNx/6B33b4t1Ka1p1Yw8ic8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709052088; c=relaxed/simple; bh=/drlaqNP34djKRMPww7Fy9vfeScYwuCh547zTKPR7TY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=noDv93tRp74tqowz+PR8NXzzU8VZT5iGg1uhsInwpzb1JnB8g1CCMtg+VAhgZzsp6g00kE8MLjEL2M/Ytiv3tLadK8CtoVyU2jSkI4PBangrh1rFmMoUqCwo+ZiMaRP08Zs+xDacYqck+zITtAIAFlvYg4os/tIk9qlHofppGO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Dwoo1/r8; arc=none smtp.client-ip=209.85.161.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Dwoo1/r8" Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5a0918d6d83so78357eaf.0 for ; Tue, 27 Feb 2024 08:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1709052085; x=1709656885; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cj7Czl12HamAEioeVvBO9DiukTU/zhT4MfnATWo179Y=; b=Dwoo1/r89EOVOjAjfR9mHhZe6H8WKo+0Q/0K0G3RiLg+xq46NCE4n4zzchXh9SPGiC mXwij9heY8JtqHbmPnWxFkRDKE5DnweKOeOcdpN6asYYzf3go+/nMo8WrxzFXBjYDK58 AFtu/jT641TwLkRqCpiLAFEznG5RMXgu9WuJQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709052085; x=1709656885; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cj7Czl12HamAEioeVvBO9DiukTU/zhT4MfnATWo179Y=; b=vJNBm7UdPGvpQyfdjaZV6UFzoFfJq7FbM/lTOTbqeHnzxOQTAw1ZtmVi/7v5Nz673T UnIjQjfSHrkjL20m+Ks8OQ+P8yJyzoQG/ilMnGNez/kBa3XjNNtcXfEdUXo4QQprI8sj uIqx8ZMr01XcG0v1OjDNd43vRxpYbwh5qoCMXTURABtClwC17Eevjxh3WRlZaxUBkXAo qBZVORqAIMOXEUZpAt9wteGQuzEsGokd4S7X6SQYvBQEJWIE5ZDHVkmre4qwjo4ibMor tM8MneG5xG/Awp/vfKs1MxLiNvFlmQ3S0wQV8krevWZkPgYxLCfheYZ9TyLGHY+YW0aV 9R1Q== X-Forwarded-Encrypted: i=1; AJvYcCUtRPFIF8s0Xqs8+lXaeDdsne8kdR7NzlHIPNP0E2s/TjK2NDumSPK5U6DD8HBVVSDe+COJPTGFjGnq4Yv23RHiZ84rCNPb8xMHbfZg X-Gm-Message-State: AOJu0YyaaKFc0D2Q3bmRQ2GgdzxBwph9qS0cVlS5OH4epMBsqx+VAhIC eylNZGvZIR/fujiN3sfhPFxgl1h/x//PLKkXAW2s5Rw+261tF6Bo1mBIDS89MEk= X-Google-Smtp-Source: AGHT+IHbpcRP3SYOp6TthHDLPxhDxQntg2dWl5/P/9lzYYvGOMon4J/GdfdlbHWeBuNjMwcMVhHFVw== X-Received: by 2002:a05:6820:2c8e:b0:5a0:4d78:975d with SMTP id dx14-20020a0568202c8e00b005a04d78975dmr9529006oob.1.1709052084818; Tue, 27 Feb 2024 08:41:24 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id v11-20020a056820004b00b005a0a8e661d3sm456853oob.42.2024.02.27.08.41.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Feb 2024 08:41:24 -0800 (PST) Message-ID: <2aaa2a61-f753-4434-8c92-886fc4bb9aef@linuxfoundation.org> Date: Tue, 27 Feb 2024 09:41:23 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH] selftests/overlayfs: fix compilation error in overlayfs Content-Language: en-US To: Meng Li , Andrei Vagin , Huang Rui , linux-pm@vger.kernel.org Cc: Nathan Fontenot , Deepak Sharma , Alex Deucher , Mario Limonciello , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , linux-kernel@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" References: <20240227074204.3573450-1-li.meng@amd.com> From: Shuah Khan In-Reply-To: <20240227074204.3573450-1-li.meng@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/27/24 00:42, Meng Li wrote: > make -C tools/testing/selftests, compiling dev_in_maps fail. > In file included from dev_in_maps.c:10: > /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected identifier before numeric constant > 35 | MS_RDONLY = 1, /* Mount read-only. */ > | ^~~~~~~~~ > > That sys/mount.h has to be included before linux/mount.h. > > Signed-off-by: Meng Li > --- > tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > I don't see this problem when I build it on my system when I run: make -C tools/testing/selftests or make -C tools/testing/selftests/filesystems/overlayfs Are you running this after doing headers_install? thanks, -- Shuah