Re: [PATCH 2/2] powerpc/mm: Trace tlbia instruction

[Christophe LEROY <christophe.leroy@c-s.fr>]

Le 19/03/2018 à 23:43, Balbir Singh a écrit :
> On Mon, 19 Mar 2018 11:32:40 +0100 (CET)
> Christophe Leroy <christophe.leroy@c-s.fr> wrote:
> 
>> Add a trace point for tlbia (Translation Lookaside Buffer Invalidate
>> All) instruction.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>>   arch/powerpc/include/asm/trace.h | 15 +++++++++++++++
>>   arch/powerpc/mm/mmu_decl.h       |  2 ++
>>   2 files changed, 17 insertions(+)
>>
>> diff --git a/arch/powerpc/include/asm/trace.h b/arch/powerpc/include/asm/trace.h
>> index 33f3b479138b..d1d63b173dd7 100644
>> --- a/arch/powerpc/include/asm/trace.h
>> +++ b/arch/powerpc/include/asm/trace.h
>> @@ -202,6 +202,21 @@ TRACE_EVENT(tlbie,
>>   		__entry->r)
>>   );
>>   
>> +TRACE_EVENT(tlbia,
>> +
>> +	TP_PROTO(unsigned long lpid),
>> +	TP_ARGS(lpid),
>> +	TP_STRUCT__entry(
>> +		__field(unsigned long, lpid)
>> +		),
>> +
>> +	TP_fast_assign(
>> +		__entry->lpid = lpid;
>> +		),
>> +
>> +	TP_printk("lpid=%ld", __entry->lpid)
>> +);
> 
> 
> Do we want to call this lpid?
> 

Should we can it rs in consistence with tlbie trace ? Or just pid ?
Allthough it is not an argument used by tlbia, I think it is good to 
keep a trace of it to keep track of the reason why tlbia is called.

Christophe