Re: [PATCH V5 1/3] cpuidle: play_idle: Make play_idle more flexible

[Daniel Lezcano <daniel.lezcano@linaro.org>]

Hi Ulf,


On 28/10/2019 23:26, Ulf Hansson wrote:
> On Mon, 28 Oct 2019 at 15:34, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>>
>> The play_idle function has two users, the intel powerclamp and the
>> idle_injection.
>>
>> The idle injection cooling device uses the function via the
>> idle_injection powercap's APIs. Unfortunately, play_idle is currently
>> limited by the idle state depth: by default the deepest idle state is
>> selected. On the ARM[64] platforms, most of the time it is the cluster
>> idle state, the exit latency and the residency can be very high. That
>> reduces the scope of the idle injection usage because the impact on
>> the performances can be very significant.
>>
>> If the idle injection cycles can be done with a shallow state like a
>> retention state, the cooling effect would eventually give similar
>> results than the cpufreq cooling device.
>>
>> In order to prepare the function to receive an idle state parameter,
>> let's replace the 'use_deepest_state' boolean field with 'use_state'
>> and use this value to enter the specific idle state.
>>
>> The current code keeps the default behavior which is go to the deepest
>> idle state.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> 
> This looks good to me! Just a minor nitpick, see more below. If you
> don't like my suggestions, I am fine as is. Therefore:

Thank you very much for reviewing the patches.

I don't have any objection about renaming the variables as you suggest.

Rafael, is it fine the renaming?

> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>


[ ... ]


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog