From: Armin Wolf <W_Armin@gmx.de>
To: Randy Dunlap <rdunlap@infradead.org>,
hdegoede@redhat.com, markgross@kernel.org
Cc: rafael@kernel.org, lenb@kernel.org, hmh@hmh.eng.br,
matan@svgalib.org, corentin.chary@gmail.com, jeremy@system76.com,
productdev@system76.com, platform-driver-x86@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] platform/x86: dell: Add new dell-wmi-ddv driver
Date: Tue, 13 Sep 2022 16:40:44 +0200 [thread overview]
Message-ID: <2aae0ae9-9608-675a-ec0c-6e7526e57363@gmx.de> (raw)
In-Reply-To: <b1b794b4-f6c3-7697-5d5a-b811809a9313@infradead.org>
Am 12.09.22 um 23:56 schrieb Randy Dunlap:
> Hi--
>
> On 9/12/22 05:53, Armin Wolf wrote:
>> diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
>> index 25421e061c47..209e63e347e2 100644
>> --- a/drivers/platform/x86/dell/Kconfig
>> +++ b/drivers/platform/x86/dell/Kconfig
>> @@ -189,6 +189,19 @@ config DELL_WMI_DESCRIPTOR
>> default n
>> depends on ACPI_WMI
>>
>> +config DELL_WMI_DDV
>> + tristate "Dell WMI sensors Support"
>> + default m
> You should (try to) justify default m, otherwise just
> don't have a default for it.
I have chosen default m since many other Dell platform drivers are being
default m. Since this driver is not essential for normal operation,
i will drop default m then.
Armin Wolf
>> + depends on ACPI_BATTERY
>> + depends on ACPI_WMI
>> + help
>> + This option adds support for WMI-based sensors like
>> + battery temperature sensors found on some Dell notebooks.
>> + It also supports reading of the batteries ePPID.
>> +
>> + To compile this drivers as a module, choose M here: the module will
>> + be called dell-wmi-ddv.
next prev parent reply other threads:[~2022-09-13 15:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 12:53 [PATCH 0/5] " Armin Wolf
2022-09-12 12:53 ` [PATCH 1/5] ACPI: battery: Do not unload battery hooks on single error Armin Wolf
2022-09-19 10:42 ` Hans de Goede
2022-09-19 16:27 ` Rafael J. Wysocki
2022-09-19 19:12 ` Armin Wolf
2022-09-19 20:35 ` Armin Wolf
2022-09-27 14:29 ` Hans de Goede
2022-09-27 15:44 ` Armin Wolf
2022-09-12 12:53 ` [PATCH 2/5] ACPI: battery: Simplify battery_hook_unregister() Armin Wolf
2022-09-19 10:42 ` Hans de Goede
2022-09-12 12:53 ` [PATCH 3/5] ACPI: battery: Allow battery hooks to be registered multiple times Armin Wolf
2022-09-12 16:42 ` Barnabás Pőcze
2022-09-12 17:29 ` Armin Wolf
2022-09-19 11:18 ` Hans de Goede
2022-09-19 17:42 ` Barnabás Pőcze
2022-09-12 12:53 ` [PATCH 4/5] ACPI: battery: Allow for passing data to battery hooks Armin Wolf
2022-09-19 11:08 ` Hans de Goede
2022-09-12 12:53 ` [PATCH 5/5] platform/x86: dell: Add new dell-wmi-ddv driver Armin Wolf
2022-09-12 21:56 ` Randy Dunlap
2022-09-13 14:40 ` Armin Wolf [this message]
2022-09-13 16:08 ` Limonciello, Mario
2022-09-13 16:45 ` Armin Wolf
2022-09-13 18:27 ` Randy Dunlap
2022-09-13 18:30 ` Limonciello, Mario
2022-09-13 18:37 ` Randy Dunlap
2022-09-19 11:33 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2aae0ae9-9608-675a-ec0c-6e7526e57363@gmx.de \
--to=w_armin@gmx.de \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=jeremy@system76.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=matan@svgalib.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=productdev@system76.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®