From: Paolo Bonzini <pbonzini@redhat.com>
To: KarimAllah Ahmed <karahmed@amazon.com>,
"Raj, Ashok" <ashok.raj@intel.com>,
KarimAllah Ahmed <karahmed@amazon.de>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, Asit Mallick <asit.k.mallick@intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Arjan Van De Ven <arjan.van.de.ven@intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dan Williams <dan.j.williams@intel.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Andy Lutomirski <luto@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
David Woodhouse <dwmw@amazon.co.uk>
Subject: Re: [PATCH v3 3/4] KVM: VMX: Emulate MSR_IA32_ARCH_CAPABILITIES
Date: Tue, 30 Jan 2018 18:21:47 -0500 [thread overview]
Message-ID: <2aaedc76-b407-15f9-7712-535e08153a26@redhat.com> (raw)
In-Reply-To: <87b28856-c477-283f-695c-daed42b31287@amazon.com>
On 29/01/2018 19:25, KarimAllah Ahmed wrote:
>>> + case MSR_IA32_ARCH_CAPABILITIES:
>>> + if (!msr_info->host_initiated)
>>> + return 1;
>>> + vmx->arch_capabilities = data;
>>> + break;
>>
>> arch capabilities is read only. You don't need the set_msr handling
>> for this.
>
> This is only for host driven writes. This would allow QEMU/whatever to
> override the default value (i.e. the value from the hardware).
Agreed.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2018-01-30 23:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 0:10 [PATCH v3 0/4] KVM: Expose speculation control feature to guests KarimAllah Ahmed
2018-01-30 0:10 ` [PATCH v3 1/4] KVM: x86: Update the reverse_cpuid list to include CPUID_7_EDX KarimAllah Ahmed
2018-01-30 23:17 ` Paolo Bonzini
2018-01-30 0:10 ` [PATCH v3 2/4] KVM: x86: Add IBPB support KarimAllah Ahmed
2018-01-30 14:22 ` Tom Lendacky
2018-01-30 14:36 ` David Woodhouse
2018-01-30 17:19 ` Jim Mattson
2018-01-30 17:43 ` David Woodhouse
2018-01-30 0:10 ` [PATCH v3 3/4] KVM: VMX: Emulate MSR_IA32_ARCH_CAPABILITIES KarimAllah Ahmed
2018-01-30 0:22 ` Raj, Ashok
2018-01-30 0:25 ` KarimAllah Ahmed
2018-01-30 23:21 ` Paolo Bonzini [this message]
2018-01-30 0:10 ` [PATCH v3 4/4] KVM: VMX: Allow direct access to MSR_IA32_SPEC_CTRL KarimAllah Ahmed
2018-01-30 17:49 ` Jim Mattson
2018-01-30 21:00 ` KarimAllah Ahmed
2018-01-30 22:49 ` Jim Mattson
2018-01-30 23:32 ` Paolo Bonzini
2018-01-30 23:50 ` KarimAllah Ahmed
2018-01-31 0:16 ` Jim Mattson
2018-01-31 0:19 ` Paolo Bonzini
2018-01-31 0:27 ` Jim Mattson
2018-01-31 0:52 ` KarimAllah Ahmed
2018-01-31 0:56 ` Paolo Bonzini
2018-01-30 9:00 ` [PATCH v3 0/4] KVM: Expose speculation control feature to guests David Woodhouse
2018-01-30 9:32 ` KarimAllah Ahmed
2018-01-30 23:36 ` Paolo Bonzini
2018-01-30 23:48 ` Raj, Ashok
2018-01-31 0:16 ` Paolo Bonzini
2018-01-31 0:26 ` David Woodhouse
2018-01-31 6:54 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2aaedc76-b407-15f9-7712-535e08153a26@redhat.com \
--to=pbonzini@redhat.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=arjan.van.de.ven@intel.com \
--cc=ashok.raj@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jun.nakajima@intel.com \
--cc=karahmed@amazon.com \
--cc=karahmed@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®