mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Hsin-chen Chuang <chharry@google.com>
Cc: linux-bluetooth@vger.kernel.org, luiz.dentz@gmail.com,
	gregkh@linuxfoundation.org,
	chromeos-bluetooth-upstreaming@chromium.org,
	Hsin-chen Chuang <chharry@chromium.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Ying Hsu <yinghsu@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: btusb: Configure altsetting for USER_CHANNEL
Date: Mon, 24 Feb 2025 09:42:41 +0100	[thread overview]
Message-ID: <2ab0d1c5-1bfe-4ef3-b23d-fee0ae1d7ad6@molgen.mpg.de> (raw)
In-Reply-To: <20250224022447.1141413-1-chharry@google.com>

Dear Hsin-chen,


Thank you for your patch.

Am 24.02.25 um 03:24 schrieb Hsin-chen Chuang:
> From: Hsin-chen Chuang <chharry@chromium.org>
> 
> Automatically configure the altsetting for USER_CHANNEL when a SCO is
> connected or disconnected. This adds support for the USER_CHANNEL to
> transfer SCO data over USB transport.

Should you re-spin, it’d be great if you elaborated a little more. 
Especially for the motivation. It’d be also great, if you added how to 
test this.

> Fixes: b16b327edb4d ("Bluetooth: btusb: add sysfs attribute to control USB alt setting")
> Signed-off-by: Hsin-chen Chuang <chharry@chromium.org>
> ---
> 
>   drivers/bluetooth/btusb.c | 224 +++++++++++++++++++++++++++++++-------
>   1 file changed, 186 insertions(+), 38 deletions(-)

[…]


Kind regards,

Paul

  parent reply	other threads:[~2025-02-24  8:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-24  2:24 Hsin-chen Chuang
2025-02-24  2:53 ` Luiz Augusto von Dentz
2025-02-24  3:20   ` Hsin-chen Chuang
2025-02-24  3:36     ` Luiz Augusto von Dentz
2025-02-24  3:58       ` Hsin-chen Chuang
2025-02-24  8:42 ` Paul Menzel [this message]
2025-02-24 13:06   ` Hsin-chen Chuang
2025-02-24 13:32     ` Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ab0d1c5-1bfe-4ef3-b23d-fee0ae1d7ad6@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=chharry@chromium.org \
    --cc=chharry@google.com \
    --cc=chromeos-bluetooth-upstreaming@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=yinghsu@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®