From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C5C5C54EE9 for ; Thu, 8 Sep 2022 16:57:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231633AbiIHQ5I (ORCPT ); Thu, 8 Sep 2022 12:57:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230481AbiIHQ4e (ORCPT ); Thu, 8 Sep 2022 12:56:34 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D75EC6B56; Thu, 8 Sep 2022 09:55:49 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 8984084AEF; Thu, 8 Sep 2022 18:55:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1662656147; bh=u3mZ+tnXgTSDTif48CXWvxQ8FMbV9gA9shuGifEl9po=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=s4KWNiCWW0z83o+7CuSxFfKTJSyKlDk/WX5MhjD228A9ZVIASiVEhdua2j4cPbH1d /0eutYrYlNsgIzcnA4e/5GK1kTGgnjMuhJ6SxfQEBfH262qvc9pKhAdiPvx4YEfhI9 obEovGUxPrNtOMnqnnJ9NECSBTfRT3xJJprpm7V/cG+O/UYkVQ2h2sRE4+moGUGNcW r7zR8eiLnhnAh+bYfurDDY+nf5KSkN/S7FtcWSGUUpLmokvhKu0FTcONx7ZUHp04sL imVrVIkbOcvZRtYKhCJK4rIoxIQq7G851lVFOl+NlrdenmwijYsG58PTdeIM68OoKJ TFmfY4ma91W3Q== Message-ID: <2ab24cc4-4aa2-d364-9b29-55f5d6b23626@denx.de> Date: Thu, 8 Sep 2022 18:55:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: BD71847 clk driver disables clk-32k-out causing RTC/WDT failure To: Tim Harvey , Matti Vaittinen Cc: linux-clk , open list , Fabio Estevam , Shawn Guo , NXP Linux Team , Stephen Boyd , Michael Turquette References: <59b6dd0a-7cbb-5dbd-8da0-57baeba3327e@gmail.com> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/8/22 18:00, Tim Harvey wrote: > On Thu, Sep 1, 2022 at 9:14 PM Matti Vaittinen wrote: >> >> Hi Tim, >> >> On 9/2/22 01:23, Tim Harvey wrote: >>> Greetings, >>> >>> I've found that the bd71847 clk driver (CONFIG_COMMON_CLK_BD718XX >>> drivers/clk/clk-bd718x7.c) disables clk-32k-out (the BD71847 C32K_OUT >>> pin) which is connected IMX8MM RTC_XTALI which ends up disabling the >>> IMX RTC as well as the IMX WDOG functionality. >> >> //snip >> >>> This happens via clk_unprepare_unused() as nothing is flagging the >>> clk-32k-out as being used. What should be added to the device-tree to >>> signify that this clk is indeed necessary and should not be disabled? >> >> I have seen following proposal from Marek Vasut: >> >> https://lore.kernel.org/all/20220517235919.200375-1-marex@denx.de/T/#m52d6d0831bf43d5f293e35cb27f3021f278d0564 >> >> I am not sure if the discussion is completed though. I guess it was >> agreed this was needed/usefull and maybe the remaining thing to decide >> was just the property naming. >> >> Best Regards >> -- Matti >> > > Thanks Matti, > > Marek - has there been any progress on determining how best to keep > certain clocks from being disabled? No. You can read the discussion above.