From: Paolo Bonzini <pbonzini@redhat.com>
To: Tianyu Lan <Tianyu.Lan@microsoft.com>
Cc: KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>,
vkuznets <vkuznets@redhat.com>,
Jork Loeser <Jork.Loeser@microsoft.com>
Subject: Re: [PATCH V3 2/13] KVM/MMU: Add tlb flush with range helper function
Date: Mon, 1 Oct 2018 17:25:54 +0200 [thread overview]
Message-ID: <2ab49b6e-59d1-1b1f-b533-85e5bc49dd85@redhat.com> (raw)
In-Reply-To: <20180927034829.2230-3-Tianyu.Lan@microsoft.com>
On 27/09/2018 05:48, Tianyu Lan wrote:
> +
> + if (range && kvm_x86_ops->tlb_remote_flush_with_range) {
> + /*
> + * Read tlbs_dirty before flushing tlbs in order
> + * to track dirty tlbs during flushing.
> + */
> + long dirty_count = smp_load_acquire(&kvm->tlbs_dirty);
> +
> + ret = kvm_x86_ops->tlb_remote_flush_with_range(kvm, range);
> + cmpxchg(&kvm->tlbs_dirty, dirty_count, 0);
This is wrong, because it's not the entire TLB that is flushed. So you
cannot do the cmpxchg here.
Paolo
> +
> + if (ret)
> + kvm_flush_remote_tlbs(kvm);
> +}
> +
next prev parent reply other threads:[~2018-10-01 15:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 3:48 [PATCH V3 00/13] x86/KVM/Hyper-v: Add HV ept tlb range flush hypercall support in KVM Tianyu Lan
2018-09-27 3:48 ` [PATCH V3 1/13] KVM: Add tlb_remote_flush_with_range callback in kvm_x86_ops Tianyu Lan
2018-09-27 3:48 ` [PATCH V3 2/13] KVM/MMU: Add tlb flush with range helper function Tianyu Lan
2018-10-01 15:25 ` Paolo Bonzini [this message]
2018-10-08 9:17 ` Tianyu Lan
2018-09-27 3:49 ` [PATCH V3 3/13] KVM: Replace old tlb flush function with new one to flush a specified range Tianyu Lan
2018-09-27 3:49 ` [PATCH V3 4/13] KVM/MMU: Flush tlb directly in the kvm_handle_hva_range() Tianyu Lan
2018-10-01 15:03 ` Paolo Bonzini
2018-09-27 3:49 ` [PATCH V3 5/13] KVM/MMU: Flush tlb directly in the kvm_zap_gfn_range() Tianyu Lan
2018-09-27 3:49 ` [PATCH V3 6/13] KVM/MMU: Flush tlb directly in kvm_mmu_zap_collapsible_spte() Tianyu Lan
2018-09-27 3:49 ` [PATCH V3 7/13] KVM: Add flush_link and parent_pte in the struct kvm_mmu_page Tianyu Lan
2018-09-27 3:49 ` [PATCH V3 8/13] KVM: Add spte's point " Tianyu Lan
2018-09-27 3:49 ` [PATCH V3 9/13] KVM/MMU: Replace tlb flush function with range list flush function Tianyu Lan
2018-09-27 3:49 ` [PATCH V3 10/13] x86/hyper-v: Add HvFlushGuestAddressList hypercall support Tianyu Lan
2018-09-27 4:16 ` Michael Kelley (EOSG)
2018-09-27 4:47 ` Tianyu Lan
2018-09-27 3:49 ` [PATCH V3 11/13] x86/Hyper-v: Add trace in the hyperv_nested_flush_guest_mapping_range() Tianyu Lan
2018-09-27 3:50 ` [PATCH V3 12/13] KVM/VMX: Change hv flush logic when ept tables are mismatched Tianyu Lan
2018-09-27 3:50 ` [PATCH V3 13/13] KVM/VMX: Add hv tlb range flush support Tianyu Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ab49b6e-59d1-1b1f-b533-85e5bc49dd85@redhat.com \
--to=pbonzini@redhat.com \
--cc=Jork.Loeser@microsoft.com \
--cc=Michael.H.Kelley@microsoft.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®