From: Markus Elfring <Markus.Elfring@web.de>
To: Riyan Dhiman <riyandhiman14@gmail.com>,
linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: mediatek-hw: Fix resource management and error handling in mtk_cpu_resources_init()
Date: Sat, 7 Sep 2024 18:10:24 +0200 [thread overview]
Message-ID: <2ab8c121-3fef-4d4d-a7b1-7892fb54b680@web.de> (raw)
In-Reply-To: <20240907154254.4704-1-riyandhiman14@gmail.com>
>>> Memory region and IO memory were not released if mtk_cpu_create_freq_table() failed.
>>> Added error handling to ensure that IO memory is unmapped and the memory region is
>>> released properly to prevent resource leaks and ensure all resources are cleaned up on error.
>>
>> * Would you like to improve such a change description another bit
>
> Should I elaborate a little more on the issue and explain the fix I have created?
Please take another look at guidance from linked information sources.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc6#n94
>> also according to other line length preferences?
>
> Can you please help me a little bit about this?
Yes, of course.
> Is it the character lenght of subject?
Not directly.
The summary phrase can eventually become more succinct.
>> * How do you think about to add any tags (like "Fixes" and "Cc") accordingly?
>
> Should I change "patch" in subject to "Fixes" or …
Obviously not.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc6#n145
Regards,
Markus
prev parent reply other threads:[~2024-09-07 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 8:40 Riyan Dhiman
2024-09-07 11:52 ` Markus Elfring
2024-09-07 15:42 ` Riyan Dhiman
2024-09-07 16:10 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ab8c121-3fef-4d4d-a7b1-7892fb54b680@web.de \
--to=markus.elfring@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=riyandhiman14@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®