From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DEB73A9618 for ; Fri, 17 Jul 2026 21:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784322852; cv=none; b=Cj5s+zs1xnfOuduxqvCZYFipmX4bwXouiQRyMmJxB/0JZoUBGhbepd/bIt4oCCJeDaEn/NFCEoGTaLvqBst+mGYc/LTlSw+KNl126iRtKc69wXu3w92+3ZhLe6PI15dMEqmoV/i5NMmvhTt3GzWqrMwYCBMFb+qzkFtTZzz/oBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784322852; c=relaxed/simple; bh=XM9neNInhG6hGapxARO8DnRxo5Je6MmvjK4WGCKF2Bk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=VbTRPBV73l1jY/wfW7B7c2neGG/e2j2BwrREVhb8TrQb2sPp+xHlYyxQA/5J1rdHP5G+2WqWuNRvPArwA171lrNeCBUK4+fjE+qvrGWzwIjmXSHv74hIMQpQWlWGYWsrL/JkqcjJ8lo3jNU6z7nW5y6C5gt6IVw5snq/DGWncfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PTyouAbf; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CFi5kTn0; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PTyouAbf"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CFi5kTn0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784322850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3n8ovVroS/g0E1kqDzhNKBMWW9UR5F3sPuTt8jUlpU4=; b=PTyouAbf1XkLbeReypLHNeQT9wAuFYLKeTiyHu5kri8hBvteh8pAeJYBzC4NM8Oy3D2xgg 4/YSqvTJyD8KcYul1ZTEFpxPtQ8tDfJiRJMH0An3wbQ8Kx8cr7waik+bjlDKuAMglW2Jiv y+WZbAFnm0yC7dpxxX77SjAVKgMPGjY= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-O2Ke8x6RMwK8XaQq2npakQ-1; Fri, 17 Jul 2026 17:14:08 -0400 X-MC-Unique: O2Ke8x6RMwK8XaQq2npakQ-1 X-Mimecast-MFC-AGG-ID: O2Ke8x6RMwK8XaQq2npakQ_1784322848 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e8004d60eso1077590985a.1 for ; Fri, 17 Jul 2026 14:14:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784322848; x=1784927648; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=3n8ovVroS/g0E1kqDzhNKBMWW9UR5F3sPuTt8jUlpU4=; b=CFi5kTn0Teju53tZjHA6RxND9rpMOSf0tC2eyPaFWMSCIipF2+RLkrhTBpsxAQopQW XE3v7YZ1l59c87VmmP9ErfMPO9YNOxTGqNtNDnb5MDpBhVndz6RhVZ1T64BK6R71B0xq Mn5FQYjCsQurLHBhjV0ouH73M0kVBccRYKGCGG9iJRtMGMS7q8tbe8ulXLiXmv5kYTZL WhPEUR7D9focSGyWWA8/4CdxG2PkkifaKTljnQbKjH57dhPk00JFKV3/leJDMs4+x03o R7Fw5oYUixcngtnDAwEHJ3IXczEL3iJgH6QdEsKZX119mGRhKJRf+tby4Nq3mrpbGvVl sOYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784322848; x=1784927648; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3n8ovVroS/g0E1kqDzhNKBMWW9UR5F3sPuTt8jUlpU4=; b=ee+cP9HUJMUh3ZoF7PI468BXwmBbuaUgZ1WuqLmySoLOpgrGjZFi0wCmAb8fvyeNOx Tbo19Hxx74TNbQSRwOkkMowmNpmR7gDKw8CJMWDRQTAef8e8vjtjEIoVGvJS/tSqViI+ upJGM6wP6pHZIZYikZMRp5pFavJDxFo9dVeU1FVqIapK1pvd5pA2QDI9dS5jDQeXdApa ZVh1Iao1BdDiPbng0WjrthPyilDfZvn3LFn8Rc2X1HYfDIVtzNekU+mqHFrcmuz2ezFy KiBaqSyjaDO5BZeYOdHU5yiEHti/JXbJZCRaAYCkJNgeZpnrN1Q2AHMx/atTTcT7rYuz D/4w== X-Gm-Message-State: AOJu0YzG4wjXqK1215NmB8VssLizOSuWsg/WigAqEdv61tPtgOp2s8oI my7KpmQf2HcjOVIT4awOm1ZrcInIXlVKv/+F4t3wYPvQzg2PZ0id1Ce3nqNWFBkGItL+N0br+ml 6ddDnISIifRWHSUB6ztBkcjqECirtcT44LIjJphvdr5qY1Oy+9TRMz983HBEhc+d8mg== X-Gm-Gg: AfdE7ck9/mZgCCkTKM2t6If7cxROIYFUajkjTjAEzQxQktl++kTf18RN+HBx04OvdBT ljfS8oCt5mBs+mMsqqOr2h8/1ggPhmMuLlYs9gAZO8SRwOE3zWNWY3fp0Fd+wEvIHHwPo92AKmp Kl8p5oQs0aK8GzhcrWNd6KV9nHen3xTSq9fg78GpPWlkAGb17tA5SOX8I9jtgl2ODGJB5DzAXte 09Us+6kaxJU3evw6Z3GD6TWFI9o4sqcqkUkjzy8YAA9ey6GIz+6SLn3rn/3B5/1QPlYWoOsm5m+ pzhbrFQngAD2iRwe4ZY1vdPbYoyV+f8JWVo/BLMmOYWnsgSnabCc5DXBDXAnooxLVlXhJ2ME X-Received: by 2002:a05:620a:390e:b0:930:b12c:158d with SMTP id af79cd13be357-930b3eea06cmr491921285a.38.1784322848117; Fri, 17 Jul 2026 14:14:08 -0700 (PDT) X-Received: by 2002:a05:620a:390e:b0:930:b12c:158d with SMTP id af79cd13be357-930b3eea06cmr491919185a.38.1784322847719; Fri, 17 Jul 2026 14:14:07 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id af79cd13be357-930b5461a16sm247735785a.33.2026.07.17.14.14.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 14:14:06 -0700 (PDT) Message-ID: <2aba63b4d22a329259f335b1a69a4642ad1ddb89.camel@redhat.com> Subject: Re: [PATCH] drm/nouveau: Omit a redundant pm_runtime_mark_last_busy() call in nouveau_pmops_runtime_idle() From: lyude@redhat.com To: Markus Elfring , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Danilo Krummrich , David Airlie , Maarten Lankhorst , Maxime Ripard , Simona Vetter , Thomas Zimmermann Cc: LKML , kernel-janitors@vger.kernel.org, Felix Gu , Laurent Pinchart , "Rafael J. Wysocki" , Sakari Ailus Date: Fri, 17 Jul 2026 17:14:05 -0400 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reviewed-by: Lyude Paul Will push to drm-misc-next in just a moment On Wed, 2026-03-25 at 15:05 +0100, Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 25 Mar 2026 14:55:01 +0100 >=20 > The device's last busy timestamp was set in a wrapper function since > the commit 08071e64cb642ae19ebd6ffeb13b4f3d130b5860 ("PM: runtime: > Mark last busy stamp in pm_runtime_autosuspend()"). > Thus delete a pm_runtime_mark_last_busy() call before > a pm_runtime_autosuspend() call. >=20 > The source code was transformed by using the Coccinelle software. >=20 > Signed-off-by: Markus Elfring > --- > =C2=A0drivers/gpu/drm/nouveau/nouveau_drm.c | 1 - > =C2=A01 file changed, 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c > b/drivers/gpu/drm/nouveau/nouveau_drm.c > index 5d8475e4895e..62ac9593230f 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_drm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c > @@ -1209,7 +1209,6 @@ nouveau_pmops_runtime_idle(struct device *dev) > =C2=A0 return -EBUSY; > =C2=A0 } > =C2=A0 > - pm_runtime_mark_last_busy(dev); > =C2=A0 pm_runtime_autosuspend(dev); > =C2=A0 /* we don't want the main rpm_idle to call suspend - we want > to autosuspend */ > =C2=A0 return 1;